Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Feb 2022 10:27:17 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Tong Zhang <ztong0001@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kees Cook <keescook@chromium.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Colin Ian King <colin.i.king@googlemail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Saurav Girepunje <saurav.girepunje@gmail.com>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        Johan Hovold <johan@kernel.org>, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] staging: rtl8192u: rework init and exit function
Message-ID: <20220224072717.GJ3943@kadam>
References: <YhPI5iDRUpzYWDyY@kroah.com>
 <20220224064033.1530924-3-ztong0001@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220224064033.1530924-3-ztong0001@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?byu7h3F5LDf4BcmcMS0V4HrmixnNsswgyfdB1qycBrNqZJC04DPEeb/cJ1gg?=
 =?us-ascii?Q?hoPC0Mguzt1KoaMd8dhkGl81//Eoei+zV1WJHbe28mvm+t1w5dYgtKWg19sA?=
 =?us-ascii?Q?qYwnFRCdfhuYf02M8a7zC45+u84yTcA0usoboSf8fEQvYsQ1ozlbbRauvtGL?=
 =?us-ascii?Q?FlOp/+4c210FwdvQMJYkA6zHcOO7jiBXxE61LUrJ4Fr1Hpzq0t2Sl4qLCPpg?=
 =?us-ascii?Q?vp6aWVNNwjasEKnbghFkOkTkvp5fi4gpFiNYrc5hDXfglVKfRaLfz5V88e4M?=
 =?us-ascii?Q?MKZGFO9Ze8RFwfa0EQskgMp42w9nSTvPp4xye6+r+g8uzo1gq9Sa8RxMxGwM?=
 =?us-ascii?Q?L17Qs/CUEe3Ewf6Xz4zphu7c7W1Hhs40qbP08ghtf7KyK/Si4i7+WhDbtvmF?=
 =?us-ascii?Q?DXc28A4/0Xisosw5OJ4397e6U/y1Pe0ME6rEXS+RlUPDkdv06jGyOlRlV4T8?=
 =?us-ascii?Q?UXwMKayzcr6/eEu4H7UOkN3DbBBtfq3GSGpqmQSRIaOkN7Q+c33eGOVip+zF?=
 =?us-ascii?Q?N9i33liv1ctWkxDZ0UAe1Nff4E5QH0wGeQLf59MaelC39Eszc2+VAQHh3OF1?=
 =?us-ascii?Q?o7xdn9qTsmIbStSEM8cVFiZwFsmxtYOYo0bGJyUeQ3A070dbSFMKkUAZYzls?=
 =?us-ascii?Q?PQUtNpSyxfLCs/jv4pEcKkI3SguedlWpSeXam+j2U8d7xjEftdAzwurolXVi?=
 =?us-ascii?Q?lSrbfLSAoaJ5/rRAf4QHFkDG5AdUOc4QqjS2F2VDfxXKJ+5vqpNGv7Qczfop?=
 =?us-ascii?Q?PmTvT1ZAPlZP3qIS1SB9MiE2DDZ6t7lQRRS6TKcDQzNTyatt9nhrqay3ektz?=
 =?us-ascii?Q?Y/F5bYn3Q25UHZEZ9KPLkMPFxW4KDJWOy6q4vsdT0x71ijnGZw7qw0jidpsS?=
 =?us-ascii?Q?r+7KXvMs7Wjx93rQGyuauCyYZcuwvzlJFwARWjoCN7Ri2I2v/1mvyTzc+GAs?=
 =?us-ascii?Q?d2hEbhIgm0j5Zx7g7t4w3NR+hce3DJdkdkf2hjCRTgA6CNQTlVAFel4VdH/y?=
 =?us-ascii?Q?HsUQklOmPs8gq30Sh+Ezq64/VYa80lSrYx9cm+bFqNWnE8tnoVOUceCkyELb?=
 =?us-ascii?Q?6cUnCR9zmQNzbANBm7zeFwyTb5fLJhLKJ+XbMsd8CMJKX6zRyv/+Dzz+bsyV?=
 =?us-ascii?Q?TKhRvyy+01Pie411gkc5gMRIwOFcjdi4oJAhEPETE7cILH3XKRrSWGJOgzMI?=
 =?us-ascii?Q?c8aleC+y0fctyzPIVBnhrbsIS4B9KVOsGKAiS+lK4/+ZJvdxDdhGcFM/Lz+U?=
 =?us-ascii?Q?FtbcOXc/5CqhzE1PnqxZje5xTAiZ5C28oNBmLewpwIaj02oS6LjTpznirCUV?=
 =?us-ascii?Q?qKjoRibWWN4+XXnQuVmNnfd9sl2wBR5YfuEk+WhxNKr+vspSkHx9mGqHkTxp?=
 =?us-ascii?Q?35RttlLtX3SyamYFMBaPwZX77TmLEQPOBpIjNrDL3m/VAJ+LDVLLHW5Wrw52?=
 =?us-ascii?Q?+cBdjM41Cnw4AA6ExzHeIMhGIBgBr5pPN7wwF+TqOm0ij2+d3fJvkKVayN2G?=
 =?us-ascii?Q?os+0BAnlYn6pWDFMAM8WuPKWuT7RUz/VMGRmXgc6/JymFpDd/YTV2M51G3rD?=
 =?us-ascii?Q?WJMuM7tMw4UjypmxIyo3iWSGtBP6D+kmtG/dlp3KkqkNGudA9KiT7pMRoQMC?=
 =?us-ascii?Q?pJZxwNeDq04OVHEnnN9OOR5yo3jMIpRJEMW/BQSHwWtyT/tL6FY/gQZ4MXue?=
 =?us-ascii?Q?IR4K/w=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83b3c465-04dc-45e4-6c7b-08d9f7671cb4
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 07:27:28.8507
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BVWygGREqOmejYoPa1cWOspmT+NSgERE+WYwuZ5cxipSKLbHE39KcMh2dh/NRrd/0FCj+xg5Uxq7xdKHXZmTsNRoppcSDZ27K6UMqXCzh2M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4356
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10267 signatures=681306
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0
 mlxlogscore=999 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202240043
X-Proofpoint-GUID: Nn-VDZjFpE5vN0G3l2PQL_GbLkicQm4l
X-Proofpoint-ORIG-GUID: Nn-VDZjFpE5vN0G3l2PQL_GbLkicQm4l
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 23, 2022 at 10:40:31PM -0800, Tong Zhang wrote:
> The init and exit functions are not releasing resource properly. An error
> can be observed when we load/unload/load r8192u_usb module due to this
> issue. This patch rework init and exit functions to do proper resource
> release on init error and module unload.
> The __exit attribute is stripped from some functions since they are now
> being used by module init functions.
> 
> [  493.068012] proc_dir_entry 'net/ieee80211' already registered
> [  493.271973]  proc_mkdir+0x18/0x20
> [  493.272136]  ieee80211_debug_init+0x28/0xde8 [r8192u_usb]
> [  493.272404]  rtl8192_usb_module_init+0x10/0x161 [r8192u_usb]
> 
> [   13.910616] proc_dir_entry 'net/rtl819xU' already registered
> [   13.918931]  proc_mkdir+0x18/0x20
> [   13.919098]  rtl8192_usb_module_init+0x142/0x16d [r8192u_usb]
> 
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>

Good!  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter