Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220224060503.1856302-1-keescook@chromium.org>
In-Reply-To: <20220224060503.1856302-1-keescook@chromium.org>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Wed, 23 Feb 2022 22:22:59 -0800
Message-ID: <CAMo8BfJFJE-n3=AF+pb9_6oF3gzxX7a+7aBrASHjjNX5byqDqw@mail.gmail.com>
Subject: Re: [PATCH] xtensa: Implement "current_stack_pointer"
To:     Kees Cook <keescook@chromium.org>
Cc:     Chris Zankel <chris@zankel.net>, Marc Zyngier <maz@kernel.org>,
        "open list:TENSILICA XTENSA PORT (xtensa)" 
        <linux-xtensa@linux-xtensa.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-hardening@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Feb 23, 2022 at 10:05 PM Kees Cook <keescook@chromium.org> wrote:
>
> To follow the existing per-arch conventions replace open-coded uses
> of asm "sp" as "current_stack_pointer". This will let it be used in
> non-arch places (like HARDENED_USERCOPY).
>
> Cc: Chris Zankel <chris@zankel.net>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: linux-xtensa@linux-xtensa.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  arch/xtensa/Kconfig                  | 1 +
>  arch/xtensa/include/asm/current.h    | 2 ++
>  arch/xtensa/include/asm/stacktrace.h | 2 +-
>  arch/xtensa/kernel/irq.c             | 3 +--
>  4 files changed, 5 insertions(+), 3 deletions(-)

Acked-by: Max Filippov <jcmvbkbc@gmail.com>

-- 
Thanks.
-- Max