Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp1342601pxm; Thu, 24 Feb 2022 00:56:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJydZ3yefh/ACAEv4vYqZuac7TERBZ3tTun0dSEq8hswNmrtS/ySWwjSg4L4qfhv6guZ+Vzg X-Received: by 2002:a17:907:366:b0:6ba:fff6:4fc7 with SMTP id rs6-20020a170907036600b006bafff64fc7mr1440075ejb.756.1645693012754; Thu, 24 Feb 2022 00:56:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645693012; cv=none; d=google.com; s=arc-20160816; b=tL8GmvZKOQr+EgKc6zX/cW+07VVIqCbPlx64DQ2g7c7kSael+Ai24Xhbyedscgmj3e 2pDoaILV6DWM7/FwcKaPGc5ioK3S13FrOAcfDkZtkXtGM+CrmHRxdJOGGTICZuNF8626 ETNPVqzn5ZrVYf75KqBcJFMM87PhaK4xa18eldgesDncRk/0eAKPZTfaGS5x0DOn70cQ EaHFbnkXnBkb7G1UEIdlwh2wUYCbVOGE9MnQjdu3AF60OG/Jyytu6hZKjOv6+/8HUNnI j678tdQwl/bUsRmJ0hpZgjf6R1BaEd4D9gDHCfMrhPcju4R1pEJwuRYDc2kLgaAotAez OXbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=Dcj0D0zPsXPEVS1eNhpQqfPztDcGavIHA1/tOM5ybJI=; b=TdLjnEBZ8fdE1hAyJPkRCY3c7i7k0nGjKN2S+LDptJ+Cbe3KwAIRf/Pe9SdE0DETAt SDbJ0gWX8r1CaSL9YWIqmLrVeQHnmYl4fGn86uFXE0+woPUUeRitFoEbdO3VAEBdSI+Y 4ShnZidFR7Ea8OoidLu72mdvc7SAWL/bapU710/7Oh8S9zJXeKBV398RKJ57SOjF1vCt B255aa8w3jWWNvOtv8aSX+vdDzdvdLU9gDz8fkh4S8ubFaNfM9aRz7/KY9IbRU7P0tLr YKjriVqJEWHIYUWLVBqH4Og4GZH4lEY5yOmneIpNKXgVF4zHEDen/aiUsOpdIsX6Dyqg u21w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=GGFEMmGh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g2si1020725edq.450.2022.02.24.00.56.29; Thu, 24 Feb 2022 00:56:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=GGFEMmGh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231322AbiBXInx (ORCPT + 99 others); Thu, 24 Feb 2022 03:43:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231150AbiBXInu (ORCPT ); Thu, 24 Feb 2022 03:43:50 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62EE354F8C for ; Thu, 24 Feb 2022 00:43:20 -0800 (PST) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id CEDAB3FCA2 for ; Thu, 24 Feb 2022 08:43:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645692198; bh=Dcj0D0zPsXPEVS1eNhpQqfPztDcGavIHA1/tOM5ybJI=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=GGFEMmGhEvYPXOxniMiM54AdGVvtG4CWwbZxWEDVG0NMcIyGS+opAbyuA84+eqEK/ dWxtp8q67AmOLHYLs22CUZB9QitC/NM5ahEL6S/YEMI91Z3i4899aGV6X8wM1gQ1lt +mEH09rhmkGhOjY9H0BzznOkumK/Wnhgjm4S+/WzUwPa/KJP5vwZZWdbHRyfPKIvIe s3JrOoZWYN3jj4XcF8+8CCaKfoWUmlhXlnnAWdx4rkZLrUNP1Xsbg1aFtMlmoJ+vEI /zUJK1U212L0usHLFIQwhnQ+fcUJCEFR3C8br/46j7JRjFvdz8r8VqFjFfnJXB4dBE jkiXDFJXMOCLA== Received: by mail-ed1-f70.google.com with SMTP id l24-20020a056402231800b00410f19a3103so427741eda.5 for ; Thu, 24 Feb 2022 00:43:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=Dcj0D0zPsXPEVS1eNhpQqfPztDcGavIHA1/tOM5ybJI=; b=lLeXDsuUny/l1Rwwe4B16k3ecrhmBNlVh4H5VYuFgj60SaDuBu4YFY/bIVu0ev5rZZ I347uXFM9JtYpZvliCgxYfSxowo/7C1Rnaro/QZpWjyZ12/5dgi3KRaKH8ri/EmyoYNO 7Kr+MuY0t39cxkFGxyCN3BmtGYusNS3s8Wa+rynOTGpHu/CAxJUHrmhnQna1I5g0Pa+c mnTeH1GpAF3s9d5/LTw6ehqrLfdDqgdGqT9XQt/Ht3m8dYcQPC63qkC9CG2RYFmS8NI3 kSYkBoXUsiRESS8qLkKmjhqB779QPsxHC6MDNmmubI43hpb43faeqHXorgDFuHURHFLb 8GFg== X-Gm-Message-State: AOAM532u0E9RlErTkmm48YV+VX1aoNEvJDduMssVvDWeB1XgkLO4uUEk 4IJSYEv2piK5vZdoGUYiYqRN3KtTcVTq2bmBgYEpixAlfZYNxeS71+Azll0umHG1dYojeMPIbta sLlqo46vBVhcz6lGciMRNombKZLpQop8iiAjPCzIuBw== X-Received: by 2002:a05:6402:2744:b0:404:ba60:fec6 with SMTP id z4-20020a056402274400b00404ba60fec6mr1261640edd.235.1645692198567; Thu, 24 Feb 2022 00:43:18 -0800 (PST) X-Received: by 2002:a05:6402:2744:b0:404:ba60:fec6 with SMTP id z4-20020a056402274400b00404ba60fec6mr1261610edd.235.1645692198343; Thu, 24 Feb 2022 00:43:18 -0800 (PST) Received: from [192.168.0.127] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id 16sm1006988eji.94.2022.02.24.00.43.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Feb 2022 00:43:17 -0800 (PST) Message-ID: Date: Thu, 24 Feb 2022 09:43:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 01/11] driver: platform: add and use helper for safer setting of driver_override Content-Language: en-US From: Krzysztof Kozlowski To: Bjorn Helgaas Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Stuart Yoder , Laurentiu Tudor , Abel Vesa , Shawn Guo , Sascha Hauer , Fabio Estevam , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , Srinivas Kandagatla , Mark Brown , "Michael S. Tsirkin" , Jason Wang , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds , Rasmus Villemoes References: <20220223215342.GA155282@bhelgaas> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/02/2022 08:47, Krzysztof Kozlowski wrote: > On 23/02/2022 22:53, Bjorn Helgaas wrote: >> On Wed, Feb 23, 2022 at 08:13:00PM +0100, Krzysztof Kozlowski wrote: >>> Several core drivers and buses expect that driver_override is a >>> dynamically allocated memory thus later they can kfree() it. >>> ... >> >>> + * set_driver_override() - Helper to set or clear driver override. >> >> Doesn't match actual function name. > > Good point. I wonder why build W=1 did not complain... I need to check. > I see why - I missed kerneldoc /** opener. Best regards, Krzysztof