Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] Input: samsung-keypad - Properly state IOMEM dependency
To:     David Gow <davidgow@google.com>,
        Joonyoung Shim <jy0922.shim@samsung.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-um@lists.infradead.org
References: <20220224035819.1593730-1-davidgow@google.com>
From:   Anton Ivanov <anton.ivanov@cambridgegreys.com>
Message-ID: <19c9bf24-c3e1-36a3-376e-7091cc3b3f62@cambridgegreys.com>
Date:   Thu, 24 Feb 2022 08:03:40 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20220224035819.1593730-1-davidgow@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 24/02/2022 03:58, David Gow wrote:
> Make the samsung-keypad driver explicitly depend on CONFIG_IOMEM, as it
> calls devm_ioremap(). This prevents compile errors in some configs (e.g,
> allyesconfig/randconfig under UML):
> 
> /usr/bin/ld: drivers/input/keyboard/samsung-keypad.o: in function `samsung_keypad_probe':
> samsung-keypad.c:(.text+0xc60): undefined reference to `devm_ioremap'
> 
> Signed-off-by: David Gow <davidgow@google.com>
> ---
>   drivers/input/keyboard/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
> index 0c607da9ee10..5c98d5f996e4 100644
> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@ -556,7 +556,7 @@ config KEYBOARD_PMIC8XXX
>   
>   config KEYBOARD_SAMSUNG
>   	tristate "Samsung keypad support"
> -	depends on HAVE_CLK
> +	depends on IOMEM && HAVE_CLK
>   	select INPUT_MATRIXKMAP
>   	help
>   	  Say Y here if you want to use the keypad on your Samsung mobile
> 
Acked-By: anton ivanov <anton.ivanov@cambridgegreys.com>

-- 
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/