Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Feb 2022 13:01:48 +0000
From:   Aaron Tomlin <atomlin@atomlin.com>
To:     Marcelo Tosatti <mtosatti@redhat.com>
Cc:     Frederic Weisbecker <frederic@kernel.org>,
        Christoph Lameter <cl@linux.com>, tglx@linutronix.de,
        mingo@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Phil Auld <pauld@redhat.com>
Subject: Re: [RFC PATCH] tick/sched: Ensure quiet_vmstat() is called when the
 idle tick was stopped too
Message-ID: <20220224130148.xfpfmybrtayjncor@ava.usersys.com>
References: <20220203214339.1889971-1-atomlin@redhat.com>
 <20220217124729.GA743618@lothringen>
 <20220217142615.xqtiydixvnumyvei@ava.usersys.com>
 <20220217163205.GA748087@lothringen>
 <20220218125454.utlgmuhijklzr3if@ava.usersys.com>
 <20220219154616.pwsvh445x3vn7ltf@ava.usersys.com>
 <Yhd5olg9CjXSAf2s@fuller.cnet>
 <Yhd6UxWH3FQHg+eF@fuller.cnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <Yhd6UxWH3FQHg+eF@fuller.cnet>
Precedence: bulk

On Thu 2022-02-24 09:30 -0300, Marcelo Tosatti wrote:
> > > > > 2) What if we are running task A in kernel mode while the tick is stopped
> > > > >    (nohz_full). Task A modifies the vmstat and goes to userspace for a long
> > > > >    while.
> > > > > Your patch fixes case 1) but not case 2). The problem is that TIMER_DEFERRABLE
> > > > > should really be about dynticks-idle only and not dynticks-full. I've always
> > > > > been afraid about enforcing that rule though because that would break old
> > > > > noise-free setups. But perhaps I should...
> 
> Can't grasp the sentence above "The problem is that ...".
> What rule?

Hi Marcelo,

That statement was from Frederic.


Kind regards,

-- 
Aaron Tomlin