Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220224103030.2040048-1-michael@walle.cc> <20220224103030.2040048-2-michael@walle.cc>
In-Reply-To: <20220224103030.2040048-2-michael@walle.cc>
From:   Heiko Thiery <heiko.thiery@gmail.com>
Date:   Thu, 24 Feb 2022 13:09:31 +0100
Message-ID: <CAEyMn7ZU8EQCUWYDTyC5m0j7x-6NEyuG95czjL4P98MMpCDL9g@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: imx8mn-evk: fix the min/max voltages
 of the PMIC
To:     Michael Walle <michael@walle.cc>
Cc:     Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Shawn Guo <shawnguo@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

Am Do., 24. Feb. 2022 um 11:30 Uhr schrieb Michael Walle <michael@walle.cc>:
>
> Use the proper voltages as supported by the board instead of the ones
> supported by the PMIC. The voltages were taken from both the schematic
> of the 8MNANOLPD4-EVK eval board and the datasheet of the IMX8MN SoC.
>
> Signed-off-by: Michael Walle <michael@walle.cc>

Reviewed-by: Heiko Thiery <heiko.thiery@gmail.com>

> ---
> Please help review and test this. This was never tested on the actual
> 8MNANOLPD4-EVK because I don't have that board! Instead it is a
> "byproduct" of the development of an devicetree for the 8MNANOD3L-EVK
> which is quite similar except for the DDR voltage and the buck2
> converter.
>
> Changes since v1:
>  - swap buck1 and buck2
>
>  arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 34 ++++++++++----------
>  1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> index 2b685c0c7eeb..4eb467df5ba7 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> @@ -42,8 +42,8 @@ pmic: pmic@25 {
>                 regulators {
>                         buck1: BUCK1{
>                                 regulator-name = "VDD_SOC";
> -                               regulator-min-microvolt = <600000>;
> -                               regulator-max-microvolt = <2187500>;
> +                               regulator-min-microvolt = <850000>;
> +                               regulator-max-microvolt = <950000>;
>                                 regulator-boot-on;
>                                 regulator-always-on;
>                                 regulator-ramp-delay = <3125>;
> @@ -51,8 +51,8 @@ buck1: BUCK1{
>
>                         buck2: BUCK2 {
>                                 regulator-name = "VDD_ARM_0V9";
> -                               regulator-min-microvolt = <600000>;
> -                               regulator-max-microvolt = <2187500>;
> +                               regulator-min-microvolt = <850000>;
> +                               regulator-max-microvolt = <1000000>;
>                                 regulator-boot-on;
>                                 regulator-always-on;
>                                 regulator-ramp-delay = <3125>;
> @@ -62,32 +62,32 @@ buck2: BUCK2 {
>
>                         buck4: BUCK4{
>                                 regulator-name = "VDD_3V3";
> -                               regulator-min-microvolt = <600000>;
> -                               regulator-max-microvolt = <3400000>;
> +                               regulator-min-microvolt = <3300000>;
> +                               regulator-max-microvolt = <3300000>;
>                                 regulator-boot-on;
>                                 regulator-always-on;
>                         };
>
>                         buck5: BUCK5{
>                                 regulator-name = "VDD_1V8";
> -                               regulator-min-microvolt = <600000>;
> -                               regulator-max-microvolt = <3400000>;
> +                               regulator-min-microvolt = <1800000>;
> +                               regulator-max-microvolt = <1800000>;
>                                 regulator-boot-on;
>                                 regulator-always-on;
>                         };
>
>                         buck6: BUCK6 {
>                                 regulator-name = "NVCC_DRAM_1V1";
> -                               regulator-min-microvolt = <600000>;
> -                               regulator-max-microvolt = <3400000>;
> +                               regulator-min-microvolt = <1100000>;
> +                               regulator-max-microvolt = <1100000>;
>                                 regulator-boot-on;
>                                 regulator-always-on;
>                         };
>
>                         ldo1: LDO1 {
>                                 regulator-name = "NVCC_SNVS_1V8";
> -                               regulator-min-microvolt = <1600000>;
> -                               regulator-max-microvolt = <3300000>;
> +                               regulator-min-microvolt = <1800000>;
> +                               regulator-max-microvolt = <1800000>;
>                                 regulator-boot-on;
>                                 regulator-always-on;
>                         };
> @@ -95,23 +95,23 @@ ldo1: LDO1 {
>                         ldo2: LDO2 {
>                                 regulator-name = "VDD_SNVS_0V8";
>                                 regulator-min-microvolt = <800000>;
> -                               regulator-max-microvolt = <1150000>;
> +                               regulator-max-microvolt = <800000>;
>                                 regulator-boot-on;
>                                 regulator-always-on;
>                         };
>
>                         ldo3: LDO3 {
>                                 regulator-name = "VDDA_1V8";
> -                               regulator-min-microvolt = <800000>;
> -                               regulator-max-microvolt = <3300000>;
> +                               regulator-min-microvolt = <1800000>;
> +                               regulator-max-microvolt = <1800000>;
>                                 regulator-boot-on;
>                                 regulator-always-on;
>                         };
>
>                         ldo4: LDO4 {
>                                 regulator-name = "VDD_PHY_1V2";
> -                               regulator-min-microvolt = <800000>;
> -                               regulator-max-microvolt = <3300000>;
> +                               regulator-min-microvolt = <1200000>;
> +                               regulator-max-microvolt = <1200000>;
>                                 regulator-boot-on;
>                                 regulator-always-on;
>                         };
> --
> 2.30.2
>