Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp1624944pxm; Thu, 24 Feb 2022 06:39:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJyaschFcljD7Why0pd7bFYQ+7nz/BVLmBhFAO2z8HI2bOE/XKyfnxLRenkY4L23WTGIe83K X-Received: by 2002:a17:903:2290:b0:150:8ce:963a with SMTP id b16-20020a170903229000b0015008ce963amr2883950plh.53.1645713559524; Thu, 24 Feb 2022 06:39:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645713559; cv=none; d=google.com; s=arc-20160816; b=DhP5ye2vUYkoZqjd/RHvOvyxf76vu7BrK5hLSIqU3ClIaCKcCTPHG3MpIwb3+a6EZH DcZ0NCPOGyKm5R2U2/jDHWjFKt8JknCbFJrhke5R/LfAKtJKd+eNGXBr5fQmDnvFtdKo ZAH7YMYaHAyZiGCAQ/5Q7I2d7MNAMe6tioRgqMTLtor/9H08SwBxA14fQ/Ea72DXlk8s MG0KaSml2F6FinftHTdDIEcig9ven5nDfFz8PetPGyaGFV7HNLh7LGxw2q39cdN6pBB3 KrNiHVCUlJhRiEpfjzSb24wlD4vH2EsLuUCeV5NYDYYItGINLY7w2MZ6/QjDuDkj9ST1 urpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=YBLvfr3OobSAV/rNNzdpOTHNgJpHKsaNfSljGVW3xNc=; b=Z99XiTTl+JcaoKBL3oFMgLibHV6p+2wF4zIbXCfG/sZsDtVHhYbOKPl7zc+D9CbxdD dj5LbZnPVYAik0ek3/o4TPqSA4niwMW9XP367UH3qc9B9pK8BFYzZLKMzOkPlnqfWM04 W8bs2Jf/ykHYJAXLRlcEZQW65UIEtc8XZpaXmY1zpoHkS30779iIOSleqDJ1hdNgLvyu eDPGiAtdTT3Sc1qNS0Wyk61RutyubvP/tSYpxeTG1/IRvM/huNtzNHyvPjcNSnOlRmXd TToH1uOUaH5v4ZZF+zGNS8m9KHOktpOtuXJfC4cI1G7Q6+83Efz9UCcyZcXWXdERW2/J ktjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=lvUTuTfu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l193si3141153pga.636.2022.02.24.06.38.59; Thu, 24 Feb 2022 06:39:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=lvUTuTfu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234081AbiBXLWV (ORCPT + 99 others); Thu, 24 Feb 2022 06:22:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230236AbiBXLWT (ORCPT ); Thu, 24 Feb 2022 06:22:19 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12F5E59A7D; Thu, 24 Feb 2022 03:21:50 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: sre) with ESMTPSA id C99451F42062 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1645701708; bh=YBLvfr3OobSAV/rNNzdpOTHNgJpHKsaNfSljGVW3xNc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lvUTuTfupIEMLS2D7sVgrU3AzNiTKEx59CsDtF2KkMSfFDFts4QUDfZaLiuiIFsNI tkqgWySO0Z0TtD1y5saPM0UR4m3BX+DIMv8N3eLGjRQfN32GZfZnnnIajPVvezQlnM KRPoIj4laLzVsBIxu9khBXGqEA0Xqsue05u1BMJwSTjD+8GEzErj9LlPVCVL3G6MrP 2zsFwf3iqvBMX885kCgArCCtcZbRHSWL1uPcsWU/CbwnMpRHt+ewOiJeThfl3xtlYL dqwESKlMXAUo84XxttXnoQOiP/YR9LDPYMXRzWQ8YRR5f3byaOzX6Qym0GJXZ4vqFh b589cqNtd5oYA== Received: by mercury (Postfix, from userid 1000) id CA609106049B; Thu, 24 Feb 2022 12:21:46 +0100 (CET) Date: Thu, 24 Feb 2022 12:21:46 +0100 From: Sebastian Reichel To: Adam Thomson Cc: Christophe JAILLET , Support Opensource , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , "linux-pm@vger.kernel.org" Subject: Re: [PATCH] power: supply: da9150-fg: Use devm_delayed_work_autocancel() Message-ID: <20220224112146.ytrcop3lcjfd6f6n@mercury.elektranox.org> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qbwhz74rtboa72lk" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qbwhz74rtboa72lk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Feb 18, 2022 at 01:13:10PM +0000, Adam Thomson wrote: > On 13 February 2022 17:55, Christophe JAILLET wrote: >=20 > > This driver only uses managed resources, except for the delayed work, if > > it is used. > >=20 > > Use devm_delayed_work_autocancel() to also manage the delayed work. > > The error handling path of the probe and the remove function can both be > > removed. > >=20 > > This saves a few lines of code. > >=20 > > Signed-off-by: Christophe JAILLET >=20 > Reviewed-by: Adam Thomson Thanks, queued. -- Sebastian --qbwhz74rtboa72lk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmIXakoACgkQ2O7X88g7 +pobYA/+LlE8lFoeRCKrCzws94CDRC8eF3Rogl4SuwGgSpRBMbjrIiW5rSF6RwtX E1qmWrpCPyksk2i9QsIOiSY8WCWmoo7LnUqVwEfZNtftpXJrwZyo1lKVTepShSvl ti4oJYhdTjIKxyfJfpKzd3D8icLkdoPG3Wv46DosxtcXFJIRrXGYR3RaMQLQyu09 x6chf/sSQDgrsZUtuKdtCTJeBpwoSXIjur2UV4i4wMxw6q0HqPeGJcPpBmnYPsHL 7KeJPNA0sTcnjXgherqm5l5KVxNDEoXajKKga9XykvO8BQZvxkI5V72AtAxJxT0v Ya5DgwtTW0vkSEMQwHARbUrz091BIZSBJkBtkjz8oNLhxi4q9fB99qO+DxrtoZm3 3EcbxqkmJpjSrm7pslOjc9awj83TxpNBsbxrDEDTxPsf8gGx/ucTUuz0H97Gmf0V rXsgYCVBkQu9MFS7kjdLLoF30CH0R2oJTQoD1YSk+WXN+E5t3inufJVMQMillt4Y JJeS1ZW/RTK2VD7yXzz/XDOYE2KPajgRwhZLXzRy2s1vYnjU14z91fklS4Yt3zft R4eHxSfe4khDViUiDMcm4ssQxxUM4O2tejCy3FdghPaKp/n25Nbnu5OQ0bEkVZy4 UFAWrPkv32SzNmW5DjrgJ6JUwVVsqAtLZsl34f+MCZb6+Q+8PiQ= =LDsa -----END PGP SIGNATURE----- --qbwhz74rtboa72lk--