Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 24 Feb 2022 15:55:05 +0100
From:   Michael Walle <michael@walle.cc>
To:     Nicolas Ferre <nicolas.ferre@microchip.com>
Cc:     Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>,
        arnd@arndb.de, alexandre.belloni@bootlin.com, olof@lixom.net,
        soc@kernel.org, robh+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com,
        Manohar.Puri@microchip.com
Subject: Re: [PATCH v7] ARM: dts: add DT for lan966 SoC and 2-port board
 pcb8291
In-Reply-To: <85566f97-dcfc-f477-1ebb-5cac955b791a@microchip.com>
References: <20220221080858.14233-1-kavyasree.kotagiri@microchip.com>
 <3b4c56201a478876783e69243c901cd8@walle.cc>
 <85566f97-dcfc-f477-1ebb-5cac955b791a@microchip.com>
User-Agent: Roundcube Webmail/1.4.12
Message-ID: <413b29b8a2e7a73561f942d4b7c78b9b@walle.cc>
Precedence: bulk

Hi,

Am 2022-02-24 15:51, schrieb Nicolas Ferre:
>>> +/ {
>>> +     model = "Microchip LAN966 family SoC";
>>> +     compatible = "microchip,lan966";
>> 
>> As mentioned earlier, this isn't a documented compatible string. So,
>> I guess without overwriting this in the board dts it will throw an
>> error with the dt schema validator. OTOH, there are many dtsi files
>> in arch/arm/boot/dts/ doing this. I don't know what is correct here.
> 
> I see it documented here:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/atmel-at91.yaml#n165
> 
> Isn't it what is expected?

That only documents
   compatible = "microchip,lan9662-pcb8291", "microchip,lan9662", 
"microchip,lan966";

But not the one above.

> 
>> Everthing else looks good.
> 
> Thanks a lot for your reviews.
> 
>> Reviewed-by: Michael Walle <michael@walle.cc>
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> I'm queuing it to at91-dt branch for reaching arm-soc in 5.18 merge 
> window.

Nice, then I'm good to go for my patches on top of this :)

-michael