Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <b68771ca-2f5d-f803-6c47-f426f5ce07ee@redhat.com>
Date:   Thu, 24 Feb 2022 15:24:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2] KVM:VMX:Remove scratch 'cpu' variable that shadows an
 identical scratch var
Content-Language: en-US
To:     Peng Hao <flyingpenghao@gmail.com>, seanjc@google.com
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220222103954.70062-1-flyingpeng@tencent.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <20220222103954.70062-1-flyingpeng@tencent.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/22/22 11:39, Peng Hao wrote:
>   From: Peng Hao <flyingpeng@tencent.com>
> 
>   Remove a redundant 'cpu' declaration from inside an if-statement that
>   that shadows an identical declaration at function scope.  Both variables
>   are used as scratch variables in for_each_*_cpu() loops, thus there's no
>   harm in sharing a variable.
> 
> Reviewed-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Peng Hao <flyingpeng@tencent.com>
> ---
>   arch/x86/kvm/vmx/vmx.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index ba66c171d951..6101c2980a9c 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -7931,7 +7931,6 @@ static int __init vmx_init(void)
>   	    ms_hyperv.hints & HV_X64_ENLIGHTENED_VMCS_RECOMMENDED &&
>   	    (ms_hyperv.nested_features & HV_X64_ENLIGHTENED_VMCS_VERSION) >=
>   	    KVM_EVMCS_VERSION) {
> -		int cpu;
>   
>   		/* Check that we have assist pages on all online CPUs */
>   		for_each_online_cpu(cpu) {

Queued, thanks.

Paolo