Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <6a86f8c481be417972ef1b1e3b902ccf95706547.1645149279.git.lhjeff911@gmail.com>
In-Reply-To: <6a86f8c481be417972ef1b1e3b902ccf95706547.1645149279.git.lhjeff911@gmail.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Thu, 24 Feb 2022 07:36:15 -0600
Message-ID: <CAL_Jsq+tMG_8nYaZDaU2pPgy7+bXfPxATSeoJKKyR=kv=x=70g@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: spi: delete unused required and adjust the item.
To:     Li-hao Kuo <lhjeff911@gmail.com>
Cc:     Mark Brown <broonie@kernel.org>,
        linux-spi <linux-spi@vger.kernel.org>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?V2VsbHMgTHUg5ZGC6Iqz6aiw?= <wells.lu@sunplus.com>,
        "LH.Kuo" <lh.kuo@sunplus.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Feb 17, 2022 at 7:56 PM Li-hao Kuo <lhjeff911@gmail.com> wrote:
>
> delete unused required(clock-name)
> adjust position (interrupts)

Why? This seems like an unnecessary change.

Please write complete sentences that answer why this change is needed,
not what the change is. The diff describes what changed. In this case,
quoting the warning you are fixing is typical.

>
> Fixes: 3b8ab4da34 ("spi: Fix test error for sp7021")
>

There should not be a blank line here.

> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> index 298eac2..9df08d7 100644
> --- a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> @@ -47,10 +47,9 @@ required:
>    - compatible
>    - reg
>    - reg-names
> -  - interrupts
>    - interrupt-names
> +  - interrupts
>    - clocks
> -  - clocks-names
>    - resets
>    - pinctrl-names
>    - pinctrl-0
> --
> 2.7.4
>