Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <f3f28a3d-b7ec-e91e-1e8d-9d34da76a2a1@microchip.com>
Date:   Thu, 24 Feb 2022 16:10:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2] ARM: dts: at91: sama5d2: Fix PMERRLOC resource size
Content-Language: en-US
To:     Tudor Ambarus <tudor.ambarus@microchip.com>, <ada@thorsis.com>
CC:     <alexandre.belloni@bootlin.com>, <ludovic.desroches@microchip.com>,
        <robh+dt@kernel.org>, <bbrezillon@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <stable@vger.kernel.org>
References: <20220111132301.906712-1-tudor.ambarus@microchip.com>
From:   Nicolas Ferre <nicolas.ferre@microchip.com>
Organization: microchip
In-Reply-To: <20220111132301.906712-1-tudor.ambarus@microchip.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/01/2022 at 14:23, Tudor Ambarus wrote:
> PMERRLOC resource size was set to 0x100, which resulted in HSMC_ERRLOCx
> register being truncated to offset x = 21, causing error correction to
> fail if more than 22 bit errors and if 24 or 32 bit error correction
> was supported.
> 
> Fixes: d9c41bf30cf8 ("ARM: dts: at91: Declare EBI/NAND controllers")
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> Cc: <stable@vger.kernel.org> # 4.13.x

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Even if it's a fix, as we have this bug for a long time and that we are 
already at rc5 of the stabilization phase, I take it in at91-dt branch 
for 5.18 and not in another "fixes" batch.

Best regards,
   Nicolas

> ---
> v2:
> - update commit description
> - Cc stable@vger.kernel.org
> 
>   arch/arm/boot/dts/sama5d2.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 09c741e8ecb8..c700c3b19e4c 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -415,7 +415,7 @@ hsmc: hsmc@f8014000 {
>   				pmecc: ecc-engine@f8014070 {
>   					compatible = "atmel,sama5d2-pmecc";
>   					reg = <0xf8014070 0x490>,
> -					      <0xf8014500 0x100>;
> +					      <0xf8014500 0x200>;
>   				};
>   			};
>   


-- 
Nicolas Ferre