Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp1714329pxm; Thu, 24 Feb 2022 08:06:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJyyZf3FF9tMhn9hI6rSNKzhdtsdDQZbjgkxdSbUyyrKZYOwKoRmkdKJw73V9FOc1mxv4Woa X-Received: by 2002:a05:6a00:1a0b:b0:4cf:9a9:5c5f with SMTP id g11-20020a056a001a0b00b004cf09a95c5fmr3505376pfv.45.1645718778558; Thu, 24 Feb 2022 08:06:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645718778; cv=none; d=google.com; s=arc-20160816; b=ylN265sw0FgPsMX/TMXLQkvuPeacSC03BZIRdxH3ZkCShd2nOEZp96eED3pK7ctgYO oezh1Tu2pLv5NENb29IcdtBLlH7EuYjIliYSkfGBnhl8ISbUojdM/waDItEmEtXvs1pG j8VUtXyujk/zWB+S950vEyymBci3o/PfZfZWaJpJT5lKdzwhTjqIvDX5zVFc1xXZ6lAs 7czpEE6aWfUY/v4dcrzGgY6O/nKXE6T21lcZ3ZnKETMbrYHbc7KXNdePiTSSHxln0Tzg zhpRnLi3miQZtLsDf8NekOr8/aDWnKm6RZcVUytNgx8uf00b4W/wqKUOB3dADh3kMpit SOsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=JBxbP4mnt4PQT7En4CTQ+ZSao55n9SOd/y/IHHDxShQ=; b=AmwBNHBb5WAJc9ifNzCYNnQNZ/hnIeQaSSEoSVsiAjqKKkL9xOsxeV4m/nPUjX0m9Q +YFNrG/kaN0/yADdzYc3YyiehSl0oIIQrrMqjA0dYtOXSZHnYvNaZkj1b2ZWdyToLU09 ePkcDo+tsC+6RtLE9/W3UaV63ua3TYLb+SouWsqcCaxo/gXaitSxFZTcDu38jslxfRZW L6HGURXUsdpFf0Qfv72BIdAGbDXkeljxKE8PVCGM2PP1WkbH1P4IH0ZR8vQNonziVWh/ 8tRmwg9h3rwL06Yela2dJK4sOFefNL6kvJvfVbz/5OC9QQMgTYtAjBs0UUBYb7uueYMe Deng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=dzKhQAuz; dkim=neutral (no key) header.i=@suse.cz; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id j3si3036057plx.205.2022.02.24.08.06.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Feb 2022 08:06:18 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=dzKhQAuz; dkim=neutral (no key) header.i=@suse.cz; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 99EA7192CBB; Thu, 24 Feb 2022 08:02:20 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235378AbiBXOVC (ORCPT + 99 others); Thu, 24 Feb 2022 09:21:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229756AbiBXOVB (ORCPT ); Thu, 24 Feb 2022 09:21:01 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEE04294FFF; Thu, 24 Feb 2022 06:20:31 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 71E791F44C; Thu, 24 Feb 2022 14:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1645712430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JBxbP4mnt4PQT7En4CTQ+ZSao55n9SOd/y/IHHDxShQ=; b=dzKhQAuzzFjSdVY2KXefIhWND0BqHCS5hHFd+QD0vYdJzJi6NEOYbeUqDuEVvC9LXuGeeC lByQkyo+sgIepE5w036yP0cmxejRSKzHwsujs3KyqjASejp/EdKq56Lf6qaHkMslDCSJkC optx+FRHCxeIRTnKxMk0w3TxEogBZpQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1645712430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JBxbP4mnt4PQT7En4CTQ+ZSao55n9SOd/y/IHHDxShQ=; b=w9m02HCZyuzQDwgPJ/k7jUYIkxUch/Z6WSYRQR6jOeOugcQ8MSUc638b3TRF7iWT0ib27X AqQUJPAO2wapNlDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E7CE313AE7; Thu, 24 Feb 2022 14:20:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mzqZNi2UF2I6PgAAMHmgww (envelope-from ); Thu, 24 Feb 2022 14:20:29 +0000 From: Petr Vorel To: zohar@linux.ibm.com Cc: dvyukov@google.com, ebiggers@kernel.org, jmorris@namei.org, keescook@chromium.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, serge@hallyn.com Subject: Re: [PATCH 2/2] integrity: double check iint_cache was initialized Date: Thu, 24 Feb 2022 15:20:25 +0100 Message-Id: <20220224142025.2587-1-pvorel@suse.cz> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20210322154207.6802-2-zohar@linux.ibm.com> References: <20210322154207.6802-2-zohar@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mimi, Tetsuo, Kees, all, FYI this commit merged as 92063f3ca73a ("integrity: double check iint_cache was initialized") is the reason for openSUSE distro installer going back from lsm= to deprecated security= when filling default grub parameters because security=apparmor or security=selinux does not break boot when used with ima_policy=tcb, unlike using lsm. @Kees, @Mimi sure, people who use ima_policy=tcb will just remove lsm parameter or add "integrity" to it but I wonder whether there could be "integrity" automatic inclusion when using ima_policy=tcb. Although the point of lsm= (and CONFIG_LSM) is to have *ordered* list of enabled LSMs and it wouldn't be clear on which place. Kind regards, Petr