Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Feb 2022 17:38:03 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Jiri Slaby <jslaby@suse.cz>
Cc:     gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Laxman Dewangan <ldewangan@nvidia.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        linux-tegra@vger.kernel.org
Subject: Re: [PATCH 2/5] tty: serial: make use of UART_LCR_WLEN() +
 tty_get_char_size()
Message-ID: <Yhe0a0RX8XTBF8BL@orome>
References: <20220224095517.30872-1-jslaby@suse.cz>
 <20220224095558.30929-1-jslaby@suse.cz>
 <20220224095558.30929-2-jslaby@suse.cz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="bGyWIReJ9zdg8psW"
Content-Disposition: inline
In-Reply-To: <20220224095558.30929-2-jslaby@suse.cz>
User-Agent: Mutt/2.2.1 (c8109e14) (2022-02-19)
Precedence: bulk


--bGyWIReJ9zdg8psW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 24, 2022 at 10:55:55AM +0100, Jiri Slaby wrote:
> Having a generic UART_LCR_WLEN() macro and the tty_get_char_size()
> helper, we can remove all those repeated switch-cases in drivers.
>=20
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: linux-tegra@vger.kernel.org
> ---
>  drivers/tty/serial/8250/8250_omap.c | 16 +---------------
>  drivers/tty/serial/8250/8250_port.c | 16 +---------------
>  drivers/tty/serial/jsm/jsm_cls.c    | 16 +---------------
>  drivers/tty/serial/jsm/jsm_neo.c    | 16 +---------------
>  drivers/tty/serial/omap-serial.c    | 16 +---------------
>  drivers/tty/serial/pxa.c            | 16 +---------------
>  drivers/tty/serial/serial-tegra.c   | 22 ++++------------------
>  drivers/tty/serial/vr41xx_siu.c     | 15 +--------------
>  8 files changed, 11 insertions(+), 122 deletions(-)

This would've been easier to review if I had this in my inbox, but I did
find it on lkml.org and this does look correct, so:

Reviewed-by: Thierry Reding <treding@nvidia.com>

--bGyWIReJ9zdg8psW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmIXtGsACgkQ3SOs138+
s6G8LA//a6T2l7OdGOi6gS4JTGpVy3oswh/dgzFUZyXLfgc/hZ4+XfafpeRT0tHj
F3NYARAAYfXtWh0WXj7scRQd1Kcax8wBO8ltzhUU+Qv/QWzmt3tDhrzD3LqxHoN1
qmI+AEBkfr81HRR/NWnbn1h11SwtEUzPrPaOhSkaGkTZqD2gk8D093cC7YVqB+er
5TvEM9BP9/BGtcLoA+1p/Ir+TIbxUd1fFdGVYsJ32rYBssAtBvn3wiC08oByrOrL
Qx0im6NLDjxffI7Ijxw4257lQy9wSGq7S8HxmPb+gTSn9IYwllo4zhC9A6ZzT643
CheDmqm++kfg5Ijrg8PQmuXzQ2m89Z0b0n3rQA6P/N59hqWg0obU8M8+wTbQfiXw
GPeWHW9iwe+yrcU0B+CjP8uVFCq/6m/JzalevUvP1G2tnIG3At7xL45YpU+YI07h
cdEYQuG5Yom0RCwSX8f4W7UB8KRL6UJclqUbAfUc2h6MReYMkhguxTi7O/Qc7Lkv
SuUJ6765xPhSmqouxo+b4Id0gvCg9AHElyD/q6K4sgEFdFy4NqonAJZJj00YsGVf
BoLZ834npx8Vd9DUgPrGzRzTSOBvPzUAIOli8pk5e2DyvO2fNgg6RJrWESn1U+Ly
vTaLIAsh31wu9T9/E67OBAaohALhLETkgjh5Wed9uBOAwpxFbhw=
=5bfD
-----END PGP SIGNATURE-----

--bGyWIReJ9zdg8psW--