Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Feb 2022 17:49:18 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     Max Kellermann <max.kellermann@gmail.com>,
        linux-pwm@vger.kernel.org, lee.jones@linaro.org,
        linux-kernel@vger.kernel.org, andrey@lebedev.lt,
        stable@vger.kernel.org
Subject: Re: [PATCH 1/3] pwm-sun4i: convert "next_period" to local variable
Message-ID: <20220224164918.ycdjmfsqqasehzks@pengutronix.de>
References: <20220125123429.3490883-1-max.kellermann@gmail.com>
 <20220125143158.qbelqvr5mjq33zay@pengutronix.de>
 <YheCV0RKJcB/ppCn@orome>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qlqvaaqanoepdo5f"
Content-Disposition: inline
In-Reply-To: <YheCV0RKJcB/ppCn@orome>
Precedence: bulk


--qlqvaaqanoepdo5f
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 24, 2022 at 02:04:23PM +0100, Thierry Reding wrote:
> On Tue, Jan 25, 2022 at 03:31:58PM +0100, Uwe Kleine-K=F6nig wrote:
> > Hello,
> >=20
> > On Tue, Jan 25, 2022 at 01:34:27PM +0100, Max Kellermann wrote:
> > > Its value is calculated in sun4i_pwm_apply() and is used only there.
> > >=20
> > > Cc: stable@vger.kernel.org
> >=20
> > I think I'd drop this. This isn't a fix worth on it's own to be
> > backported and if this is needed for one of the next patches, the stable
> > maintainers will notice themselves (and it might be worth to shuffle
> > this series to make the fixes come first).
> >=20
> > > Signed-off-by: Max Kellermann <max.kellermann@gmail.com>
> >=20
> > Other than that, LGTM:
> >=20
> > Reviewed-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
>=20
> Does that apply to patches 2 & 3 as well?

No, at that time I only looked at patch 1.

I just looked at 2 and 3 and will reply to them individually.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--qlqvaaqanoepdo5f
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmIXtwsACgkQwfwUeK3K
7AnapAgAg+SjkyiP1o2sdudhtyt/I8k3O97+iBe5pyPY0TLq1NP5yp3vZhqf7NMz
DTGcIrQxmSbQa4/NKXhBbP/78Rc+5PIYJhYYxUBk50IX98DHegOIYP1IqMv8X4DF
mlNGshVaFj+kbUnSVoLYqjrbCcV9DD2XLJRt4E7F5qGQuLSES4uzpud03Pa9XkzU
E+U9m045ILyAxjXXbS1Que16WcYxvo1cdDo4cvQM9lhGQKCY7iobmSykBTR3SVhW
F5XCQb+0TZ9lBSGlzeE5FHKpRP8387mMfYA97G03pUGx+n409affOSB5sWS5uBBY
oG5GnrIdRe2evQEXH+xwLz+6S7LN7A==
=vqBF
-----END PGP SIGNATURE-----

--qlqvaaqanoepdo5f--