Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Feb 2022 17:51:35 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Max Kellermann <max.kellermann@gmail.com>
Cc:     linux-pwm@vger.kernel.org, thierry.reding@gmail.com,
        lee.jones@linaro.org, linux-kernel@vger.kernel.org,
        andrey@lebedev.lt, stable@vger.kernel.org
Subject: Re: [PATCH 3/3] pwm-sun4i: calculate the delay without rounding down
 to jiffies
Message-ID: <20220224165135.g4ufknd3alrhnfx3@pengutronix.de>
References: <20220125123429.3490883-1-max.kellermann@gmail.com>
 <20220125123429.3490883-3-max.kellermann@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="atuwjzjdwhpcw6tz"
Content-Disposition: inline
In-Reply-To: <20220125123429.3490883-3-max.kellermann@gmail.com>
Precedence: bulk


--atuwjzjdwhpcw6tz
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 25, 2022 at 01:34:29PM +0100, Max Kellermann wrote:
> This fixes a problem that was supposed to be addressed by commit
> 6eefb79d6f5bc ("pwm: sun4i: Remove erroneous else branch") - backlight
> could not be switched off on some Allwinner A20.  The commit was
> correct, but was not a reliable fix for the problem, which was timing
> related.
>=20
> The real problem for the backlight switching problem was that sleeping
> for a full period did not work, because delay_us is always zero.
>=20
> It is zero because the period (plus 1 microsecond) is rounded down to
> the next "jiffies", but the period is less than one jiffy.
>=20
> On my Cubieboard 2, the period is 5ms, and 1 jiffy (at the default
> HZ=3D100) is 10ms, so nsecs_to_jiffies(10ms+1us)=3D0.
>=20
> The roundtrip from nanoseconds to jiffies and back to microseconds is
> an unnecessary loss of precision; always rounding down (via
> nsecs_to_jiffies()) then causes the breakage.
>=20
> This patch eliminates this roundtrip, and directly converts from
> nanoseconds to microseconds (for usleep_range()), using
> DIV_ROUND_UP_ULL() to force rounding up.  This way, the sleep time is
> never zero, and after the sleep, we are guaranteed to be in a
> different period, and the device is ready for another control command
> for sure.
>=20
> Cc: stable@vger.kernel.org
> Signed-off-by: Max Kellermann <max.kellermann@gmail.com>

Sounds reasonable

Acked-by; Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--atuwjzjdwhpcw6tz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmIXt5QACgkQwfwUeK3K
7AlTYQf/Zh0Q3FPH4eN/o35hSGvD3UMufQdEEMHbALd3VzC3I0d3qIgjtDGaBbAc
VHSApGsvBRN3A+6XGdXvxKZJmMUhLRc3bUn7hyebAC13yFGhKFC173N93mB4mXPs
qZMocTGu1krh2PjXfnaG3UYWcwn3VBpu0pJMFD31tN4kXDLuhXC7YbvrvxWzM79s
ympXnjrvj4iExe5qgFi07DHdrbSGmNGFBYJDURCSqL91RAmHoUoJsnl8V7QXOzhT
D+tz31UhxdLS/XGNXZS6tqRQdQ0cIK1umArQnWczGyeFMo4u38c8nOPuCmYpgq2n
o0TsKdj1F+k3QQoxjdmciVpK/Wrnfw==
=W2ae
-----END PGP SIGNATURE-----

--atuwjzjdwhpcw6tz--