Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   "Moore, Robert" <robert.moore@intel.com>
To:     Paul Menzel <pmenzel@molgen.mpg.de>,
        "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
        Len Brown <lenb@kernel.org>
CC:     "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "devel@acpica.org" <devel@acpica.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/4] acpi: exsystem: Warn about sleeps greater than 50 ms
Thread-Topic: [PATCH 3/4] acpi: exsystem: Warn about sleeps greater than 50 ms
Thread-Index: AQHYKXMVEnTJK3a8GECkhoN2wlnjd6yi4XkA
Date:   Thu, 24 Feb 2022 16:19:52 +0000
Message-ID: <BYAPR11MB32563DC0413B8595D1339B37873D9@BYAPR11MB3256.namprd11.prod.outlook.com>
References: <20220224113807.91771-1-pmenzel@molgen.mpg.de>
 <20220224113807.91771-3-pmenzel@molgen.mpg.de>
In-Reply-To: <20220224113807.91771-3-pmenzel@molgen.mpg.de>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CB95+ETv7+diOXFWLSnj/enLGAdoBHQAKd5p3Mt8f0rCvvPbcpGykERtohNh?=
 =?us-ascii?Q?5zFVflGojk9vcfllNhwTmj+8ocQA1ll5KhvNUD96nnA6sIkeK9QWeJqki+B/?=
 =?us-ascii?Q?bzym1wYlxAViZn7N9IzslH0pKf2ekPhkuqoZ/ocJpRv5FVtdEeRnpG7RG0Qw?=
 =?us-ascii?Q?L3K8cqT9x+q71HkrNca2hRDPZUElX9s9d3jmswtKhB8gUqdX1sApPb8W2wji?=
 =?us-ascii?Q?hfFaST1VCyaM+7Cjq4UVgzHEMwepnGzc/7dXut7TuKdY7wfOu6fxCJeaGLzs?=
 =?us-ascii?Q?0Vu6gXmFg9YA4BICyqshjh6x7DY3vbTZGYv8gfLxiIq+slsqUPoG8ws6rZE8?=
 =?us-ascii?Q?OBGnO5S8lkXuJjayb8sw2/4mQvEaeCCn7PXK9tzCuR9I9OM45HYIH+2JLtYi?=
 =?us-ascii?Q?oqOIjUPKf1R/Hf9LH/MrE/Y517F7GCvwZA5LZ5MlLx/+byi45FlC7u6uSsOi?=
 =?us-ascii?Q?hltqbmh8/oL2zh4PcjyNa2U4TQuO5/Z09LNfpCRypE2Su3E/Oy7YW2zfGgKE?=
 =?us-ascii?Q?8HOTJ7yz5mbYb2MJu1fo8RdA4FZ+X2EQEkpwvkJWLlPdgUx9S29wO1I/5/au?=
 =?us-ascii?Q?UO/Zbt2yMj27lJ5LByae+Am1cPLIp1MGZmxQXtrmox/UznMNC64Hdyu1kxQR?=
 =?us-ascii?Q?ecnUcLIj4lcqwpD4wn1xtUEXaxYXsQrYQB8ZE0xPq4sx014PGhOoCXTJaDom?=
 =?us-ascii?Q?UhgHUJArcStidIpxsLAdGVnBIHdNaN3Lk+3wvCYMItxzx0TmR82YDkjG9n2S?=
 =?us-ascii?Q?Ff2wsdHK7IQ10mTwKCqLNXQxLtUUgYSdmmzX9uCatIN9c9COhutms49bFDoM?=
 =?us-ascii?Q?1ECrPybngqRC+ygI7HTLX1p8lDtyBsEWitEAwewtujWZpJzrB3M2De7NXWcM?=
 =?us-ascii?Q?uYvWwcguFY7PTSQwlVsZ53e6/lBXIQZCptDSaAkJckGZRP0J/WpwmXctRMu2?=
 =?us-ascii?Q?TdBRv/FFPuB207lyIxgMf00ZubFNpxNTeUVM6dAZxpMyR7lbiAEDOVqe1DfI?=
 =?us-ascii?Q?Jo89eq5n0VMm731OzyYK/Ao9FBA5+B7s+/sYOuemRrbCBRHPKlOAw5gVVF9y?=
 =?us-ascii?Q?bAqsrzjWfdP92AhI8FkzRwIP8PJTvvMmiTh2q111Q4TA6gyS/0dhLNclMCIX?=
 =?us-ascii?Q?HIum3PJpoWmULoBaszU1+BH2fJM/IaUfSnhhsbPjpcf/IJpyA5qfUar4K8Ok?=
 =?us-ascii?Q?CjsPr73/vB2EgJxNN96bT+w4RW3+ixbIs3voFCpFVv8LIGqEA+V3B1J2Z1pc?=
 =?us-ascii?Q?8C/0LEAfLD4QEcDmRwhrkxP/GzHqdZRKWO8t8t76RCsbaFehpLXRcH6hlxJF?=
 =?us-ascii?Q?Q6AfykCvuCWq1pXiX2PnXHLo+dGunaEXG3S1sc5Xr0WqUrWRZioEUwrBlbHt?=
 =?us-ascii?Q?g1zvjIydN4EugqO66lvzX6iU3aJ/5bB11xhBMAIBhi4+H1gK99wDnDllGpV5?=
 =?us-ascii?Q?8LO8Jg4FeJJ5Vb52sdgkBqVZRySmULp/aXNwQsKuu2qL9VVcQeaUrmyykHoT?=
 =?us-ascii?Q?/8NDxJcOaclMvV6KeZtOvDk1BM8sE7fNwdqSfNDrnwAdMSu94RSUPtTSWQJM?=
 =?us-ascii?Q?aF+ToRH1H8DpKfBkjaw7XgG2XvK5lwlpZrubFHNkqE8XCwFNdIrHbX9ArdXc?=
 =?us-ascii?Q?/K1dS+vW10pFc7NekpV8voI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3256.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2edbc282-99e1-44b1-26b2-08d9f7b17d1b
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 16:19:52.9214
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: z+uvRVFlIveMFmXbSDOzhclt+BXdpLcMfeIFiJLr3SG/8sIuJXCCW4aFTSzgPlxwWmsa0YUSMP62Gu/f3T/Phw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3549
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

So, this is the current implementation:

    /*
     * For compatibility with other ACPI implementations and to prevent
     * accidental deep sleeps, limit the sleep time to something reasonable=
.
     */
    if (HowLong > ACPI_MAX_SLEEP)
    {
        HowLong =3D ACPI_MAX_SLEEP;
    }

    AcpiOsSleep (HowLong);

Where ACPI_MAX_SLEEP is:=20

#define ACPI_MAX_SLEEP                  2000    /* 2000 millisec =3D=3D two=
 seconds */

-----Original Message-----
From: Paul Menzel <pmenzel@molgen.mpg.de>=20
Sent: Thursday, February 24, 2022 3:38 AM
To: Moore, Robert <robert.moore@intel.com>; Wysocki, Rafael J <rafael.j.wys=
ocki@intel.com>; Len Brown <lenb@kernel.org>
Cc: Paul Menzel <pmenzel@molgen.mpg.de>; linux-acpi@vger.kernel.org; devel@=
acpica.org; linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] acpi: exsystem: Warn about sleeps greater than 50 ms

Quick boottime is important, so warn about sleeps greater than 50 ms in ACP=
I.

50 ms is still long compared to distribution Linux kernels reaching initrd =
in 350 ms, so should probably changed to 10 ms, so people are aware about t=
his.

Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
 drivers/acpi/acpica/exsystem.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/acpi/acpica/exsystem.c b/drivers/acpi/acpica/exsystem.=
c index 00f66af31ffa..bdffb8aac05c 100644
--- a/drivers/acpi/acpica/exsystem.c
+++ b/drivers/acpi/acpica/exsystem.c
@@ -167,6 +167,11 @@ acpi_status acpi_ex_system_do_sleep(u64 how_long_ms)
=20
 	acpi_ex_exit_interpreter();
=20
+	if (how_long_ms > 50) {
+		ACPI_WARNING((AE_INFO,
+		    "Time parameter %llu > 50 ms. Please contact firmware vendor for mor=
e responsive system.", how_long_ms));
+	}
+
 	/*
 	 * For compatibility with other ACPI implementations and to prevent
 	 * accidental deep sleeps, limit the sleep time to something reasonable.
--
2.35.1