Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp1766389pxm; Thu, 24 Feb 2022 08:59:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJyMRHobh/3joDef2Q+xejfJeR4jJJpRHkZZeN6U+eUeTH3j1uXjpePflmynOwXOR5w+M26w X-Received: by 2002:a17:902:a982:b0:14f:f55:a09a with SMTP id bh2-20020a170902a98200b0014f0f55a09amr3343508plb.33.1645721985200; Thu, 24 Feb 2022 08:59:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645721985; cv=none; d=google.com; s=arc-20160816; b=0SYZYpSnryOkaW5YZl4QlfBZdj2Pdc3eapBz0gT1NxSXNujeWIVJrZ31cWQNAl4qgk ufWuSO/8DLcd9eQI2Dwc7D1meiKWoihHES6TLrkiiLUvt+nCP2JUX5BoPYFp8rkwnDo2 yrsXBC5YLvqA5eNtuGq11mLcTkhpoflE+zdEK498m4ZKK4bQc/W4l+A7D+v+OuDvxg1b yqiEJmBITSYmm4T8eeHlwZ7OufEmN204n/5mCAiIUEXOAvguNav095IFRLHbXAoTbqu0 yyjzwvzHSS5GR+HKFvzqh727LfDSQuSnouuMj735t3H+unoLPJgj4vhA5AR+gwMjHFv7 d42g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=fpEHycCTBLAKJy2JpCs8x6CHXFGn0+CMrP699lGhcZ4=; b=xkRHpWPwdeKDRBH6d7u/29UXQxvQQPZc64b2W35D2DHCmW0NqVu4kLSoO2HQQ/JZZ4 mWlXQ27qTnhOTD6JAsWTsSSBI74DvJe627JXD4yqA3aKs+L9ZfdJq4BdsrxZo6nJ4AEI lCpSpW0Vjf3qtbzm0r4fi+lUGypf1KIty2BIN6v1ksuUzJeewA5uI8Nax1R3RgkcQU9O 8DEdQTFnU7hu8ka5+DU5vZoDbU35ySkh7dLqlno9by2OsS+lt/oDjvlv50gEoajrUwY8 PkoA5ST2tPbwHh/2YhnB9gI6bjBWs3IHqRDwuA4pHmgbUci/bsxi23qkfhw/u+9ZOi0v df0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KlYyN74P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g19si3191710pgi.171.2022.02.24.08.59.28; Thu, 24 Feb 2022 08:59:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KlYyN74P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230074AbiBXQ6a (ORCPT + 99 others); Thu, 24 Feb 2022 11:58:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229971AbiBXQ63 (ORCPT ); Thu, 24 Feb 2022 11:58:29 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA347433B1; Thu, 24 Feb 2022 08:57:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5FFAB619E2; Thu, 24 Feb 2022 16:57:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89985C340FF; Thu, 24 Feb 2022 16:57:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645721875; bh=VsHRTV7aICRI+ROp0zh53/L5aAom3s0dMx0t31Au44Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KlYyN74PS4i7EISHuML/k0Zk+ppdJ3eAsKx8rwkPNlscoqLFOgYtFAS3uiBVifmPu 1B07YVArtVJ+TjDxrqesKE68KHah4PIXSQTQF0V1DBSC4y7mJyujoLxW5DFzz2BhxU wFDQozxSCgnTi4da+vcOUxd4h+ufRHSX4QM+2NYaAK5smNPVeCDxnwuEA8HjqEGzde OaHXTZdDnoYSdN6EP9SYh+MQg2NNdVJ/LQTVFzNNVRqlLWm+IhtP6uADttsc1bDw9h zARSISmgmsFwtm8mgR2KYvIhIx9yWZlp+9ge7qR6zrgHX5gJVomAhe2XCA2X2s58YR cwh5pu8aLmI2g== Date: Thu, 24 Feb 2022 08:57:54 -0800 From: Jakub Kicinski To: Mauri Sandberg , Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Hesselbarth , "David S. Miller" Subject: Re: [PATCH v2] net: mv643xx_eth: process retval from of_get_mac_address Message-ID: <20220224085754.703860a4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20220223142337.41757-1-maukka@ext.kapsi.fi> References: <20220221062441.2685-1-maukka@ext.kapsi.fi> <20220223142337.41757-1-maukka@ext.kapsi.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Feb 2022 16:23:37 +0200 Mauri Sandberg wrote: > Obtaining a MAC address may be deferred in cases when the MAC is stored > in an NVMEM block, for example, and it may not be ready upon the first > retrieval attempt and return EPROBE_DEFER. > > It is also possible that a port that does not rely on NVMEM has been > already created when getting the defer request. Thus, also the resources > allocated previously must be freed when doing a roll-back. > > Signed-off-by: Mauri Sandberg > Cc: Andrew Lunn While we wait for Andrew's ack, is this the correct fixes tag? Fixes: 76723bca2802 ("net: mv643xx_eth: add DT parsing support")