Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <944bdedc-afbb-e427-bd1d-676f8ed21a48@ideasonboard.com>
Date:   Thu, 24 Feb 2022 18:07:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v5.1 2/2] ARM: dts: bcm2711: Add unicam CSI nodes
Content-Language: en-US
To:     Stefan Wahren <stefan.wahren@i2se.com>,
        linux-kernel@vger.kernel.org
Cc:     linux-arm-kernel@lists.infradead.org,
        linux-rpi-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com, sbranden@broadcom.com,
        rjui@broadcom.com, f.fainelli@gmail.com, nsaenz@kernel.org,
        robh+dt@kernel.org, laurent.pinchart@ideasonboard.com,
        dave.stevenson@raspberrypi.com, naush@raspberrypi.com
References: <20220208155027.891055-7-jeanmichel.hautbois@ideasonboard.com>
 <20220223143434.71853-1-jeanmichel.hautbois@ideasonboard.com>
 <20220223143434.71853-2-jeanmichel.hautbois@ideasonboard.com>
 <3fceae58-b43e-0034-19c2-078f18010001@i2se.com>
From:   Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
In-Reply-To: <3fceae58-b43e-0034-19c2-078f18010001@i2se.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Stefan,

On 24/02/2022 18:03, Stefan Wahren wrote:
> Hi Jean-Michel,
> 
> the version v5.1 is a little bit confusing, because it looks like to be
> applied to stable linux-5.1, which is not intended.

Sorry for the confusion, I don't want to send a full v6 now, as it will 
need to be rebased on top of the multiplexed streams series in its v11 
which is not yet posted on the ML :-).

> 
> Am 23.02.22 um 15:34 schrieb Jean-Michel Hautbois:
>> Add both MIPI CSI-2 nodes in the core bcm2711 tree. Use the 3-cells
>> interrupt declaration, corresponding clocks and default as disabled.
>>
>> Thanks to Stefan Wahren for his guidance on how to deal with different
>> RPi variants.
> 
> Can you please explain why you split these patches from the original series?

Because the firmware clocks are independent from the csi nodes and so, 
it sounded logical to split it in half ?

> 
> I didn't had the time to test, but applying these patches would
> "disable" bcm2835-camera driver?

Wasn't it already the case ? It is intended, we don't want those to be 
"okay" by default ? Or do I miss your point maybe (probably :-)) ?

Thanks,
JM

> 
> Best regards
> Stefan
> 
>