Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp1820675pxm; Thu, 24 Feb 2022 09:57:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJy6J+p5Xe2jOHmQp91VXMQfehkw4kScFm3nVplWl9nvO5+x3fZ/m5ifBhGpd9pXuM4XUSLT X-Received: by 2002:a17:902:7e87:b0:14f:cd2e:6db6 with SMTP id z7-20020a1709027e8700b0014fcd2e6db6mr3885310pla.163.1645725456662; Thu, 24 Feb 2022 09:57:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645725456; cv=none; d=google.com; s=arc-20160816; b=TM2MONsG0C14ktFtcrJn76hkwYu8yNO26jIBecUZ6eyw83HAdzrUhhyGVjLWGpknjG lsk9GK4Dpp0qnd3utb/Wldtt1hxJltPwPuYp6RHSZRaQGwdLg6Y28fZEsogFKUTWsERV 0FOSthn7fJZS6f7jyzKpwpwDbOglsjOZG2e1MSWXsOd30T3bq6/okfWwkWDYeiw9Jl6D qhcnPwoRo15yBSijQk49TR9EtxycfTpfZh8EnJjMhAcs0s9FVDQWTaGhIQfplv/w3jxE CZ5YW8+kqeqDmbgoFF1cSK7kpxt3ErD4zCBpD1FDfI34Thb7+bCueC2gZ/56QxPMR/vQ GnfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fp0EGUnqc8RMl+9AA8JB9DRwPTVJiBPYZtxhUdnF7mQ=; b=qWDD8qYTOdsGNzhsXO2r8AmM4yiqp55qodQfo8EC+NpAU/u88frPmllcNnlIpHGH9j UJl+LKcn3HN+8Nb/FOxyX6USBvEIEys7sKhn/tJaYzuQoO1i+U7nTfbEQoqtgROSFkQ7 2zRgEWtckM+AXoBVnOVXhO01OZw9dPMKzk3TObvc72BS9Um5Wqw997uV7f1Qsj9WRivJ wBAoLP5oMHVu3IX2nMCVfAStmA9y/Yv18mATk0EC+pGnMLL7a732jwHzJ/5PuRnsyenM iTFmKcFdgpAhVJ1DvUfKPjnCEsnvdJ9gbiKXeMjJZ6xXi4vkOGUTvRznn0uLvhkVihXc +5vA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=U20jT4e+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 30si2870771pgw.552.2022.02.24.09.57.19; Thu, 24 Feb 2022 09:57:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=U20jT4e+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232211AbiBXRn4 (ORCPT + 99 others); Thu, 24 Feb 2022 12:43:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbiBXRny (ORCPT ); Thu, 24 Feb 2022 12:43:54 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4D7B252937; Thu, 24 Feb 2022 09:43:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=fp0EGUnqc8RMl+9AA8JB9DRwPTVJiBPYZtxhUdnF7mQ=; b=U20jT4e+wXtZmN24NmNeTGFFil BLvHQW3oGNWN0NQICvpNylRljw3bUfZMzqy93sajFW4Bj1fkN1hTS9SbTBQ4weRn+7XD3swmJv5Lr xetkyXjd7RQekaWaCtviYqiye+sCCdkw5caW3RWaYxhFXvUq/58BZmFJ2ZDzDMoBy+1Y=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nNI94-007zwg-BT; Thu, 24 Feb 2022 18:43:14 +0100 Date: Thu, 24 Feb 2022 18:43:14 +0100 From: Andrew Lunn To: Jakub Kicinski Cc: Mauri Sandberg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Hesselbarth , "David S. Miller" Subject: Re: [PATCH v2] net: mv643xx_eth: process retval from of_get_mac_address Message-ID: References: <20220221062441.2685-1-maukka@ext.kapsi.fi> <20220223142337.41757-1-maukka@ext.kapsi.fi> <20220224085754.703860a4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220224085754.703860a4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 24, 2022 at 08:57:54AM -0800, Jakub Kicinski wrote: > On Wed, 23 Feb 2022 16:23:37 +0200 Mauri Sandberg wrote: > > Obtaining a MAC address may be deferred in cases when the MAC is stored > > in an NVMEM block, for example, and it may not be ready upon the first > > retrieval attempt and return EPROBE_DEFER. > > > > It is also possible that a port that does not rely on NVMEM has been > > already created when getting the defer request. Thus, also the resources > > allocated previously must be freed when doing a roll-back. > > > > Signed-off-by: Mauri Sandberg > > Cc: Andrew Lunn > > While we wait for Andrew's ack, is this the correct fixes tag? > > Fixes: 76723bca2802 ("net: mv643xx_eth: add DT parsing support") Yes, that looks correct. The history around here is convoluted, and anybody trying to backport that far is going to need a few different versions. Reviewed-by: Andrew Lunn Andrew