Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Feb 2022 17:26:54 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc:     Daniel Baluta <daniel.baluta@nxp.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Keyon Jie <yang.jie@linux.intel.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Rander Wang <rander.wang@intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Takashi Iwai <tiwai@suse.com>, stable@vger.kernel.org,
        sound-open-firmware@alsa-project.org, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: SOF: Intel: Fix NULL ptr dereference when ENOMEM
Message-ID: <Yhe/3rELNfFOdU4L@sirena.org.uk>
References: <20220224145124.15985-1-ammarfaizi2@gnuweeb.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="P1GVxpuNWL6fQTf7"
Content-Disposition: inline
In-Reply-To: <20220224145124.15985-1-ammarfaizi2@gnuweeb.org>
Precedence: bulk


--P1GVxpuNWL6fQTf7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 24, 2022 at 09:51:24PM +0700, Ammar Faizi wrote:
> From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
>=20
> Do not call snd_dma_free_pages() when snd_dma_alloc_pages() returns
> -ENOMEM because it leads to a NULL pointer dereference bug.
>=20
> The dmesg says:
>=20
>   <6>[109482.497835][T138537] usb 1-2: Manufacturer: SIGMACHIP
>   <6>[109482.502506][T138537] input: SIGMACHIP USB Keyboard as /devices/p=
ci0000:00/0000:00:14.0/usb1/1-2/1-2:1.0/0003:1C4F:0002.000D/input/input34
>   <6>[109482.558976][T138537] hid-generic 0003:1C4F:0002.000D: input,hidr=
aw1: USB HID v1.10 Keyboard [SIGMACHIP USB Keyboard] on usb-0000:00:14.0-2/=
input0
>   <6>[109482.561653][T138537] input: SIGMACHIP USB Keyboard Consumer Cont=
rol as /devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.1/0003:1C4F:0002.000=
E/input/input35

Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative (it often is
for search engines if nothing else) then it's usually better to pull out
the relevant sections.

--P1GVxpuNWL6fQTf7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIXv90ACgkQJNaLcl1U
h9DGNggAglmdN2ru7N2IfI7rxiJiO0A5rEtjeaQiUAWknIbQnz1voUjRkigNNdGY
6zRoxcOr1bqgbD5x5fLFhmsYfXpGjrCWXMTEZS+0gZdnwdhDPMbmUrzA2N2/K3Bv
+pfDNojNUKogEyIYcOv0us5bTxHFSm1OWFfFVyxhWHZz+L6MPQ2BfQiRGeh9fA4X
b2JhqifhWnbijUOAizyCtfhiaVk2O4ZOyoldhtkDiRdx6eM49ADyaEv+Kq2rnCkZ
MqOt4Oz4EKAdmCoAIv2m8/Vb8V2p9J2J91N8SVG/GUxM7zZ03kp2vbbLXyWNfb1u
foJsHidMgWYzQAWqIFvYLuIb7xZ0Qg==
=oFvq
-----END PGP SIGNATURE-----

--P1GVxpuNWL6fQTf7--