Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Feb 2022 17:50:42 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     Wanpeng Li <kernellwp@gmail.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        Maxim Levitsky <mlevitsk@redhat.com>,
        Lai Jiangshan <laijs@linux.alibaba.com>
Subject: Re: [PATCH 0/3] KVM: x86: Fixes for kvm/queue
Message-ID: <YhfFcqeVzUoFlntf@google.com>
References: <20211216021938.11752-1-jiangshanlai@gmail.com>
 <7fc9348d-5bee-b5b6-4457-6bde1e749422@redhat.com>
 <CANRm+CyHfgOyxyk7KPzYR714dQaakPrVbwSf_cyvBMo+vQcmAw@mail.gmail.com>
 <YgaPZcET90k14fBa@google.com>
 <f9b5c079-ba10-b528-a2fc-efb40cbb5d8f@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f9b5c079-ba10-b528-a2fc-efb40cbb5d8f@redhat.com>
Precedence: bulk

On Fri, Feb 11, 2022, Paolo Bonzini wrote:
> On 2/11/22 17:31, Sean Christopherson wrote:
> > > Maybe the patch "Revert "KVM: VMX: Save HOST_CR3 in
> > > vmx_prepare_switch_to_guest()"" is still missing in the latest
> > > kvm/queue, I saw the same warning.
> > 
> > It hasn't made it way to Linus either.
> 
> This was supposed to fix the buggy patch, too:
> 
>     commit a9f2705ec84449e3b8d70c804766f8e97e23080d
>     Author: Lai Jiangshan <laijs@linux.alibaba.com>
>     Date:   Thu Dec 16 10:19:36 2021 +0800
> 
>     KVM: VMX: Save HOST_CR3 in vmx_set_host_fs_gs()
>     The host CR3 in the vcpu thread can only be changed when scheduling,
>     so commit 15ad9762d69f ("KVM: VMX: Save HOST_CR3 in vmx_prepare_switch_to_guest()")
>     changed vmx.c to only save it in vmx_prepare_switch_to_guest().
>     However, it also has to be synced in vmx_sync_vmcs_host_state() when switching VMCS.
>     vmx_set_host_fs_gs() is called in both places, so rename it to
>     vmx_set_vmcs_host_state() and make it update HOST_CR3.
>     Fixes: 15ad9762d69f ("KVM: VMX: Save HOST_CR3 in vmx_prepare_switch_to_guest()")
>     Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
>     Message-Id: <20211216021938.11752-2-jiangshanlai@gmail.com>
>     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

The underlying premise that CR3 can change only when scheduling is wrong, reverts
incoming...