Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Feb 2022 18:22:12 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Krishna Yarlagadda <kyarlagadda@nvidia.com>
Cc:     "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        Sowjanya Komatineni <skomatineni@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>
Subject: Re: [PATCH v2 4/5] spi: tegra210-quad: add acpi support
Message-ID: <YhfM1DO8vmvHah+f@sirena.org.uk>
References: <20220222175611.58051-1-kyarlagadda@nvidia.com>
 <20220222175611.58051-5-kyarlagadda@nvidia.com>
 <YhUtQ/8Kgcx4OY4S@sirena.org.uk>
 <DM4PR12MB57693F28A727964ED67BBEB4C33C9@DM4PR12MB5769.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="NN31DYzJ28edf/nu"
Content-Disposition: inline
In-Reply-To: <DM4PR12MB57693F28A727964ED67BBEB4C33C9@DM4PR12MB5769.namprd12.prod.outlook.com>
Precedence: bulk


--NN31DYzJ28edf/nu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 23, 2022 at 06:32:56AM +0000, Krishna Yarlagadda wrote:

> > > +	if (has_acpi_companion(tqspi->dev))
> > > +		return 0;
> > >  	/* flush all write which are in PPSB queue by reading back */
> > >  	tegra_qspi_readl(tqspi, QSPI_COMMAND1);

> > As well as clock stuff this is also skipping flushing of pending writes
> > - is that intentional?  It's not called out in the changelog and seems like
> > something that could cause issues if someone runs on a system where
> > the firmware does implement runtime suspend.

> Runtime suspend is not enabled with ACPI firmware. Converted compiler flag in v1 to runtime check.
> We must add more changes like setting DPM flags for runtime pm support with ACPI.
> Can take this as part of a different series.

It at least needs to be clearer what's going on here, the changelog
doesn't match the code and it's not obvious from the code that ACPI
won't kick in and power manage the device as things stand.

--NN31DYzJ28edf/nu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIXzNMACgkQJNaLcl1U
h9DJyAf9Hrv8ZOPOazKwh+GeTMwE1UXZSJtI+PhEMyvmN762w6PZV/oFVg3ZBx9E
rTMUjp7KwLQ810g+62lvBwu3Qqqhq3q50DXXLLtMStFHB1m+S9KaNlnWSAQyXjF2
A9388F0TTvnpOOzHufONVxNKqUCl3my8vvAFNYL24IHD/7af4ZGJGwMvTC7o6LtI
4Cjfm8BgQAaDcxBW2928tC1/NIZ5Qsep35p12FFL1dtHzlr30+Nlr44L8PZqIPDv
0Fv9hAi5Lg2LaA6bTZPmBh+cLIdL8BEOiw1gxFprahc+EKqkxIUN1KC+ZQDnMQhD
/G9CuHYJgIah4Oa9LBiDsQIDJc/xYA==
=Nx2b
-----END PGP SIGNATURE-----

--NN31DYzJ28edf/nu--