Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Feb 2022 18:18:45 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
        rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com,
        william.roche@oracle.com
Subject: Re: [PATCH v4 1/2] EDAC/amd64: Set memory type per DIMM
Message-ID: <YhfMBbsex8+cTnSE@yaz-ubuntu>
References: <20220202144307.2678405-1-yazen.ghannam@amd.com>
 <20220202144307.2678405-2-yazen.ghannam@amd.com>
 <YhafLB7Jw1Bul7YP@zn.tnic>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YhafLB7Jw1Bul7YP@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?d6KqmRRCHFvavoep1LX+FSEopke89BV8BnNjWyEziIMumC/q624ySKHe1Z9D?=
 =?us-ascii?Q?DPVi87Is8CRmf+XRjloyHhkDyMf0vseP5aJTzG0ZHXGy4ooO0VQWdnIQnHAh?=
 =?us-ascii?Q?zXpuqUcEDJpVNQ3BTQEZ5yF9kMAtIIGv+VOzPYwN7SBivvN8cUB1jX+8sStl?=
 =?us-ascii?Q?qbhLTbz8cmY3PFe23JBf3h+Oxa90h1zi2xEwQyrU2rD2KvobiJvbxqcXczCS?=
 =?us-ascii?Q?3iImzbug0sBobXGlPQPnXYriIrYKMJNLl912fFiHY1QXxuvpW/oF9ZjJpgQT?=
 =?us-ascii?Q?w6iD0iDo1hCGZBlgXkVyxNab+09zmI3YXCtlhnaCcdmaf7fTwOkhtOtNuaJT?=
 =?us-ascii?Q?U/msK1ZVG+8vuIMWKsXFOqgRsHNxKb9coDRTbW2fuxuVg26gjzir38OeIYZV?=
 =?us-ascii?Q?qlpTRRkYLo7fqwfUJ5wkHQPAKqWfKvLarBgpWKM/VaLZHbdqVQyXz7OJXyS3?=
 =?us-ascii?Q?x5PVtLQWDK+mArqBvCKOE8dfJ2RkBcms02JrpbVA86FD5HpgfRmEwXhO/l4p?=
 =?us-ascii?Q?h1omPl+A58a8KV0VMmbu309zr5oXAq8zBl32qCdghZY2SoByQMYlka7jvO0I?=
 =?us-ascii?Q?pkGInL/zj//0VRh0d5GsvMyI5+sMK4xstfsIldHhes0hNAaJGtrJDWQfzAgX?=
 =?us-ascii?Q?aE6FvqMEnsDnXtgVK1Kp1rQxFZ859DphePdWk+Ho5LBhx759quUdWi6imppL?=
 =?us-ascii?Q?2Zg1mkweD3b5EH0nghntGUCVcE5pdwbk3lO3GZkX1rWNt5eU2YRQQ/7CMtYi?=
 =?us-ascii?Q?sdZ6I8e4zaiyFAoiRd+4j5wlx/AGKjlRDYwNLsOXoKzxajxU2esZDYOJVDO/?=
 =?us-ascii?Q?z5N2kFFnABVVarzMRME0X7QhpnPyNJbS1+PRu64Qyo07gWFWisqtoGe9C51M?=
 =?us-ascii?Q?s/2yYLzlFe2BIKE0OzFVN9JMAtc+eL5s+bHus3vsSLTPO1/Uymb4TPDay4Po?=
 =?us-ascii?Q?wQ0Pgk2R1tgD59+uWFYcdFzXfZ6ReOULwb//vH6WZa2qV17oHCt/ZjF3CUgT?=
 =?us-ascii?Q?uRy12IQAIPVo11bIttmgAaCF0gD7681wqqewIlGgzhcVE+pbSkOGFKYK9C0n?=
 =?us-ascii?Q?y8jWYd7w6sb+d4a1Arb287C6gj21laC86y9XRlBq3J4vLaDaF0SaUnGEYuGh?=
 =?us-ascii?Q?HPdfMX4hHQDKyUkvvJfZ0yal3pMvgplc64iUOUqyragDk9jcFXuOuTzRdBUM?=
 =?us-ascii?Q?pL9KZabZuwc9ZzjUi0IN8U2Ll4cstS+O8quX2vnI42E2lwnsDf5/6FyiYR91?=
 =?us-ascii?Q?mRzLXrqDjBVG/EVfQ0jnXqH1rXAoR6AwhcoVOK6ogiFCOxToyAepyA7YS9hB?=
 =?us-ascii?Q?RN3NTb73dXdWAAO/ZMAPSRr5axaoSSIF1cEaAzZ6M0u6MIQwET/YylgS7r8e?=
 =?us-ascii?Q?uC5c9Xl6iL5Fsjaru9LsHy2uC1vfMnGNv9qOve1UKrn07LWHCeHqVNtzQlvn?=
 =?us-ascii?Q?ICJvaYtq/E5+kfOwi49M5O99FK19MmDFz9MOyxppZWadZNVbbUQPumsehvsl?=
 =?us-ascii?Q?3bA7uCsJq6vbkvo/b+Hjwg1UKmH8RRRBVu20Tv02dgHzDmqV4i0QKLpboeE0?=
 =?us-ascii?Q?fUjlWepe5ALjjAiRDHjgezwBSAHQ13Wuh0m6W8nnLIUTyrNBrZopiKFg8kdE?=
 =?us-ascii?Q?F+qhmc8FAEMwYXBEa8F6Zxs=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc9be765-fc23-4b46-7881-08d9f7c21aa8
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 18:18:49.6818
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jelfqO3K/Qdf5lgq8gVr3M5z53UTQ/TabGbuVEFqhPiORfqkyMTs2p/p2JyV8jpLfz6R5f0NnuJUuZsLQ6ZiTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1463
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 23, 2022 at 09:55:08PM +0100, Borislav Petkov wrote:
> On Wed, Feb 02, 2022 at 02:43:06PM +0000, Yazen Ghannam wrote:
> > +static void _determine_memory_type_df(struct amd64_umc *umc)
> 
> You don't need this function, right?
> 
> IOW, here's what I've applied:
> 

...

>  
> -static void determine_memory_type(struct amd64_pvt *pvt)
> +static void determine_memory_type_df(struct amd64_pvt *pvt)
>  {
> -	u32 dram_ctrl, dcsm;
> +	struct amd64_umc *umc;
> +	u32 i;
>  
> -	if (pvt->umc) {
> -		if ((pvt->umc[0].dimm_cfg | pvt->umc[1].dimm_cfg) & BIT(5))
> -			pvt->dram_type = MEM_LRDDR4;
> -		else if ((pvt->umc[0].dimm_cfg | pvt->umc[1].dimm_cfg) & BIT(4))
> -			pvt->dram_type = MEM_RDDR4;
> +	for_each_umc(i) {
> +		umc = &pvt->umc[i];
> +
> +		if (!(umc->sdp_ctrl & UMC_SDP_INIT)) {
> +			umc->dram_type = MEM_EMPTY;
> +			continue;
> +		}
> +
> +		if (umc->dimm_cfg & BIT(5))
> +			umc->dram_type = MEM_LRDDR4;
> +		else if (umc->dimm_cfg & BIT(4))
> +			umc->dram_type = MEM_RDDR4;
>  		else
> -			pvt->dram_type = MEM_DDR4;
> -		return;
> +			umc->dram_type = MEM_DDR4;
> +
> +		edac_dbg(1, "  UMC%d DIMM type: %s\n", i, edac_mem_types[umc->dram_type]);
>  	}
> +}

Ah, I see. You got rid of the extra helper function. Makes sense and looks
okay to me.

Thanks,
Yazen