Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jonathan Corbet <corbet@lwn.net>
To:     Akira Yokosawa <akiyks@gmail.com>
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH 1/3] docs: pdfdocs: Pull LaTeX preamble part out of conf.py
In-Reply-To: <aaa9dca1-27c0-c414-77f3-c5587db0cc5b@gmail.com>
References: <aaa9dca1-27c0-c414-77f3-c5587db0cc5b@gmail.com>
Date:   Thu, 24 Feb 2022 12:33:25 -0700
Message-ID: <875yp4kqka.fsf@meer.lwn.net>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Akira Yokosawa <akiyks@gmail.com> writes:

> Quote from Jon's remark [1]:
>
>     I do notice that Documentation/conf.py is getting large and
>     unapproachable.  At some future point, it might be nice to pull
>     all of the latex stuff out into a separate file where it won't
>     scare people who stumble into it by accident.
>
> Pull LaTeX preamble settings added since commit 3b4c963243b1 ("docs:
> conf.py: adjust the LaTeX document output") out into
> sphinx/kerneldoc-preamble.sty.
>
> It will be copied to the build directory by the added
> "latex_additional_files" setting in conf.py.
>
> As a bonus, LaTeX/TeX code can be maintained without escaping backslashes.

I've applied the set, thanks.  Still testing the pdfdocs build (and will
be for some time, naturally)

One little note, since you mentioned the need for backslash escapes:

> +# Load kerneldoc specific LaTeX settings
> +latex_elements['preamble'] += '''
> +        % Load kerneldoc specific LaTeX settings
> +	\\input{kerneldoc-preamble.sty}
> +'''

You can avoid that problem in Python code with the use of raw strings:

latex_elements['preamble'] += r'''
       % Load kerneldoc specific LaTeX settings
       \input{kerneldoc-preamble.sty}
'''

(note the "r" on the first line).  Something for future reference.

Thanks,

jon