Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     Rob Herring <robh@kernel.org>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC:     "jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "krzysztof.kozlowski@canonical.com" 
        <krzysztof.kozlowski@canonical.com>,
        Daniel Baluta <daniel.baluta@nxp.com>
Subject: RE: [PATCH V4 2/5] dt-bindings: mailbox: imx-mu: add i.MX93 S4 MU
 support
Thread-Topic: [PATCH V4 2/5] dt-bindings: mailbox: imx-mu: add i.MX93 S4 MU
 support
Thread-Index: AQHYKF1MqNltMWS5SU+6uS/TNysqHKyjFyYAgABqXaA=
Date:   Fri, 25 Feb 2022 01:46:15 +0000
Message-ID: <DU0PR04MB9417BD76E66DAFE2D8E505F6883E9@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20220223023157.3478540-1-peng.fan@oss.nxp.com>
 <20220223023157.3478540-3-peng.fan@oss.nxp.com>
 <YhfbFi4Cl1TfWqX7@robh.at.kernel.org>
In-Reply-To: <YhfbFi4Cl1TfWqX7@robh.at.kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PG4DCpOzMPrl78EM54XWtVLn9Q1v4oKxj5kJ685mgPpTsGJ+9kO1GV6NK6KU?=
 =?us-ascii?Q?OcuehBfc558WVbks4EQJh50mlZYr4gxeueRmJAZeLFaYZwkCciIzNRhrfcB2?=
 =?us-ascii?Q?mQ2W4/EpaAJQ3gT0q8haw8vKndd7oJI5u3MDS+KVwEeW989GNtI8pgE0owKL?=
 =?us-ascii?Q?pukQEbBC+gYpEDC/KbsbVRkQavkqx/2pgOtqYCRcjpAH0gIV+cyD51TVPRdk?=
 =?us-ascii?Q?QAAOT7A/PT3n0DKUL/3OaHw0UTWhI2vK7XFpanDqNzQEAd58mA1MCzjwu6v8?=
 =?us-ascii?Q?WqiYkV39DOaY1UArqT2HwYwsg+3lQUyvxXxF02BGUlez6jOKYUBevKDAoqdO?=
 =?us-ascii?Q?ipKfAVCMQoLnpCbnnHVOiCpb4bNNt6y2KJrLFeVgcslhCZkIWJwx3gTSp9p7?=
 =?us-ascii?Q?JM2DNXyRfv9hL8EmzdzqJzPMSV30tgUwOMwDOQauKQzeL0AvP+he+bIgcUVo?=
 =?us-ascii?Q?gu5BswkeRnk6wY8gOzZNEwTee8xSZ9hIQPZZVifkgkq+437RQ9rbeHTIZHDr?=
 =?us-ascii?Q?WOYcYC1U+lcpKrjvz4byOCCyKzTxqm3WRUco7guiRKXvN8eC3lRVLUUHiclj?=
 =?us-ascii?Q?eCMgH2m8QCzPsQTmkxx+d7B1OfTbtFC0yswbQyHjpdbEafTJKSmM6INCOeBS?=
 =?us-ascii?Q?29EaVme/awTwTSvdXgHSdfnWfrMfPBt8LEootKQmrWLHatNSE2yInDwV6pca?=
 =?us-ascii?Q?YWoLC7QrY5AVBB6pCKS71l5Trlc6uWefn3C2bpOVvoU4y4ALr+t0LfFyQ4Db?=
 =?us-ascii?Q?KruIgnEMJfbNhGzEQcNjgNmyGgO/B0VpOqvxWVe7wiunjZfwkTG92p2EE7+C?=
 =?us-ascii?Q?UQ/eWuZvrb2Gqsocr3BUPawnMNY6P7ypL8fRn6lE0m94jCIBefoHE9Sqy4Ev?=
 =?us-ascii?Q?wb0ezj2/8+uwYQDQZRlgJP7cB4KCqLi8jVBoJo+94uWg4t5oAGIGg2tUwkej?=
 =?us-ascii?Q?7nBn1xHhn8U98tijG8Khu8OKoXdYLhnjXcvIZNxCJe0kAFJLk0pO4yGpCtDi?=
 =?us-ascii?Q?p+otpEssOcFWjA8gRbgJPYC7RAqeWHKxDNvpMsc0bkV5byRV/dZuW+H4c+/z?=
 =?us-ascii?Q?p/xc9/We6l49AL1WDmtxaMXipD8FXn3fa5mG+ni4qtKw6iIUUtZPK74YykVB?=
 =?us-ascii?Q?A+vn/fjybvJRPCxQ9abWI0yC6TwhneXladc69+mmiXMdBQ57LIV70JUg/hZv?=
 =?us-ascii?Q?UvzDVJromdtTIA0jzEXjOFjd905KNYKDencF+ziREgW8ZWh3r3NtWlqEC9AG?=
 =?us-ascii?Q?WyT2NXx8P+scfRu0+qNf9umBr7Z4j6HjP1V8hbYuTGl7rFYuCkmDOdPET1UX?=
 =?us-ascii?Q?sWq0TBsWkGI7LI9UNReEPrXvZY5DNAAcPPh0xyrCR4+VV6KxAOMxVs6AuBo6?=
 =?us-ascii?Q?jjmPDJ4qlZ+PlFblXY2YHL+gp0Yv9HHRX2romx818uXy1kw+EGUUnYSnqI0A?=
 =?us-ascii?Q?yOVeyLTyh/sLwSX73DVw7P3fiNrJUiv56//lS+IugDXybLoyOZKL4EscAAl2?=
 =?us-ascii?Q?1RbB9Am4At+oGFYkSreT2ILAO3PK13ffFG53hs7Nphg2rF1xNXN4SHrMMTXr?=
 =?us-ascii?Q?vgATTj6n8Si5YU19kuNrLzdcnhR2mj0Tcd0K/0TMS/7w6WKuSpa8iOaMP2Ao?=
 =?us-ascii?Q?NA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 991183bf-c37d-425f-ce04-08d9f8009c70
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2022 01:46:15.7025
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Cl40OiVNr6bCvVYjIM3QgLgPPRfCpmn1B4YCcUg/knBI2eocRvSuNY/dztL1mBbKTlNwBrrvk10Ro0tELQT9aA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5268
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH V4 2/5] dt-bindings: mailbox: imx-mu: add i.MX93 S4 M=
U
> support
>=20
> On Wed, Feb 23, 2022 at 10:31:54AM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Similar to i.MX8ULP S4 MU, i.MX93 MU is dedicated for communication
> > between Sentinel and Cortex-A cores from hardware design, it could not
> > be reused for other purpose.
> >
> > However i.MX93 S4 MU use separate tx/rx interrupt, so update
> > interrupts and add interrupt-names property.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  .../devicetree/bindings/mailbox/fsl,mu.yaml   | 27
> ++++++++++++++++++-
> >  1 file changed, 26 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > index 6d056d5e16bf..f5f9d501845d 100644
> > --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > @@ -29,6 +29,7 @@ properties:
> >        - const: fsl,imx8ulp-mu
> >        - const: fsl,imx8-mu-scu
> >        - const: fsl,imx8-mu-seco
> > +      - const: fsl,imx93-mu-s4
> >        - const: fsl,imx8ulp-mu-s4
> >        - items:
> >            - const: fsl,imx93-mu
> > @@ -55,7 +56,13 @@ properties:
> >      maxItems: 1
> >
> >    interrupts:
> > -    maxItems: 1
> > +    minItems: 1
>=20
> I still don't think you tested this with 2 items. You need minItems and
> maxItems.

dt_binding check and dtbs_check both pass two interrupts entry.

So here it should be?
interrupts:
 minItems: 1
 maxItems: 2=20

>=20
> > +
> > +  interrupt-names:
> > +    minItems: 1
> > +    items:
> > +      - const: tx
> > +      - const: rx
> >
> >    "#mbox-cells":
> >      description: |
> > @@ -90,6 +97,24 @@ required:
> >    - interrupts
> >    - "#mbox-cells"
> >
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          enum:
> > +            - fsl,imx93-mu-s4
> > +    then:
> > +      properties:
> > +        interrupt-names:
> > +          minItems: 2
> > +        interrupts:
> > +          maxItems: 2
>=20
> s/maxItems/minItems/

Fix  in V5.

Thanks,
Peng.

>=20
> > +
> > +    else:
> > +      properties:
> > +        interrupts:
> > +          maxItems: 1
> > +
> >  additionalProperties: false
> >
> >  examples:
> > --
> > 2.25.1
> >
> >