Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <39b74b28-d029-ad05-0f73-2db8c8eefe92@oracle.com>
Date:   Fri, 25 Feb 2022 16:43:48 +1100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: [PATCH v6 0/7] kernfs: Introduce hashed mutexes to replace global
 kernfs_open_file_mutex.
Content-Language: en-US
To:     Tejun Heo <tj@kernel.org>
Cc:     gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
References: <20220214120322.2402628-1-imran.f.khan@oracle.com>
 <YgqcSwrhToLXX5Cm@slm.duckdns.org>
From:   Imran Khan <imran.f.khan@oracle.com>
In-Reply-To: <YgqcSwrhToLXX5Cm@slm.duckdns.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzBGVktyU05TM1J4ODdCdFdGL3cxK1lNcllzeEsvbEVYRm5MSkdxRVd5OXlw?=
 =?utf-8?B?ZDcwelRSLzUxOC9NYTNCdlQzcjZ2bUQyOVcvaVdpQ3paL1VLaU9zKzhJdldt?=
 =?utf-8?B?SkEzMWJ4eFRvNTYwYWdLRlhwYWtpV2JScit6cUsvODN0S05WZldrbGdaaWhw?=
 =?utf-8?B?MW1vcXRUSzFkNXZSZmZYL1BXc1pDRFZYSXRlSlVlWUZudmJlQThRRzB3Z01U?=
 =?utf-8?B?QjNkTCtuTmllbndYSUFSc01OQitlNU90VlNDbzltbWJVUC9RK1lUUjgzQkR3?=
 =?utf-8?B?WjVUSFR4a1haUTJXblJzcG10RHF0ZU5iWDhqVFZLVjRsZng1VllMbzFnWXhN?=
 =?utf-8?B?ZytTTHd6QnRlMjBtS21QYjd3WklDQ0VHQUZJR3ZQbmVLbm15QTczNUMvZ0ZH?=
 =?utf-8?B?a0Q1V0ZOVnhRaXgvRkJEVi9sbjJGbWZralFkbEtVUm43S2w5MzZjWXVEUHB2?=
 =?utf-8?B?b2Q1RjI4UW9scTJ4RjQ5VnlmUHo0MXdyaEovZTBDczg2bGx3Zm5LM1BYRkVl?=
 =?utf-8?B?cmdZMkpTWkdpcVp1aWtmdCtQRHJuVFl3dXJ5REN5MmJ1K1ZNUElHM3Z3VTlp?=
 =?utf-8?B?YXNhaTdiWFBmVFpBUkxxaldzYzAvR0tLVmEvRG5XNkRrVmx3NUQ5cXl3RXE4?=
 =?utf-8?B?R1dyS21TQnoxQ0xmMDNPTXYrdUpKbmZIdFNIM1NvcEJnZVgvMmtabk5HdnNL?=
 =?utf-8?B?ZTczTWNIWU9BV2M2dlFnSWU3SEcya0VQVll2MjBXVitxQkR0dzkzNnFFTXZV?=
 =?utf-8?B?a2hTYlFGcGt4ZVorZ2pJVXdBVEE4UGNYR29KZFBIRXF5ZW1uNTIvSFFIUXJZ?=
 =?utf-8?B?L2IvbWMrazJFS0kxYnRacFFyVzYvM3ZLek8vUlppMjZRVUpOMjYwZFpGZHU2?=
 =?utf-8?B?WWFicU02cjUrdC9pNGo0M3pabkc1VldNSTJyNzEzNGh1b2RpTy9QT25XalZ3?=
 =?utf-8?B?ZzR0TXJEL3JVYWZTY1BxTDMwYUZnRWdTRDE2bDQ1RGwxNW1QWFRUOVZOU05t?=
 =?utf-8?B?OEV4TjRUOXZvbFZrcnJVNVprVDB4cEE1WmtHYUVDV21iNGdTdElmSjFycDIr?=
 =?utf-8?B?RVhFOHUvMyszR1ZvRXhndGZaeUoxYTlpRHFxdGFHdjl4UXhjTkd0cVpPK294?=
 =?utf-8?B?VlRja3ExRWFyU3lZQURZTlRlelNuRkMwYnBLejZxUHN3TTIvOUI2YXB6MCsw?=
 =?utf-8?B?NXpVY0lucEdwaVVvMFhUeWpPdGYxalBUUGFmaVc3YkhSNy9ObmN3enBmY2t5?=
 =?utf-8?B?MDRLWEpNQXdaSUNqTGVMSnNRbFdzQ0dpMmNnWW00aU1SSSt1ZEJ3RVE2V0kw?=
 =?utf-8?B?U1Zlb3ZZZWwxVW5ScnRxVUw0OE53ZHpsQkhvVStWTTVPU0lDb290amNPVDZM?=
 =?utf-8?B?eGUvZnVNRnNxSUVTbytBb0xGQ2Z4aXM3L3lOQzRYZC9MMjE4WTVaYkVjYldx?=
 =?utf-8?B?Ri85Q0wxYlBFRXF1TDMyYUtkZDYzMDJGT0dZeWhtRjJUZ1NVOGk3VHlYZWc0?=
 =?utf-8?B?QzdFU2tBOC8xVmNNeTJ4MUVmTS9PM2xwek9wSmIyclZhbkU5M2ZsWnMyeFBE?=
 =?utf-8?B?eTNlZzM3S0F2eVhHMkF3SWRHMEt3ODdOQ2tsOGhkMklzWG1LRlB6dm9TaGxV?=
 =?utf-8?B?d0ZvNkhXK09oaHpjQzZyMW5BRlNQY3hKeWtvRFp5WXMvT1h3WUN3bWtuYkFO?=
 =?utf-8?B?aVU4NVc1RW4rbThsUzF6dzJ2Z2JyMStqRE1ucWFBUnBVYUdYa04rVVZTbEhk?=
 =?utf-8?B?akZWNnMzRXJFK214M1ZiY2VCcUU5T1dCbVBodlZVQWZJRWVwV05KYXBxQ2Y4?=
 =?utf-8?B?ejI0c0lwMFpjN01UTlBuSGxMVFBPWXlIVGJFYm9vMGlYc2lwZFA4UTZ0YlZM?=
 =?utf-8?B?YXNEU0ZQK0VzYVVKbVk5WU9hWG5UZWM0OWkwc2F6SnVDdk5HeGVKZS93Nk1T?=
 =?utf-8?B?a0VUTHQwSWdmUFErTGNSYmUzK2JHVVAydDFVZGZQdWViTUNWbWpHZlJ4ZXlT?=
 =?utf-8?B?R0dLcnJ6QzR3d0hmK3BFQ1Uvem9pTVFCZXJxZDh6MDd1UUV4Q2VvRTdVcXdz?=
 =?utf-8?B?eFVJR2JVSlp6MkFMMFBCQ05QN25vSU9VQk1TQkduMFA1a1hpWmowRjJyWGdw?=
 =?utf-8?B?TisvNTNKeTZtK3g3TlNtNVhhc0sxdU82V3pIZmorS0hjMjVMRnhsMmZFQ3ds?=
 =?utf-8?Q?YB2SF1JZfI60lHZy7xSypEM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 84e803d3-add4-4ac0-dedc-08d9f821d0dd
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 05:43:57.4414
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eOAFBMRZkiFWi71CDLN4ni8e2SE2HcOi1au8F4/hgs+hfx69wSnUQQFhDTtyUHbXOd0vY298LApE+O20NRp7ZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4029
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10268 signatures=684655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0
 mlxlogscore=894 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202250028
X-Proofpoint-GUID: FgS1OlCB9e8Fd4W845GfubYdAMQ-fiqP
X-Proofpoint-ORIG-GUID: FgS1OlCB9e8Fd4W845GfubYdAMQ-fiqP
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Tejun,

Thanks again for reviewing this. I have refactored the code.
I have also added a document to describe lock usage and proof
of correctness in the new patch set at [1]. This took some time
but it can highlight if I have understood something wrong while
making these changes.

[1]
https://lore.kernel.org/lkml/20220225052116.1243150-1-imran.f.khan@oracle.com/

Thanks
 -- Imran

On 15/2/22 5:15 am, Tejun Heo wrote:
> Hello,
> 
> The patchset generally looks good to me but I think it can be split a bit
> better and the locking helper code can be more compacted. Also, it'd be
> great o include the benchmark method and result in the commit log so that it
> can be looked up easily later. It just has to be in one of the patch
> descriptions whether the first or last of the series and the rest can refer
> to it.
> 
> Thanks.
>