Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Sunil Goutham <sgoutham@marvell.com>,
        Wan Jiabing <wanjiabing@vivo.com>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     jiabing.wan@qq.com
Subject: [PATCH] hwrng: cavium: fix NULL but dereferenced coccicheck error
Date:   Fri, 25 Feb 2022 14:38:59 +0800
Message-Id: <20220225063901.893274-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Vpf8grCpRkhbw3H3u8O3yz+1J3oYoMka9ubzPX5wTActZ44eSFKvHa7cr5eQ?=
 =?us-ascii?Q?Z7lqlP5uOD1geDNtadsRWjCM6w3qozhAr+hPMfMc+570/ksNqdksAfHwfRm1?=
 =?us-ascii?Q?yAGz6oWdP4RGk1ktWUnx66Uci+VB8T1ha0lrwvpiKsWeMIVh2mZ54PvqoWN/?=
 =?us-ascii?Q?B58xWbiVzQ2nbo3kA96j0xfSNEsiMYStrSuBFos+2sZWdWTHKIqR2QePhm2l?=
 =?us-ascii?Q?JEMTTaoUjCMEfq1rNOjhq5cRUTCIqyBC5azZwH51rieyxQQq9WkLx+l1BxAh?=
 =?us-ascii?Q?j+nl4vL6dsqeBvWVmhIJugpI/53eSQmQh5BPu2jKJeKQcrJ9ui9Cl0zT7tg3?=
 =?us-ascii?Q?LrwHrH4YzumqKktpm1HKSaKrGP6/ykYkrYwWx7bglbhLbsUMGrnUYiuIePzJ?=
 =?us-ascii?Q?bAMXi2zPthm6I3K5fOEuj5UU9BeoMDqdxJC5H0C3IPanwyAE532PXU1MTYiw?=
 =?us-ascii?Q?wLKKK/TEWgVTx0+Wvr/UqzEyNwaBsCXf8P30d57b4MIzMAFgTK8z1cKn2/vA?=
 =?us-ascii?Q?OxYfXoZpI/bCJf93jz5cISt/I4hB6eB5apzf1HtCm5THfinUnNvLKKdbVx8/?=
 =?us-ascii?Q?Oh7Y1kKUR7tueIMB1hW3RkyiDkLijFxfGETi7o4ZnoWvdJC9DVCR+zC9bk2J?=
 =?us-ascii?Q?IIGSjIT/UVe0oS5kPv/ZZFXFM3ALqGuKlZMY8QU96JFh4voqA23rMneMT144?=
 =?us-ascii?Q?za5y59SotTCo0GTyqSNqUEWjwfKN+3eozXNWQEd2B8ragbXclbCIvcyQyWiG?=
 =?us-ascii?Q?A6dwa/U5irSonVKlO32QywuAAuIe69nY7Bgy6DcsgDdtCDKRHuy7chFTBrjm?=
 =?us-ascii?Q?AseVTqylvCAPNKVAtfa4XMxTIaEjps6K7hX6Rtcw+HOMR4tfVSeqyfYxiXsb?=
 =?us-ascii?Q?AFivooTrAZZsx7FiPS9DEMY5uVxMWQNx0+FuIGty5wl/1Nuv+kYu0ZoyZ7Zd?=
 =?us-ascii?Q?FQJJkkiE6htvSBdDPqA0H2AjZ/mtEMikrCbI9Hm9U+YZDJVS6RfhvK9Y7+dK?=
 =?us-ascii?Q?CNOnVpGbFQBujkeqd80mazbt9g3nSi0jUZSO9lqg6U8H2UNSMUl3AhYsbeye?=
 =?us-ascii?Q?SFrzI4gpQ5BErr1mlZlL3vcW2StC9DS8+uhJhICRXtADx1V+Q1VpZgZBK3a0?=
 =?us-ascii?Q?dKM3bZ6es/sDZljH/KkLWgmtDPwf1f7VI/TY1c+k6opVRCovPimc/XcE7sEo?=
 =?us-ascii?Q?7WKHEC+mrE7sVu6uTwrI3RFPhZfMia5NiPq0MVu5WOWNdARiOQRo5jm6kthU?=
 =?us-ascii?Q?IQTHVwgRK8lHVIjCGQAmDqFrPX4s7tUSYSlngZGRJxhKrz2PcswIBDpEGijZ?=
 =?us-ascii?Q?kUDaWi4Y3So7GJCB6VvldTNc+8g9/I6VFJA/mEfECPTa+yzyO4pHrRsJWRdP?=
 =?us-ascii?Q?sccquRAMftoNsQZmi2ZwFXoifc+meaCFn2TXdortcJRiM8aE71GbCBVRude3?=
 =?us-ascii?Q?f3w+RZn+4ybAl51O+055VXWSvAM2IZ/JhGdbt4qnlp4yPCK1NUmNNGu1RijS?=
 =?us-ascii?Q?7j/EcNI0HjJSu1N1CUlhXyC9a4gZmaCwSPaIM61v47ty3FLytgeABpUfp3QL?=
 =?us-ascii?Q?/kHm1DyWg4yqWT+aZ8sKSHOOUxFly/Sfn/F4Sz+mYIq+yZu2j/M3N06w9WgC?=
 =?us-ascii?Q?12YtRb3AW4/U7dgBVKg+2iA=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b86e7dc-7cb0-4acc-cb54-08d9f8298e50
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 06:39:21.6830
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d7w00G2lsR24c2Xi6suidN2nIx1HAVHKKuTOfC88wZfKWGzSel1S7IpgTdttLCY4uUHMEGXmYzIrsHpMzsmWGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4246
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/char/hw_random/cavium-rng-vf.c:182:17-20: ERROR:
pdev is NULL but dereferenced.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/char/hw_random/cavium-rng-vf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/hw_random/cavium-rng-vf.c b/drivers/char/hw_random/cavium-rng-vf.c
index 6f66919652bf..7c55f4cf4a8b 100644
--- a/drivers/char/hw_random/cavium-rng-vf.c
+++ b/drivers/char/hw_random/cavium-rng-vf.c
@@ -179,7 +179,7 @@ static int cavium_map_pf_regs(struct cavium_rng *rng)
 	pdev = pci_get_device(PCI_VENDOR_ID_CAVIUM,
 			      PCI_DEVID_CAVIUM_RNG_PF, NULL);
 	if (!pdev) {
-		dev_err(&pdev->dev, "Cannot find RNG PF device\n");
+		pr_err("Cannot find RNG PF device\n");
 		return -EIO;
 	}
 
-- 
2.35.1