Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Feb 2022 13:14:15 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To:     Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>, agross@kernel.org,
        robh+dt@kernel.org, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: Add chosen node information for SDX65.
Message-ID: <20220225074415.GF274289@thinkpad>
References: <1644574845-23248-1-git-send-email-quic_rohiagar@quicinc.com>
 <YhfgAL8z6rO+zU3w@builder.lan>
 <b9205016-1f33-74fd-c314-c307412bfca3@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b9205016-1f33-74fd-c314-c307412bfca3@quicinc.com>
Precedence: bulk

On Fri, Feb 25, 2022 at 12:46:26PM +0530, Rohit Agarwal wrote:
> 
> On 2/25/2022 1:14 AM, Bjorn Andersson wrote:
> > On Fri 11 Feb 04:20 CST 2022, Rohit Agarwal wrote:
> > 
> > > Add chosen node in the base dtsi file of SDX65.
> > > 
> > While this happens to be the same on most boards, it is still a
> > board-specific decision which UART is the debug uart, or if there is one
> > at all...
> > 
> > So this property should remain in the dts.
> > 
> > Thanks,
> > Bjorn
> 
> Without the chosen node in base dtsi, the device is not booting up.
> Can we have an empty chosen node in the base dtsi and the board-specific
> details
> updated in the respective dts file. The device boots up with this.
> 

I believe this is something to do with bootloader. But still I don't understand
how this matters at all since the bootloader finally parses the "dtb" only.

Is the bootloader picking up correct dtb?

Thanks,
Mani

> Thanks,
> Rohit
> 
> > > Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> > > ---
> > >   arch/arm/boot/dts/qcom-sdx65-mtp.dts | 4 ----
> > >   arch/arm/boot/dts/qcom-sdx65.dtsi    | 4 ++++
> > >   2 files changed, 4 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/arch/arm/boot/dts/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> > > index 59457da..3a75c21 100644
> > > --- a/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> > > +++ b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> > > @@ -14,10 +14,6 @@
> > >   	aliases {
> > >   		serial0 = &blsp1_uart3;
> > >   	};
> > > -
> > > -	chosen {
> > > -		stdout-path = "serial0:115200n8";
> > > -	};
> > >   };
> > >   &blsp1_uart3 {
> > > diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi
> > > index 796641d..653df15 100644
> > > --- a/arch/arm/boot/dts/qcom-sdx65.dtsi
> > > +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi
> > > @@ -17,6 +17,10 @@
> > >   	qcom,msm-id = <458 0x10000>, <483 0x10000>, <509 0x10000>;
> > >   	interrupt-parent = <&intc>;
> > > +	chosen {
> > > +		stdout-path = "serial0:115200n8";
> > > +	};
> > > +
> > >   	memory {
> > >   		device_type = "memory";
> > >   		reg = <0 0>;
> > > -- 
> > > 2.7.4
> > >