Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp31346pxm; Fri, 25 Feb 2022 03:24:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJxnteN0qgqGsaQi0kJ0aHE/UgZ1s6hbXdog5bC9AXeWkU60LONA82p9YS6Hyo8JDHAC3gOK X-Received: by 2002:a63:c61:0:b0:370:592b:3ad1 with SMTP id 33-20020a630c61000000b00370592b3ad1mr5781152pgm.240.1645788282044; Fri, 25 Feb 2022 03:24:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645788282; cv=none; d=google.com; s=arc-20160816; b=OCpewnAtzhMJgP2Ttl9MxOOKeng2Lj1VATtlbiIVu0SBDXJxspVORqmyABRvii6Qj1 MY1XbJxlUl8TU+MvbA5y+J9LJW/ivmV5q0So245IE50nFpAF34oVhn/Zbl3bX10Uf0Ij Lm8+n0s6QtWdQi7Tf8McH8qxNMuivWOdb2rK4LOcI3Hk29YfI6UFIVkMCO6DINMf5VxS 5s1VOdyiHJ5DwpWr+8737ZZshe3WcW/bDDT5b7xV80XtAT4i1o+3XX3u2yP+HOe7bPmb qxZ9MdPENqSt2lLJwX95QDNS6T4J9rtaOZQnFnD2JCNg8YleOSFlYAj7nLT321ymkU+p R4ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=dJfDr6G5W6xlHEgDunIm+HbbO6B3ggY/bawweEW2mBU=; b=rN0aHdufEBbiYXUpNUoei/NP10wv8T+gq9Y8kzq/dW/XYY5KWM4Lbv3nh7JrSm0GPS Tj32ztSFjuUNvNdc5U/t/4G6M+I9Fg7EJ8uTEnCcICbubl5juLKZ76BpXGO0VFWDaahj 2X5OGR6x4K1CFx5fbfxCMiD3gtm7D+F72OPHrvf3BSnr1BpErbqUdS5nqOxqT/WKh/A0 cD9SRYJKb9IV6k4978F7jIagdzStxwkluTPICv6rpabrUH+PcFf0d0rxVjJusqV5bCqg i5uB6rBEXaeaBHpvd4EdwGIDBdyoyRPwzM5CIPW7h5uLzZYww94Myv1cXcfqQ71VwAYq m1iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Cp6DBjCS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b13-20020a056a000a8d00b004e1569ce1c4si1700781pfl.376.2022.02.25.03.24.24; Fri, 25 Feb 2022 03:24:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Cp6DBjCS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239144AbiBYJfh (ORCPT + 99 others); Fri, 25 Feb 2022 04:35:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237389AbiBYJfg (ORCPT ); Fri, 25 Feb 2022 04:35:36 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F9BC1F767A; Fri, 25 Feb 2022 01:35:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 14FE660B1B; Fri, 25 Feb 2022 09:35:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1ED5EC340E7; Fri, 25 Feb 2022 09:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645781704; bh=abf0Kch29YhEwOBNj51lTk+PAfj/fNdrPzssmkFkqcQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cp6DBjCSjkdqWtr+kYaxgG+OSWSYZmiIzWtpNlRwDK6SwIRYroop7daFC6tvAgyUm b9LXto5PtMZ9/p6wo967SOrCHF2bnIMIWA7AtJa67EGbf/etTe7JkYH/awSZOiA2/I gedfxZfUTPpXVI//iIkPjW/a0fHVZl3QXb+JDQOc= Date: Fri, 25 Feb 2022 10:35:02 +0100 From: Greg Kroah-Hartman To: "Maciej W. Rozycki" Cc: Jiri Slaby , Andy Shevchenko , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] serial: 8250: Report which option to enable for blacklisted PCI devices Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 12, 2022 at 05:30:59PM +0000, Maciej W. Rozycki wrote: > Provide information in the kernel log as to what configuration option to > enable for PCI UART devices that have been blacklisted in the generic > PCI 8250 UART driver and which have a dedicated driver available to > handle that has been disabled. The rationale is there is no easy way > for the user to map a specific PCI vendor:device pair to an individual > dedicated driver while the generic driver has this information readily > available and it will likely be confusing that the generic driver does > not register such a port. > > A message is then printed like: > > serial 0000:04:00.3: ignoring port, enable SERIAL_8250_PERICOM to handle > > when an affected device is encountered and the generic driver rejects it. > > Signed-off-by: Maciej W. Rozycki I've applied patch 1 of this series, but this is really an odd one. We don't do this for any other driver subsystem, so why is it really needed? What is so special about this driver that distros can't just enable all of the drivers and all is good? What is keeping those drivers fromb eing enabled? thanks, greg k-h