Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5aef6ed4-7d05-3d1e-2cc1-7c49e4761c4d@ti.com>
Date:   Fri, 25 Feb 2022 17:38:27 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2] arm64: dts: ti: k3-am642-sk: Enable WLAN connected to
 SDHCI0
Content-Language: en-US
To:     Aparna M <a-m1@ti.com>, <nm@ti.com>, <kishon@ti.com>,
        <kristo@kernel.org>, <robh+dt@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     <praneeth@ti.com>, <nikhil.nd@ti.com>
References: <20220223155754.7298-1-a-m1@ti.com>
From:   Vignesh Raghavendra <vigneshr@ti.com>
In-Reply-To: <20220223155754.7298-1-a-m1@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi

On 23/02/22 9:27 pm, Aparna M wrote:
> From: Kishon Vijay Abraham I <kishon@ti.com>
> 
> WL1837 module is connected to SDHCI0 in AM642 SK. Enable it here.
> This will enable the WiFi functionaliy on the board.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> Signed-off-by: Aparna M <a-m1@ti.com>
> ---
> 
> v1 -> v2: Update commit message with "From:" details
> 
>  arch/arm64/boot/dts/ti/k3-am642-sk.dts | 62 ++++++++++++++++++++++++++
>  1 file changed, 62 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> index 6b04745147be..1178bb982f05 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> @@ -125,6 +125,31 @@
>  		vin-supply = <&vcc_3v3_sys>;
>  		gpio = <&exp1 3 GPIO_ACTIVE_HIGH>;
>  	};
> +
> +	com8_ls_en: fixed-regulator-com8 {

Please use generic node names as per DT spec [1]

Something like:
	com8_ls_en: regulator-1 {
		...
	};


> +		compatible = "regulator-fixed";
> +		regulator-name = "com8_ls_en";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-always-on;
> +		regulator-boot-on;
> +		pinctrl-0 = <&main_com8_ls_en_pins_default>;
> +		pinctrl-names = "default";
> +		gpio = <&main_gpio0 62 GPIO_ACTIVE_LOW>;
> +	};
> +
> +	wlan_en: fixed-regulator-wlan {

same as above

> +		/* output of SN74AVC4T245RSVR */
> +		compatible = "regulator-fixed";
> +		regulator-name = "wlan_en";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		enable-active-high;
> +		pinctrl-0 = <&main_wlan_en_pins_default>;
> +		pinctrl-names = "default";
> +		vin-supply = <&com8_ls_en>;
> +		gpio = <&main_gpio0 48 GPIO_ACTIVE_HIGH>;
> +	};
>  };
>  
>  &main_pmx0 {

[...]

[1]
https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.4-rc1


Regards
Vignesh