Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH v2] xen/netfront: destroy queues before real_num_tx_queues is
 zeroed
From:   patchwork-bot+netdevbpf@kernel.org
Message-Id: <164578561057.13834.5994173770160348500.git-patchwork-notify@kernel.org>
Date:   Fri, 25 Feb 2022 10:40:10 +0000
References: <20220223211954.2506824-1-marmarek@invisiblethingslab.com>
In-Reply-To: <20220223211954.2506824-1-marmarek@invisiblethingslab.com>
To:     =?utf-8?q?Marek_Marczykowski-G=C3=B3recki_=3Cmarmarek=40invisiblethingslab?=@ci.codeaurora.org,
        =?utf-8?q?=2Ecom=3E?=@ci.codeaurora.org
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        boris.ostrovsky@oracle.com, jgross@suse.com,
        sstabellini@kernel.org, davem@davemloft.net, kuba@kernel.org,
        atenart@kernel.org, xen-devel@lists.xenproject.org,
        netdev@vger.kernel.org
Precedence: bulk

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Wed, 23 Feb 2022 22:19:54 +0100 you wrote:
> xennet_destroy_queues() relies on info->netdev->real_num_tx_queues to
> delete queues. Since d7dac083414eb5bb99a6d2ed53dc2c1b405224e5
> ("net-sysfs: update the queue counts in the unregistration path"),
> unregister_netdev() indirectly sets real_num_tx_queues to 0. Those two
> facts together means, that xennet_destroy_queues() called from
> xennet_remove() cannot do its job, because it's called after
> unregister_netdev(). This results in kfree-ing queues that are still
> linked in napi, which ultimately crashes:
> 
> [...]

Here is the summary with links:
  - [v2] xen/netfront: destroy queues before real_num_tx_queues is zeroed
    https://git.kernel.org/netdev/net/c/dcf4ff7a48e7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html