Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Feb 2022 09:57:22 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     Michael Straube <straube.linux@gmail.com>, phil@philpotter.co.uk,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: r8188eu: remove 5 GHz channels from
 ch_freq_map
Message-ID: <YhiZ8lCkQluFeNv8@kroah.com>
References: <20220220154847.7521-1-straube.linux@gmail.com>
 <20220220154847.7521-2-straube.linux@gmail.com>
 <YhPIVFmStJOMI0QZ@kroah.com>
 <636080dd-ab8d-a572-0f81-5f72b14ec1e4@lwfinger.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <636080dd-ab8d-a572-0f81-5f72b14ec1e4@lwfinger.net>
Precedence: bulk

On Mon, Feb 21, 2022 at 01:41:22PM -0600, Larry Finger wrote:
> On 2/21/22 11:13, Greg KH wrote:
> > On Sun, Feb 20, 2022 at 04:48:45PM +0100, Michael Straube wrote:
> > > This driver is for chips that operate only in the 2.4 GHz band.
> > 
> > How do we know that?
> > 
> > thanks,
> Realtek (https://www.realtek.com/en/products/communications-network-ics/item/rtl8188eus)
> states the following:
> 
> "The Realtek RTL8188EUS is an 802.11bgn 2.4G single-chip that integrates
> Wireless LAN (WLAN) and a network USB interface (USB 1.0/1.1/2.0 compatible)
> controller. It combines a WLAN MAC, a 1T1R capable WLAN baseband, and WLAN
> RF in a single chip. The RTL8188EUS provides a complete solution for
> high-throughput performance and low power consumption integrated wireless
> LAN devices."
> 
> The reason there are 5G snippets in the driver is because Realtek uses the
> base code to generate drivers for other chip families such as RTL8192DU that
> have radios for both 2.4 and 5G bands. The RTL81288EU and variants have only
> a single radio.

Ah, ok, that's good to know.  And should belong in the changelog text so
that we are not confused :)

thanks,

greg k-h