Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Feb 2022 14:18:32 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Wayne Chang <waynec@nvidia.com>
Cc:     balbi@kernel.org, gregkh@linuxfoundation.org, jonathanh@nvidia.com,
        zhangqilong3@huawei.com, yangyingliang@huawei.com,
        rikard.falkeborn@gmail.com, chunfeng.yun@mediatek.com,
        linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] usb: gadget: tegra-xudc: Do not program SPARAM
Message-ID: <YhjXKLVYgpop27R9@orome>
References: <20220107090443.149021-1-waynec@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="gl8CDPNI6wZnzrfJ"
Content-Disposition: inline
In-Reply-To: <20220107090443.149021-1-waynec@nvidia.com>
User-Agent: Mutt/2.2.1 (c8109e14) (2022-02-19)
Precedence: bulk


--gl8CDPNI6wZnzrfJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 07, 2022 at 05:04:43PM +0800, Wayne Chang wrote:
> According to the Tegra Technical Reference Manual, SPARAM
> is a read-only register and should not be programmed in
> the driver.
>=20
> The change removes the wrong SPARAM usage.
>=20
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> ---
>  drivers/usb/gadget/udc/tegra-xudc.c | 8 --------
>  1 file changed, 8 deletions(-)

What's the impact on this? Does it fix a bug? Or is it more of a
cosmetic change?

Thierry

--gl8CDPNI6wZnzrfJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmIY1ygACgkQ3SOs138+
s6HEHg/7BPV/te79tMNbpLbDXsmVdevmiKD9gyzneQk9jA2xEg7SNmeNCMuhyL7h
FVl1Kd46D2ZYfcOTXQ/FANEWLRRaqY3KLCdp3OsjqibkiR98tRGcvrjHIxZGaiU+
qMcV+Ok1rLesSfdvEi0tlFVkL1+jE3pHnX4KvOWb7KRQ2obnXpusYL2e4XJo+i5W
iyEe7BIrnq1SFBQTq3L3G8V/s3BeHVpmpcgyAPvsmq7gG7cF8X6WbeKnE5Z8GXi0
8RzT3L7S29RYqjWnSfWE4p6HKX1jTL7LPILl1nbLJyelJJCsVgPSoaL/Ls4aq+QJ
3wluNy2h40YcBEORncgr15l0FxVTZUhYPOMh5FT+cqVpAISHYKyfvnvL4Chiaibb
ZwG7SGY8Z9pYH/96vXr3CXddRfzmhhZ7kPi2LZ6HJ47QRTnnYnMtQBP2KlsR04fO
1DZzJWqovwtKuescW0Zq++6ga3jtifHdh36LFf9w2uIxaNUpwLc8tgZ7l2H4phvj
W4zahDZyxvZy6zstgxy/lmw8u6Sxnw6nRHbXC+c3UbbmOCl3vnBnzbQPME8CJy2l
dR316IDKh0+lo+ZyHQRgZfbpFQwV2dN1m3P8owKvN+HcJ1Twi6ZAQl2hJS09Nyjg
aFTPbwA4CbkJlJIeF91zx+bwSkOXIxN9PJpFU+A3oRATQ/Y6vfk=
=A+Ss
-----END PGP SIGNATURE-----

--gl8CDPNI6wZnzrfJ--