Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   SeongJae Park <sj@kernel.org>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     SeongJae Park <sj@kernel.org>, akpm@linux-foundation.org,
        corbet@lwn.net, skhan@linuxfoundation.org, rientjes@google.com,
        xhao@linux.alibaba.com, linux-damon@amazon.com, linux-mm@kvack.org,
        linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 13/13] Docs/ABI/testing: Add DAMON sysfs interface ABI document
Date:   Fri, 25 Feb 2022 15:03:47 +0000
Message-Id: <20220225150347.13173-1-sj@kernel.org>
In-Reply-To: <YhjuqWAsT2PY5sPg@kroah.com>
Precedence: bulk

Hi Gregg,

On Fri, 25 Feb 2022 15:58:49 +0100 Greg KH <gregkh@linuxfoundation.org> wrote:

> On Fri, Feb 25, 2022 at 02:15:40PM +0000, SeongJae Park wrote:
> > On Fri, 25 Feb 2022 14:10:07 +0000 SeongJae Park <sj@kernel.org> wrote:
> > 
> > > Hello Gregg,
> > > 
> > > 
> > > On Fri, 25 Feb 2022 13:23:00 +0000 SeongJae Park <sj@kernel.org> wrote:
> > > 
> > > > On Fri, 25 Feb 2022 14:18:59 +0100 Greg KH <gregkh@linuxfoundation.org> wrote:
> > > > 
> > > > > On Fri, Feb 25, 2022 at 01:07:12PM +0000, SeongJae Park wrote:
> > > > > > This commit adds DAMON sysfs interface ABI document under
> > > > > > Documentation/ABI/testing.
> > > > > > 
> > > > > > Signed-off-by: SeongJae Park <sj@kernel.org>
> > > > > > ---
> > > > > >  .../ABI/testing/sysfs-kernel-mm-damon         | 276 ++++++++++++++++++
> > > > > >  MAINTAINERS                                   |   1 +
> > > > > >  2 files changed, 277 insertions(+)
> > > > > >  create mode 100644 Documentation/ABI/testing/sysfs-kernel-mm-damon
> > > > > > 
> > > > > > diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > > > > > new file mode 100644
> > > > > > index 000000000000..11984c3a4b55
> > > > > > --- /dev/null
> > > > > > +++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > > > > > @@ -0,0 +1,276 @@
> > > > > > +what:		/sys/kernel/mm/damon/
> > > > > > +Date:		Feb 2022
> > > > > > +Contact:	SeongJae Park <sj@kernel.org>
> > > > > > +Description:	Interface for Data Access MONitoring (DAMON).
> > > > > > +		See Documentation/admin-guide/mm/damon/index.rst for details.
> > > > > 
> > > > > Ick, no.  Put the real details in here please.  That way it works with
> > > > > our tools.
> > > > 
> > > > Ok, thanks for the quick comment!
> > > 
> > > Before sending the full series again, I'd like to get your comment if you're
> > > ok.  What do you think about below?
> > > 
> > > diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > > new file mode 100644
> > > index 000000000000..11984c3a4b55
> > > --- /dev/null
> > > +++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > > @@ -0,0 +1,276 @@
> > > +what:		/sys/kernel/mm/damon/
> > > +Date:		Feb 2022
> > > +Contact:	SeongJae Park <sj@kernel.org>
> > > +Description:	Interface for Data Access MONitoring (DAMON).
> > > +		See Documentation/admin-guide/mm/damon/index.rst for details.
> > 
> > Oops, I pasted wrong, sorry.  Please read below:
> > 
> > diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > new file mode 100644
> > index 000000000000..e58d844b4f82
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > @@ -0,0 +1,273 @@
> > +what:		/sys/kernel/mm/damon/
> > +Date:		Feb 2022
> > +Contact:	SeongJae Park <sj@kernel.org>
> > +Description:	Interface for Data Access MONitoring (DAMON).  Contains files
> > +		for controlling DAMON.
> 
> For this entry, point people at your larger documentation.

Good suggestion, I will.

> 
[...]
> 
> Yes, this looks much better, thanks.  But you might want to change the
> month as I doubt this will be merged in the next few days :)

Thank you for the quick and nice comment :)


Thanks,
SJ

> 
> thanks,
> 
> greg k-h
> 
>