Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Feb 2022 10:55:19 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Markuss Broks <markuss.broks@gmail.com>,
        linux-kernel@vger.kernel.org
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht,
        Markuss Broks <markuss.broks@gmail.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Henrik Rydberg <rydberg@bitmath.org>,
        linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6 2/2] Input: add Imagis touchscreen driver
Message-ID: <202202250109.qr1l07ts-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220222203414.8656-3-markuss.broks@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?twq+epBM5TqQiyMZImOm9eWHq6eSUdJM9bjym95aeExIQwrIC2flGHexEbci?=
 =?us-ascii?Q?6lFoZpwSZ3VWVHfpB8uWq3U7TZ0LjxeZXyjBEsK+7S55jjBd9S/MLHtjHCkU?=
 =?us-ascii?Q?InSvetPt4331qEBG7AHZLmNY4PxCfO98HNHIVIGMXBLbORYeEbHmrRbrQocs?=
 =?us-ascii?Q?D6WcXi2HpFTV/ZvogvpK26tni6VkjawXcqM8A0SEUgK8WixOoP7tkWX8TVUn?=
 =?us-ascii?Q?SH5rGD3fb6gAtI2428xNjBsRckWYMsottVq5Jgnhb3oYBgC44xd6TLOkZYI9?=
 =?us-ascii?Q?WIYi6pauAorZWduQXXhAtWz1rnQnRtQ/FESTgtfe/oJdoOgUuHVjrYl/sZYx?=
 =?us-ascii?Q?h/9GmqIHVHzXQOl2bKhm1lrjxEj3AyCgEooj5HJGzsaw8n0oGpUKn4txXJHM?=
 =?us-ascii?Q?dTXmdL5ItOVq+z70f0OMhiYW68SIVVOrlyaY9xEsVV6mxuhV9O8YP+RURPCJ?=
 =?us-ascii?Q?1KgvaS3ZouvkP+9DWSe/QUtf8II5IoVfxIrzjtbZvGk1PmwFbRUkr4niYhQb?=
 =?us-ascii?Q?i82ESYTNevc+i0T8g7qr137z3uhnzsGTCTqFHuAmmBmgyN0iE0QQsp8puOaF?=
 =?us-ascii?Q?L3pTcb2CbTUfc5pKEgxMp7AkqitjHOI9TGb43UcDnprsJE49SiIfg3nLl4OK?=
 =?us-ascii?Q?4pI4M5D23QKkJcsJVjD2aXmRQ0yiJ4kgV+sifz3lfy8zQ5/EBD1E+PnuYSST?=
 =?us-ascii?Q?ser+/3vlUUvCJsi6gmfmsElZ8vRvJsCFLWn57QM87m9VYmA4aV3o6TFID1Uy?=
 =?us-ascii?Q?YKw7sxzTogxAW8MXBBPQQI8oYkLrRiUWZer9bjvfYQhqr4hl54Gd3BPDl08O?=
 =?us-ascii?Q?n9VtuEsJDB0LOoWMjGZydVJWjsaDlRwBvqqCIb3ceopkqDQHIIoWf/K/aIgD?=
 =?us-ascii?Q?2fGiges5cfDXLSqLm7ivHY1EVJ4dTxGDKAgIOaixztTg85fdESoUc7iM+SLe?=
 =?us-ascii?Q?Dv9zpEyC0iD6fMP9hP3g2hfJFSroiBuQS0tzqY+Gx/z8gVJ/CNxsSXvh/m/c?=
 =?us-ascii?Q?cZbYQkPhh3RPFUUHCdkf5kREuHM+pkKu/EKPEiKcVnQm0OuUCdo3A19G1xf1?=
 =?us-ascii?Q?kZ1PQWkblK/ofoQ/zrtf5Yb8fVEMEgrUeLH9RoFc4NcauG5xyd4kSEywQyk7?=
 =?us-ascii?Q?OLaqZoMqMP3Lo3B0FYbBDLPr9F1XyOOk+VJJI+A0D2+RoM+kdbVADk5vx2Mg?=
 =?us-ascii?Q?qqAZ02G97ATQkayrjPeiCggBORkWSQHMAw25gd45mZLIPgvYf/t6zfP8rUX/?=
 =?us-ascii?Q?yzgnsiXEziH2PkUjHEH5ow0Cso3R01+JGZq7PkrMCH5wFiki6KVwddTptTBB?=
 =?us-ascii?Q?7FfxJLcsrFVyCumYSfnKNeFdWK6Pii0qAqRxqABJNWSE3a7hOXjrib4mAvIm?=
 =?us-ascii?Q?oQ9+0ObrvpyoNzNP8BjEGx30MrcgAvuggyfBZ3jCvtxDDD/Cbkp727Ps46Lh?=
 =?us-ascii?Q?x8mrsX6BXbU5nKv99jw/I3hgiSE8UZ7HFfRd/96VZ6ZSN0snZv+w16W8gVu6?=
 =?us-ascii?Q?88QEI/QF4qCSJRXKJdAYpWg8QpkxzBxCXK9iehxO+q3E7sE87UCWD/L0KFGL?=
 =?us-ascii?Q?TQxt6bVxwUd5yLfQ3Ogoj4Gj2AjVeIvFNSlxc8YwDzzeaXDlM6rruOc0Rv4S?=
 =?us-ascii?Q?PMMLkva4hM+yXidFRLMp+iPyK3BYV6lwWy8gVnAJqQI2qI21ycecwoYNEyb2?=
 =?us-ascii?Q?NF5BwA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e8fbc57-ad40-408b-4dc5-08d9f834386a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 07:55:42.1707
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JuwJJXeN2KQ9F66cqMMvQtVaCXDtmfWkp/4TAHKCMPZCmVEtUCm0HJ2z9EAf6fGTUf6ad319DaUHcWZFbB+PsE64PHUv4SVVqWO9+vBXKA8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB4085
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10268 signatures=684655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 spamscore=0
 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202250039
X-Proofpoint-GUID: 8hywm7EdZCDQViQWS0TG-HiLJhKipEHt
X-Proofpoint-ORIG-GUID: 8hywm7EdZCDQViQWS0TG-HiLJhKipEHt
X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FAKE_REPLY_C,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Markuss,

url:    https://github.com/0day-ci/linux/commits/Markuss-Broks/Add-support-for-Imagis-touchscreens/20220223-043645
base:   https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: microblaze-randconfig-m031-20220224 (https://download.01.org/0day-ci/archive/20220225/202202250109.qr1l07ts-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/input/touchscreen/imagis.c:305 imagis_suspend() error: uninitialized symbol 'ret'.
drivers/input/touchscreen/imagis.c:321 imagis_resume() error: uninitialized symbol 'ret'.

vim +/ret +305 drivers/input/touchscreen/imagis.c

bc77ee5e0d7309 Markuss Broks 2022-02-22  292  static int __maybe_unused imagis_suspend(struct device *dev)
bc77ee5e0d7309 Markuss Broks 2022-02-22  293  {
bc77ee5e0d7309 Markuss Broks 2022-02-22  294  	struct i2c_client *client = to_i2c_client(dev);
bc77ee5e0d7309 Markuss Broks 2022-02-22  295  	struct imagis_ts *ts = i2c_get_clientdata(client);
bc77ee5e0d7309 Markuss Broks 2022-02-22  296  	int ret;
bc77ee5e0d7309 Markuss Broks 2022-02-22  297  
bc77ee5e0d7309 Markuss Broks 2022-02-22  298  	mutex_lock(&ts->input_dev->mutex);
bc77ee5e0d7309 Markuss Broks 2022-02-22  299  
bc77ee5e0d7309 Markuss Broks 2022-02-22  300  	if (input_device_enabled(ts->input_dev))
bc77ee5e0d7309 Markuss Broks 2022-02-22  301  		ret = imagis_stop(ts);

"ret" not initialized on else path.

bc77ee5e0d7309 Markuss Broks 2022-02-22  302  
bc77ee5e0d7309 Markuss Broks 2022-02-22  303  	mutex_unlock(&ts->input_dev->mutex);
bc77ee5e0d7309 Markuss Broks 2022-02-22  304  
bc77ee5e0d7309 Markuss Broks 2022-02-22 @305  	return ret;
bc77ee5e0d7309 Markuss Broks 2022-02-22  306  }
bc77ee5e0d7309 Markuss Broks 2022-02-22  307  
bc77ee5e0d7309 Markuss Broks 2022-02-22  308  static int __maybe_unused imagis_resume(struct device *dev)
bc77ee5e0d7309 Markuss Broks 2022-02-22  309  {
bc77ee5e0d7309 Markuss Broks 2022-02-22  310  	struct i2c_client *client = to_i2c_client(dev);
bc77ee5e0d7309 Markuss Broks 2022-02-22  311  	struct imagis_ts *ts = i2c_get_clientdata(client);
bc77ee5e0d7309 Markuss Broks 2022-02-22  312  	int ret;
bc77ee5e0d7309 Markuss Broks 2022-02-22  313  
bc77ee5e0d7309 Markuss Broks 2022-02-22  314  	mutex_lock(&ts->input_dev->mutex);
bc77ee5e0d7309 Markuss Broks 2022-02-22  315  
bc77ee5e0d7309 Markuss Broks 2022-02-22  316  	if (input_device_enabled(ts->input_dev))
bc77ee5e0d7309 Markuss Broks 2022-02-22  317  		ret = imagis_start(ts);

same.

bc77ee5e0d7309 Markuss Broks 2022-02-22  318  
bc77ee5e0d7309 Markuss Broks 2022-02-22  319  	mutex_unlock(&ts->input_dev->mutex);
bc77ee5e0d7309 Markuss Broks 2022-02-22  320  
bc77ee5e0d7309 Markuss Broks 2022-02-22 @321  	return ret;
bc77ee5e0d7309 Markuss Broks 2022-02-22  322  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org