Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp287221pxm; Fri, 25 Feb 2022 08:02:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5857zhEzjq78c2Cisk6/idMuR171Qdeix8RDhFtzcOM8cFpjo5n1LX2MLg5i1WjHqJcQk X-Received: by 2002:a17:902:9041:b0:14f:1c23:1eb1 with SMTP id w1-20020a170902904100b0014f1c231eb1mr7807407plz.173.1645804939141; Fri, 25 Feb 2022 08:02:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645804939; cv=none; d=google.com; s=arc-20160816; b=nmPI+vPVelSz/y3Sa2McZyInPAs+nCd1EpNXdNO5JMy6m06PmKO6pxGSYOKGSIFxnr spwIhkkUaCkurWsO+CrM70VCzok7jW52YnW7Wn+mBzyNnIUm5M08Ha4nar2ZftTtALTJ 0npwyDwSa744o1AMImQdaJEOpVh97KL/nsPW85BquiiebGwYrq+gsQv4DvF79XM3cOQG k7VlmxHQgTfVxnSuf+BezNyTZZoiCPLVCrWR03RKe6ZLHy7OB4mHNODR1asGiYJo0OOT TtXjbdyg9QxyuAPJHqc5T5/2fP2drx2P1wRTGxZliykrT1pS9zaEH2moKNgp7T/GpQnL mm3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=QL/pyQfzbu68OCKhp/E4qxakr8iuqodKYSrCGJxx/RY=; b=K/7JO+k43OCGhtnH1F/Fk6OFNRE7a+eeXph8BocRcRMUFoYKEYg7R1pIb2eexnrz0F 7wWAtaFA6kkcq+etX/HRNK9cy+7AU8hePfBqJmb3XKtJ0jXDKExZZ9CtSP6Uh+v4D9RD r64W3/9cf6BvrTuLdgkDRuHGERU3lB0EsafN1X1/vbcSrq2eWmKAPkn1617f6u0BBiaG AADYb0XXQb6RrH/bkBctUZ0eQgGZjrVAgqeIBveZvBzSHkGUITrJMTM7z5D8kQI3Gd3c ghG73UhGJtZHjPQN7vMqJO5W1vOA+OscmTWUyaG+ifRk2a3LaCrpHp0r3YvOz6FXSRkO BsUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="NcFz/Jrz"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u7-20020a056a00158700b004c3d9ff908fsi2151290pfk.260.2022.02.25.08.02.02; Fri, 25 Feb 2022 08:02:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="NcFz/Jrz"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241180AbiBYNXN (ORCPT + 99 others); Fri, 25 Feb 2022 08:23:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241203AbiBYNXL (ORCPT ); Fri, 25 Feb 2022 08:23:11 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FC1B1A7D93; Fri, 25 Feb 2022 05:22:36 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3674BB830AF; Fri, 25 Feb 2022 13:22:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5DB5C340E8; Fri, 25 Feb 2022 13:22:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645795353; bh=BE4hrEf++LTFDnQPp/ZoaVBPWw8PZwKwJBycLMFea9E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NcFz/JrzExXH97+JJ7qlsESz+8CuhDSU/01BWfkr2ImhObWUjXNILKNFnuPBT3RYr xQUTU069umQyMHFkRpY1lypH2KDkkdH74NhUmrGCkCgG2MqWGj4c2pLwFk6/3wO4NQ kKuHUtMuKJXvSlv2NP4LODYTOA6KzwMfyDxF0IuUpm/CSidjJeciTDNVPH1fi6NEis 7XwSjgw7OvVT6Gpf+fzvGS6c8ilhPBaNUvePC8w0fjPUJB14Q4gASJ47oySeSZKv2n GrqIzDNaTG5bKUXDVkXjhPAQgH6O7y8CobhbocBxxrcrUVmBJmGG2n0Bo3XtB6rAe3 b9QfbpHj6Toww== Date: Fri, 25 Feb 2022 13:22:29 +0000 From: Mark Brown To: Yun Zhou Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, ying.xue@windriver.com, richard.danter@windriver.com Subject: Re: [v2][PATCH] spi: use specific last_cs instead of last_cs_enable Message-ID: References: <20220217141234.72737-1-yun.zhou@windriver.com> <4d621283-2a48-35ec-2131-1471a6b94c51@windriver.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="M58BZv/y8CRnoqht" Content-Disposition: inline In-Reply-To: <4d621283-2a48-35ec-2131-1471a6b94c51@windriver.com> X-Cookie: I smell a wumpus. X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --M58BZv/y8CRnoqht Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 25, 2022 at 04:22:01PM +0800, Yun Zhou wrote: > Do you have any comments on the new patch? It just fixes the > regression introduced by d40f0b6f2e21, and it no longer affect cs_change. Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so=20 on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled. --M58BZv/y8CRnoqht Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIY2BQACgkQJNaLcl1U h9Da7Af/XNWdUV3sNmp0eF542/LjeEc9cNbzIdfJkQyNhxi6m3W8ca3XHaQUTfLJ w/8G3q5uIw6vN0wjHSFkof0S0j6fSdONKL3t6z62o6mBcfPTtTCkZVnnmd5iSOAK yDWXG90BvorEMgp81w1DfEz7s0GYUOZOgaA8iZseNRnnnNyq8v3Dcj98nukbXQrr ou3RepnK31XKIOXN4yJwNyEaCIwPkz7knMdjbBSuBVQYxPxaIno3FC6CBxuDAqXV lTDKhQLdUFQlOT2QlpSMjXBQWzein7gi4W7fRRH12ES81M3qed9CcwH9uzF2WIvU 5Jlet0uvsCoN6+IQuji3MnYz8XfuMQ== =7NE0 -----END PGP SIGNATURE----- --M58BZv/y8CRnoqht--