Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <28c71b3c-2f96-9962-22fd-eb707346a3c4@intel.com>
Date:   Fri, 25 Feb 2022 17:35:42 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.6.1
Subject: Re: [PATCH] btrfs: Initialize ret to 0 in scrub_simple_mirror()
Content-Language: en-US
To:     Qu Wenruo <quwenruo.btrfs@gmx.com>, Qu Wenruo <wqu@suse.com>
CC:     Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
        <dsterba@suse.com>, <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        <linux-btrfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <llvm@lists.linux.dev>, Souptick Joarder <jrdr.linux@gmail.com>,
        kernel test robot <lkp@intel.com>
References: <20220220144606.5695-1-jrdr.linux@gmail.com>
 <0a2e57ad-2973-ea01-ceda-3262cde1f5aa@gmx.com>
 <CAFqt6zZsv+bMwbdqrcOMCZE08O_q7DGa0ejVAbokLybsSch5fw@mail.gmail.com>
 <a1d126df-a5ee-d47d-bfaa-95b3b221e41a@suse.com>
 <b2536c4b-bf0f-a2ff-58cf-ef7d17acaf48@intel.com>
 <205e5941-6ae0-0482-b083-874daf0e5a46@gmx.com>
From:   Yujie Liu <yujie.liu@intel.com>
In-Reply-To: <205e5941-6ae0-0482-b083-874daf0e5a46@gmx.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2V5Q1ZKS1ZMc0loV1Z6NU5zczdrdGFOMEc3c01YVXd2Nmt6b3Q2RnVhVUZH?=
 =?utf-8?B?VTF6MUJzTzl4N3lwQzd6TkFaUmxOL3VDUnRoa2N3bTQ2ZG1PRDhpMGJlR2V5?=
 =?utf-8?B?alpzcm03SXdkRlowSVpPSVBBUFgxYU1oRXJ0R1ZJZWh4Z21tMUxocDkwcGxl?=
 =?utf-8?B?S0xyNEFxZkNyYU1GeVNFU1o2Wk1CS0NtQ2tEVzQ5RDUrNG9kcUJCLzY5czQ4?=
 =?utf-8?B?cldwbFl6Ny9Ia0YzNjViNEdZNjVXMjJEaTJvWS9PaDlGMzFNNzlqNkZselN0?=
 =?utf-8?B?K3p2WHJ2QXNvM0ZWOGVZRnNpT3EyWnhwcDFuUWNVQ2l1L3VWeThTU2NZVU1s?=
 =?utf-8?B?b3c3S3VSOVpUZ1hBMzlpRUJjK29XU2x3SHEvNDdxTWpZczBoVnZDMldKV0Vz?=
 =?utf-8?B?dEo0SXZYenVpb3h1R3FMbXA4MG53YzVHa2Jub2JjcThBazdlVExadG5DM2lC?=
 =?utf-8?B?dTQ1MS9VSVVMNm1Mei81OXRramFEZENIeEVTSHZLS1ZyWDhWUUJFYjRna0dC?=
 =?utf-8?B?MnFwSHhCWlFZTndBT3ErRlpOSmxRa1B3QWdkZlREajlyK0Zja21VblZYZEUr?=
 =?utf-8?B?SmlJUjdhemVqc3BFc1YvNGJMVC9Fc083TjdpcFoxK2xJbEQ3dm1ZTHM2Y1d4?=
 =?utf-8?B?a1BEdjZWV0xqa3JaTXJjRHpvbFhOMWlzNnVkVGxCOGNMSUM5RDdGV1RUaHkx?=
 =?utf-8?B?ZGpOS0JndjAwbDQxa1hCdVM2MWFEaFF3UUlDMW80MUdHWWtadyt4YVdWMnhC?=
 =?utf-8?B?dTJna1FseVU3QlV6QjZ1UnVsUC9MNDhFYzE4elBVQUZ5SC82bWI2T29GVXFM?=
 =?utf-8?B?Q245L2QxVk12d3JmMlEwYlpwdjlsVENtSFhDM2oyWmFyem9LUVhzVEJNWGhW?=
 =?utf-8?B?ditLUW4vV3VvVXFnWlplWkFQeWtJQkhuSEZvb1hjb1hhbnVHblVpNlNXWjRu?=
 =?utf-8?B?L3QwZUovU2hWbFUyUU5ULy9FYTI0eE1lblFhY1lzak0wMStQZjRnd0RDM3I1?=
 =?utf-8?B?Ni8wdjl5a05YRWdtaEZzYlN2QVorV0tMM3kxWFgrQ1ZpTmRCYkVLd3VNYWdV?=
 =?utf-8?B?YWJyeXdxZXZtWmRQbkpxelpwNHh2VlJJdXR1UWJrMitsWFBIRDVQQU90ZDZw?=
 =?utf-8?B?MWpqWHV2THMrUlBYYkhnSW5zQUI3NGVvanltSmlDcy9pcEVaRW0wQ3ByY0RI?=
 =?utf-8?B?ZG1UOUxXUE01Z0k0SDZPUGp1bkxGZ081bXdGcVhsUkRRaDhrQUxNMWlYQ3BC?=
 =?utf-8?B?OW83WTJxZFdSYWp5bDF6RVpwRjVKY09kNUpsakczYXI5UWxpb2pTTmVCZmZl?=
 =?utf-8?B?V0w5L09OWk84WWM5V1lIY29LZzFmN1hobXBBSlB4SWtNNTVkNnlJWXVhV2d4?=
 =?utf-8?B?d1hmR2pidDB4MUZKWkxIdTFzKyt2RTIrRzAyR3NLeXIvL2hiRTUxZWQ0ME15?=
 =?utf-8?B?MGZNcWNzN0hxKzBYR2k5NXB2Yk9xdGZkekR5RWtmZGtUaXJtU2FhNldQSjh4?=
 =?utf-8?B?eGYwdkM2a3QrTVErdFZIOXpqVUFWc3NURjRxTFJmSkZjRlhjNkVDdS9TYXFF?=
 =?utf-8?B?Y3gyQzFVV1BvMEpuM3VLbkF3TWVrblJwYUx1U2llcnV3Nlp5ZGpPUkpSTGwv?=
 =?utf-8?B?OWNRZ1pzc3JraWFzMHFiVjhHb24wVjVBTDM1MDBaayt5U2NoNzVIeGtmNURa?=
 =?utf-8?B?QThHL05vVXVkK1lqbEVoaFZuUjN0Vm1CYVpQWkt2VVFqR043Mkx3REUxekJm?=
 =?utf-8?B?aTgvY2IycVdPZEFycHcxN3BRNVFhc1lWOTRKUkk1bUw3VUt6NmJYZDlyNlBV?=
 =?utf-8?B?NWEyeTRta2NmeXdWdERDUlBRWmtKUmdXcEZ4eEJBaXFQMFBPYjZYQjRlTERU?=
 =?utf-8?B?OGVENnFzSEQxd0VZY2hQNXUwaGJqWU9QYitFVFdqa1JrL0dKWVhiUy9LWEdr?=
 =?utf-8?B?RVc3TFJ1bkY3U1dsU2U2Y2hhTGVjZW44WjQrbEhKTDlyT0kvU1QyZy9OdUJu?=
 =?utf-8?B?K1NFUktxSDZLcWNxQUhRSnRkME1sM3VxbWsvRUI4WWxVbFUvSnl4U0l3b0x6?=
 =?utf-8?B?UzVubTlHbWtJTTlvWEZmck56dzlCTmlpeThvMmluWGdxWFFEaXhmSVF4NTdW?=
 =?utf-8?B?enZ2Y2xWZEd5QnI1cFNINUVnb1AyYzd0UTNKY2c5Tll0clBJdVNCejhLYzlR?=
 =?utf-8?Q?cW3rKlZtEYOcSpDfMprVukg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ba70e094-f666-4541-e270-08d9f8423599
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5598.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 09:35:50.4817
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sgfcS7XLi9S+xdKBkKcgiTPAZE3XS3F2D0Vtt1hJ1PLuG2GN+AH2v0qf6v9J4ci1AH2f2b7kNOIxsenTvmE4Gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4618
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Qu,

On 2/24/2022 17:56, Qu Wenruo wrote:
>>
>> For clang analyzer reports, usually we do internal check firstly. We'll
>> send out the
>> report only when we think that it is highly possible to be a true alert.
> 
> BTW, do performance benchmarks also go through the same procedure?
> Yes, runtime reports(including boot test, performance benchmarks,
etc.) also go through internal check procedure, but compared with
build issues, sometimes we are not that confident about performance
regressions.

> Although your bots are awesome at detect compiling warning/errors,
> sometimes it's not that straightforward to reproduce the same
> performance regressions.
> 
> So it may be worthy some extra steps to verify certain performance
> regressions.
> 
Runtime issues are much complicated than build issues, the
performance may fluctuate depending on different software and
hardware environment, so not that straightforward to reproduce.

Please feel free to contact LKP folks if found any false reports of
regressions or any issues in reproducing steps. We can learn more
experience from user feedback and keep optimizing our work flow to
improve the accuracy of catching real regressions.

Thanks,
Yujie