Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <76abe7a9-4e75-b91d-8428-a4df1f6d97b1@wolfvision.net>
Date:   Fri, 25 Feb 2022 18:08:01 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v1 6/8] usb: dwc3: add rk3568 dwc3 support
Content-Language: en-US
To:     Peter Geis <pgwipeout@gmail.com>, Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Heiko Stuebner <heiko@sntech.de>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220225145432.422130-1-pgwipeout@gmail.com>
 <20220225145432.422130-7-pgwipeout@gmail.com>
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <20220225145432.422130-7-pgwipeout@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2dzUGxLaGd0M0owcHZ5THRNa09KblZCMlJMZUtQUGZsRGp4ZnJYeUNiSVlh?=
 =?utf-8?B?bUJheXJCWTFWTUswd3VJWWphU24xeGh0QzAzWEdnRHdsM2pUYWFzbjREZlR5?=
 =?utf-8?B?eXpPUzNEOW90U0JkN0pIemIvQUhUWWUxV0hOVzk0a1RZZWREUnVJUy92d3Fh?=
 =?utf-8?B?WWIzSWJzbERtQkhjbnR2dUhJU1JtS2RpbDUvbmFXdGI5N1FaUnZrY2taK3JI?=
 =?utf-8?B?OWpTL2V5VDAySjE2OG9URDVZaVFzdzhrWWMyZStkVkxzU0hDdjFNS1pIblNp?=
 =?utf-8?B?VFdyR0NHMG80ZUs3U3VLMjFBNlc3ckxVeG1UVFFVZkxUV1V3cEFYZzdpNXho?=
 =?utf-8?B?dTZoNkpsWk44UDZ2TDhmc2VhUVFoUDFBcWo1YytKZlVNTTFSK0plNElCTDc1?=
 =?utf-8?B?SmthdTUzQWNSaHl6WTh4bnlpOElOQllRbzlFMU1DOXNCTGJKN1pEZmx4Yk94?=
 =?utf-8?B?Uzh5cXE3c2pZRHZGa3Y2cUl1Ulp0QW9OVnI0cWs0MEdKdUdEYW9tOGtFa0c0?=
 =?utf-8?B?TmwyRmtTTWg2WVowZFJ1VjdJZm83dERuOHZGNm5uaWwzbjFPSVZqLzRObDlh?=
 =?utf-8?B?U1RETzlNaHRsQUF4R0pjNjFzWWF5a0NMcndtcHU4RkEvZno0K0kwbkdOeFBG?=
 =?utf-8?B?LzlqVDM4azVZYnk4ZzlyeFhCTEdJRnUzcGNycGdKTlk5eHVSUnkwWVoyQ2RW?=
 =?utf-8?B?ZjhiSUU2dFo3QS9saWg4eUV6eHJMeWxQZ2pMaUdsVUdEUFZ3NU43aFRHb3pJ?=
 =?utf-8?B?S0tlUlJzS1duQ2JZMVZFeFFKelV3Z01iOGZ1cWFNVkFpSE9VMFcyeWxVSHdC?=
 =?utf-8?B?SnIwd01ocWduam1ac0NPYlI4dUVUbG9PcDcrZ2o3eVZWUFRqUTBGQkFxSG0w?=
 =?utf-8?B?eTJqeEFLTUc4aENWQ2dGajBQVDllNnhTMDNmeFVhYnlUMXJyM2ZWdjQwMTAx?=
 =?utf-8?B?ZHRIRlRYNUNVaWQ2NHRZV3RPVmZIdzRPZEpZVDI0U215WUhPWjI2a2RvOWRB?=
 =?utf-8?B?aUNSUkYvM0IyR1cyNlNkNVJjRTdmVXZKWFBnVW5nZnpOektiL0wza01oZ3Ur?=
 =?utf-8?B?a3ZFZ1dwS0kzSTNPRXNzdytKeU93QjJsUHgwRGZIZEptZTl5WnJpY0Fmbmdp?=
 =?utf-8?B?WldESzA1cXpwVkVsV0NtUVAyNENDcmZIVHM1RjVLVjNSRnBUelJVUjVNWm1n?=
 =?utf-8?B?NzdTMU53TEJEOTRoVGhtcnZ1Q0tBOXJuaUUzK3VQRFdUYzF6aEd4Vk5xVnU5?=
 =?utf-8?B?ZkduUUIwdCtYS2ZqSmJGZEFGbHpRdHJtZ2NmUGZNeG1GUXF2VlNJaVdsMGZ5?=
 =?utf-8?B?bDRvbnZqSk1sVWJpMFYxSm44R2Jnb2FaT2pQbUlJczdDcTJ5ZVY5TWdUZ3JL?=
 =?utf-8?B?VHRHOFY4UHJwOVUxVE1NUnNsSCtDcGVOazQ1ZEtYSHIvTW1yOFNQRW1sYVBw?=
 =?utf-8?B?UVRnVDlhS2xYdG9RY21nRTlXUlgySDZPZWN0SUR2WEJtc1BoNnJRV01pNFhl?=
 =?utf-8?B?WWJSN282ZzRwSnBGVEZtbndOck04eW5vYU5mcFZTNkZFcUpvc2Uza1AvRGZ5?=
 =?utf-8?B?Njh4Z2kvTUx2S2RRMU81VGVvM3dlZlc1S1RvajVwbm1GR3VkdXpLbW00TCtr?=
 =?utf-8?B?cDdBTDYyNE5MeUt0VHZBRzdYaUVoZUpLNit1dTdFcElFWFNHNlhmVHNLVmpm?=
 =?utf-8?B?Z2hUREpBRlNEaXVjdS9IRXEyUnhaYnN5ZzhWcDdOdWFRVEdHbS9WVzdhZnhh?=
 =?utf-8?B?Y1lTbUJINWtmZ3NLS1ZaS04wZnlma1ZvTFlPNE91dlRsQlp2R20rYzFycy8v?=
 =?utf-8?B?MVZ6OW1iM3FVUTNMZ2t6enFoUmNhbFkyaUxVK0NyS0s5VlR2eDJjZWQ5anh5?=
 =?utf-8?B?Zk0zblN4d0x6bHd6MDE5T1d3emFWUXBpaU5WakxUWmFPVDdhMUxuNVQxbG1R?=
 =?utf-8?B?Nkgyd20yVWZsZWFFK3J1Q0h1UXFtTGhCcVBSR2JmaTZpNUxNTkNFNGVrVS8z?=
 =?utf-8?B?YTlBZHBFc2E1WjdyYTBIcXNFUWNnQ2w5OGlVODB3blhoQVljWWl2WEZxaG82?=
 =?utf-8?B?akpNWld0YnNNK0R2dDJUa0F1MDM3Wmpsek5Qbi9GOG1HZGtxZzJlUkYrREox?=
 =?utf-8?B?T29uMzZ2eTZ2UXh0UmRpSEVqbUM0YTBTRHdraElnWGFBMWxiZDV6VFlaTE9C?=
 =?utf-8?B?RVhLOTR3YS8wQWVVVTcxNmZ2Qks4Y2l3NVRIcEtsWGo1UjNRdllVTUFucEln?=
 =?utf-8?B?SGVRcXk0b0JrMnprSW83bmU4ZVA5WmEzVHEwb2d4azRJRitid21wZlZGR3Rv?=
 =?utf-8?B?LzR0WktFbmFtMEFzTUpPSlNzcU93ZUdUTk1FTUZFSzdVZncwRzNtcmIxNDlv?=
 =?utf-8?Q?EkunpPKOP3Y9JLWM=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: f4931e7f-6230-45ce-db0f-08d9f8816280
X-MS-Exchange-CrossTenant-AuthSource: HE1PR0802MB2426.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 17:08:03.8123
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4N5lIWdQ0PQAYO7+0hlJUJfgN8gTjfczDupBMsTbVPenSwqCj9wdQ3YOiVDybcxJANxcORAYoXBEsXiX3Cxi32CXp7AU2eFKsUl6cGCryIQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5376
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

On 2/25/22 15:54, Peter Geis wrote:
> The rk3568 dwc3 controller is backwards compatible with the rk3399 dwc3
> controller.
> Add support for it to the dwc3-of-simple driver.
> 
> Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> ---
>  drivers/usb/dwc3/dwc3-of-simple.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index 9dc6295df6b1..1d52a261af55 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -49,7 +49,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
>  	 * Some controllers need to toggle the usb3-otg reset before trying to
>  	 * initialize the PHY, otherwise the PHY times out.
>  	 */
> -	if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
> +	if (of_device_is_compatible(np, "rockchip,rk3399-dwc3") |
> +	    of_device_is_compatible(np, "rockchip,rk3568-dwc3"))
>  		simple->need_reset = true;

Maybe read this value out the match data...

>  	simple->resets = of_reset_control_array_get(np, false, true,
> @@ -176,6 +177,7 @@ static const struct of_device_id of_dwc3_simple_match[] = {
>  	{ .compatible = "hisilicon,hi3670-dwc3" },
>  	{ .compatible = "intel,keembay-dwc3" },
>  	{ .compatible = "rockchip,rk3399-dwc3" },
> +	{ .compatible = "rockchip,rk3568-dwc3" },

... so all future variants that are compatible to the rk3399 can share it?

Best regards,
Michael

>  	{ .compatible = "sprd,sc9860-dwc3" },
>  	{ /* Sentinel */ }
>  };