Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Feb 2022 14:20:21 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Wayne Chang <waynec@nvidia.com>
Cc:     balbi@kernel.org, gregkh@linuxfoundation.org, jonathanh@nvidia.com,
        zhangqilong3@huawei.com, yangyingliang@huawei.com,
        rikard.falkeborn@gmail.com, chunfeng.yun@mediatek.com,
        linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] usb: gadget: tegra-xudc: Fix control endpoint's
 definitions
Message-ID: <YhjXlQJoKzI/9q89@orome>
References: <20220107091349.149798-1-waynec@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="nNcLsEMhhKxQEfJG"
Content-Disposition: inline
In-Reply-To: <20220107091349.149798-1-waynec@nvidia.com>
User-Agent: Mutt/2.2.1 (c8109e14) (2022-02-19)
Precedence: bulk


--nNcLsEMhhKxQEfJG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 07, 2022 at 05:13:49PM +0800, Wayne Chang wrote:
> According to the Tegra Technical Reference Manual, the seq_num
> field of control endpoint is not [31:24] but [31:27]. Bit 24
> is reserved and bit 26 is splitxstate.
>=20
> The change fixes the wrong control endpoint's definitions.
>=20
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> ---
>  drivers/usb/gadget/udc/tegra-xudc.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)

Again, what's the impact of this? Is this a critical bug fix that needs
to go into stable? Or is it cleanup? Perhaps add something along those
lines to the commit message to make it clearer to maintainers how they
need to deal with them.

Also, if this is a bugfix, make sure to Cc: stable@vger.kernel.org and
add a corresponding Fixes: line. Same for that earlier patch.

Thierry

--nNcLsEMhhKxQEfJG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmIY15UACgkQ3SOs138+
s6ELuA//frfkH8KumnsE3c8cVrLkPeCVSZOWkuK/7ye9Eg1ddJcQw/G1e3XdxijZ
IdluDEI4Vvt0F2Fg/saOVlQ2H5pVozQUL4zWWqNs9ZORCW9HZuFVAuWfzAEqT3pT
WY6i2SYq9+AAcZNFGL3HaLGfA5EjMvCjnpDMFEruzaKcOqaab8yFy77E4xxUa9WE
WiBiU3HykF0S7sAOkXIv5g7WmllFZbFetipPwm9WDsv3lyZjg42i0qXKzqzeD/wv
MRPEU/IRxSVXBtUfwWPrQBU71zct8xmTb9WAuhbgddTigWWNEt2Ovu2Yk5Sl5I9n
dXWfmWUkujyKuWs+a+ULy85T/GuJ8XOgLHf1Ew6dL7k6yrPIHyTU3qFwbcdjqEsM
VHuIT8j1OMWI18sVb+0QY6NjsDjwaAgErxUNE3c/oCTf+3JtrfOVBy40zlwr6BN+
PkDhKLESUTjlu3YYRukVmaU47jcMjCLr1SSr+XMfa/byGtXyfe+EGAQ7tIZTwXSa
+u7dhWmKBuW12cZbrGAw1raMdDrUhEkkgSv6c0KqAOeFjOY3XY+ndSQl8+x3I2vV
m/VAQZ4u7RBSYhKQK3vPu6i18o/0yQq920B6gkdg2eQDfbPlLa/Tk6gGLujrV8mQ
xkzo9jSVey6+WQcZ/CZdNy7qYASKI5RfQCDDjtDJwGIzGdUA5js=
=Jn0V
-----END PGP SIGNATURE-----

--nNcLsEMhhKxQEfJG--