Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp423582pxm; Fri, 25 Feb 2022 10:36:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJzNIj4aBrgImzgEj/p1omV7LcMOna8lFqdLdUpdVaT3+4diIoQAbTBdIrj0++xjmo++yX7I X-Received: by 2002:a05:6a00:1251:b0:4f1:2a1:3073 with SMTP id u17-20020a056a00125100b004f102a13073mr8748084pfi.72.1645814206406; Fri, 25 Feb 2022 10:36:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645814206; cv=none; d=google.com; s=arc-20160816; b=rKfiU7N03sQRkN/RvQBbayLLEp3TIotALTHyDE8oirD6jkN2oRykKO2vrH99R/JE5t VnGbjzN/qOOd3bvmTHkQd7aMtx2k3U5BZDBDmldvxAJFv7pE0GQhKEUp2d+oKpGFLFCM 5EQEsltS/PMWyorOyRnKD3DQ6lFFED9w52aLobGX+/JRE/Hxd17LpA8II8qQeXPW5k6n mx0C44HTQ2wdE7gmuW4oX2NUPlhXSqm5CX9kwBZhp0gJa6YPqrLEzuNl+wI73YOkMvbd 9pgjtj+FFUvuZgp0aGmOSoFcfJ17IfHcVvhG1LUDx6pDj6AeuYB8SAHKevzApXTUqpow s7JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=eJa/soHWkTcr+SIUtP+p/SEex2J3SmwxKR2es9BsRNs=; b=wnaSdBrJdp9emYfBJcev4lgdK6dcDLBsjatkigB1Hv5VlcgR1f5XsRpj7pmC6eIBYd 1oUIssT+W6WfwcmL+K1jtf6JesBq5J0qCwQwVycBxJCNDJ3uLXhjF6NE3XjmbUEH3XNX TxriXJ8g/edSOKpHyNEDTbqoHqQWMn5rfW911O8BiCqBEXaB0llO8JMP8gi6RbLoDa07 jhZwLwxOxol753zo1E/QqWw8igw5vjo/XJJb3ioga5TZW758OjadXxKIvNAwVLif+iAL c0GPCkZkXS6hFOjF+9VbYiJX08FA2e6wzCZ6+jKdIH+R4vm75IV1zc0AzkFLkZYw2bFy tr8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q3-20020a056a00088300b004f11ed89dabsi2779486pfj.0.2022.02.25.10.36.30; Fri, 25 Feb 2022 10:36:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236468AbiBYKl2 (ORCPT + 99 others); Fri, 25 Feb 2022 05:41:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239739AbiBYKlX (ORCPT ); Fri, 25 Feb 2022 05:41:23 -0500 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75AAF68FA6; Fri, 25 Feb 2022 02:40:51 -0800 (PST) Received: by theia.8bytes.org (Postfix, from userid 1000) id 2870B447; Fri, 25 Feb 2022 11:40:49 +0100 (CET) Date: Fri, 25 Feb 2022 11:40:44 +0100 From: Joerg Roedel To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , x86@kernel.org, Brijesh Singh , Tom Lendacky , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Joerg Roedel Subject: Re: [PATCH v6 0/7] KVM: SVM: Add initial GHCB protocol version 2 support Message-ID: References: <20220125141626.16008-1-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220125141626.16008-1-joro@8bytes.org> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gentle ping. Any comments on these patches? On Tue, Jan 25, 2022 at 03:16:19PM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Hi, > > here is a small set of patches which I originally took from the > pending SEV-SNP patch-sets to enable basic support for GHCB protocol > version 2. Meanwhile a couple of other patches from Sean > Christopherson have been added. > > When SEV-SNP is not supported, only two new MSR protocol VMGEXIT calls > are required: > > - MSR-based AP-reset-hold > - MSR-based HV-feature-request > > These calls are implemented here and then the protocol is lifted to > version 2. > > This is submitted separately because the MSR-based AP-reset-hold call > is required to support kexec/kdump in SEV-ES guests. > > The previous version can be found here: > > https://lore.kernel.org/kvm/20211020124416.24523-1-joro@8bytes.org/ > > Regards, > > Joerg > > Changes v5->v6: > > - Rebased to v5.17-rc1 > - Added changes requested by Sean Christopherson > > Brijesh Singh (2): > KVM: SVM: Add support for Hypervisor Feature support MSR protocol > KVM: SVM: Increase supported GHCB protocol version > > Joerg Roedel (2): > KVM: SVM: Get rid of set_ghcb_msr() and *ghcb_msr_bits() functions > KVM: SVM: Move kvm_emulate_ap_reset_hold() to AMD specific code > > Sean Christopherson (2): > KVM: SVM: Add helper to generate GHCB MSR verson info, and drop macro > KVM: SVM: Set "released" on INIT-SIPI iff SEV-ES vCPU was in AP reset > hold > > Tom Lendacky (1): > KVM: SVM: Add support to handle AP reset MSR protocol > > arch/x86/include/asm/kvm_host.h | 2 +- > arch/x86/include/asm/sev-common.h | 18 ++-- > arch/x86/include/uapi/asm/svm.h | 1 + > arch/x86/kvm/svm/sev.c | 169 ++++++++++++++++++++---------- > arch/x86/kvm/svm/svm.c | 13 ++- > arch/x86/kvm/svm/svm.h | 10 +- > arch/x86/kvm/x86.c | 12 +-- > 7 files changed, 137 insertions(+), 88 deletions(-) > > > base-commit: e783362eb54cd99b2cac8b3a9aeac942e6f6ac07 > -- > 2.34.1