Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH net-next v3 4/4] net: tun: track dropped skb via
 kfree_skb_reason()
To:     David Ahern <dsahern@gmail.com>,
        Menglong Dong <menglong8.dong@gmail.com>
Cc:     andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
        daniel@iogearbox.net, davem@davemloft.net, edumazet@google.com,
        imagedong@tencent.com, joao.m.martins@oracle.com,
        joe.jin@oracle.com, kuba@kernel.org, linux-kernel@vger.kernel.org,
        mingo@redhat.com, netdev@vger.kernel.org, rostedt@goodmis.org
References: <edddb6f9-70d1-4fcf-5630-cbdfe175e8ee@oracle.com>
 <20220225055732.1830237-1-imagedong@tencent.com>
 <41d055e3-9d88-bc43-cb3b-bd67ab071e11@gmail.com>
From:   Dongli Zhang <dongli.zhang@oracle.com>
Message-ID: <ce8e438b-b077-6cbb-358a-3ffa5cdeb574@oracle.com>
Date:   Fri, 25 Feb 2022 08:49:10 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
In-Reply-To: <41d055e3-9d88-bc43-cb3b-bd67ab071e11@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?blVxTHpzbSs0MHdvVzhQaGFKODM1YjFmQVBjQnJNTFl4ODRtdDM1SkpoUi9v?=
 =?utf-8?B?VWsxR3VDV0pUSUpCemgyaGFOS0cyRXpwV2lWRkNnc29YQjc5SnhtZnUyVTZl?=
 =?utf-8?B?bEJXZEJIcG9Mb2dpcXlQNlEvRSt4WXlYOEJVMEtoc1d4a0ppYkc4VzRxMzlt?=
 =?utf-8?B?bEUxWlV2QXhiWE95YkF2S3pSNHJMYXI4MUgvaXdEUFFXbmpTejVoMWpqZHJS?=
 =?utf-8?B?ektVeEhDT2IyRWNzcUljU1VNYmdrY1h0a0FhWUU4OU5DblB3TndZMVFPbFN5?=
 =?utf-8?B?aXJaQ0ppUmhkc01EZS9OVHliaDZaRVJCdXNYOEliOG9zcW9rT25pb1ppYlVr?=
 =?utf-8?B?YzBTeEV5cFdxV3QxY2dMZXowMG42MVBVeFRNd3ZWSTVSSGN1dVV1OXNHUzlH?=
 =?utf-8?B?aHFUVVl0ZXhnTU5OeXlwUVRRdThKZXdTejRBYzlBOUZwcUFkcU1zUGdjOVl4?=
 =?utf-8?B?OTVZc3R6ckxhOHlNOFJzQjhza29iNlZINkN2QXIvNHBQczlBcHN4SlhMdWtp?=
 =?utf-8?B?RVNqelNhSENtdmtGeHRCaWlYN1lyempvQXNtSzVJMGtuZTVSTFdXc2FnWEtx?=
 =?utf-8?B?WjJjWnpndUJtK1o2M001bi9Ta2Y3VGRBWkd0MlQzWXNrMndUalZOMmZGVnFi?=
 =?utf-8?B?NGtzWTM0RHdHb1NUQXpPNm9sTmkzTk1RdW1oVU02eSt3bVBhSjc4VUVpcmpq?=
 =?utf-8?B?YS9RUkJUUFp6UllXVEFJdmhhWmkrRVg3Sm9HTGRsSFpoYmx2UUFRZWNnc2Fk?=
 =?utf-8?B?UlhVb005K1ZpWEZ3emQ5WFk0c0lNZUl2UmovbG4vb2xOMkw3amZXN1J4UUo1?=
 =?utf-8?B?cXlaeTVZRTR5VDN5Y2gyZ2t6M0dsMnlTTWhjRXFncUcxWFhuTGtCZmFuQXow?=
 =?utf-8?B?MFdRT3c2TTEyVUtrWDJ6RDJvTUpTckw5eTZLa2x5empicGtDSXBsMGNiK2Mv?=
 =?utf-8?B?dmg3WHlNbjFPRVpYRVNxckJOdzYyRHY3WkdXcG1sTzJkczEwamx0WXp1Z2ZV?=
 =?utf-8?B?b09DWHZBeDNkcG9NRlF5NUdIeEVjRkV5aFNLdmR1N0hNWWhMQ083dG8yYlVM?=
 =?utf-8?B?Y2pQOEpseDExelhTM0cxczRLT2JINjlLVDg2N014cWJCSW1zYjRScFdJbzNG?=
 =?utf-8?B?WkVDMDkxUnh3aHVzRE53MmxxSXNzT1NuQTBIakJiSktxQUYxMjIzQUZwK3pn?=
 =?utf-8?B?clVSYUF0L0pnMkkzK1EzS3NGRHpsZTFiNDFqdEM4TlVwbHNiSldsMjZra3p3?=
 =?utf-8?B?SmptQXBwSnFNMmFuM0p5SHZTdnhQT1cwUHppUFZoMjcraS8zSE1TS1owblk3?=
 =?utf-8?B?cy9aaGx6VHRiVmtoKzczOW1qWHNnZVdOOTdCM1FHM0xDNElnbURPd0gwak55?=
 =?utf-8?B?a0VtUFJRbkliSGZRQnJEQ29aRUlKT2M2RGVVTVR5b3E2djZKNEszbm9mbWov?=
 =?utf-8?B?eHR2SkhKdDNHL01taVRlR1lLQjBXOVFKVGlaN28xeFhORzQ4NmJ2Q2xyb1I4?=
 =?utf-8?B?cS9uVW0vMnhtdXVscS9ZT3VHaEtyVEt5S3dEM2VhSUJyNjZ0UFhRd2pJditw?=
 =?utf-8?B?T3RSMjIvNVl2UXJFVzdhUVVwR2ZaME1WUnpBVDdCM3Q1UnR5djY1anY5SmxF?=
 =?utf-8?B?VlNTaWZkWVh3cXFBaldUb25TTXRBdDZhbE9xQi9NTmtLSVNPK3NSRnVnQS8x?=
 =?utf-8?B?RytydjI3YTB2d1pnZ3NySmUzN2cxM1V5bkJwdkUvOXhuNVhaUld2Z2lGMmFv?=
 =?utf-8?B?bHY4UElZdDBlMkRNZlFHRlp5T3RQL3o1eHRmWG0zbnAzWmx6TGp3bmpSMGZx?=
 =?utf-8?B?b3JPQW5hMlpjZEZmQ0llbUFPU2NjTVhIR3R0cXAyRFJvWUtjaTZoWUVOQW9G?=
 =?utf-8?B?enRnT0l1Y0I0cDlJclFaWXM2eTZZRlp6MWFLQzFjZ1Vub1UyVzlla0FBdmhY?=
 =?utf-8?B?Rk52RDdpTEdhalQ4QXJUYnRCamNrVUhlNCtPTVJVVXl3YlJ5Z2o5eFJaeVBN?=
 =?utf-8?B?bHpELzVEbzhXMTlaTlZ2NUlHbGRVN29RTzRqc0sxbzVLdm9yakc1bFYxV1d3?=
 =?utf-8?B?MHRQU0RiY0tOS3E3WXh0TlJ6ZzRWY3dKNVByUDcyOW0zWDA5S3Q5VHk3RGtp?=
 =?utf-8?B?MEtPZTJZVHlMcVdUN1U1Y20vbUg2QzZtZE1XWllkWTRycE9vdVkwUUZMRUdh?=
 =?utf-8?Q?Got9bs1hfnjky8rB/TLQtBeVJSUXaenVlQncty8y2oqR?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc7fe082-abc7-4714-7fc0-08d9f87ec18f
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 16:49:14.8485
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lZimnXxq2Papc6RacGKWS/ZSEprHLBK5BzW1YJQnuzyl4x5xI3kwaQdnxbdIQRgw8kSOuXoCs+1iRFQ+usc3mQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3860
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10268 signatures=684655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0
 mlxlogscore=999 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202250097
X-Proofpoint-GUID: qMLfC5ldTTNw3uQA6q5ooA8HnpSp4HHU
X-Proofpoint-ORIG-GUID: qMLfC5ldTTNw3uQA6q5ooA8HnpSp4HHU
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi David and Menglong,

On 2/25/22 7:48 AM, David Ahern wrote:
> On 2/24/22 10:57 PM, Menglong Dong wrote:
>>>>
>>>> For tun unique filters, how about using a shortened version of the ioctl
>>>> name used to set the filter.
>>>>
>>>
>>> Although TUN is widely used in virtualization environment, it is only one of
>>> many drivers. I prefer to not introduce a reason that can be used only by a
>>> specific driver.
>>>
>>> In order to make it more generic and more re-usable (e.g., perhaps people may
>>> add ebpf filter to TAP driver as well), how about we create below reasons.
>>>
>>> SKB_DROP_REASON_DEV_FILTER,     /* dropped by filter attached to
>>> 				 * or directly implemented by a
>>> 				 * specific driver
>>> 				 */
>>> SKB_DROP_REASON_BPF_DEV,	/* dropped by bpf directly
>>> 				 * attached to a specific device,
>>> 				 * e.g., via TUNSETFILTEREBPF
>>> 				 */
>>
>> Aren't DEV_FILTER and BPF_DEV too generic? eBPF atached to netdev can
>> be many kinds, such as XDP, TC, etc.
> 
> yes.
> 
>>
>> I think that use TAP_TXFILTER instaed of DEV_FILTER maybe better?
>> and TAP_FILTER->BPF_DEV. Make them similar to the name in
>> __tun_chr_ioctl() may be easier for user to understand.
>>
> 
> in this case given the unique attach points and API tap in the name
> seems more appropriate
> 

Thank you very much for the suggestions.

I will add below in the next version.

SKB_DROP_REASON_TAP_TXFILTER,	/* dropped by tx filter implemented at
				 * tun/tap, e.g., check_filter()
				 */
SKB_DROP_REASON_TAP_FILTER,	/* dropped by (ebpf) filter directly
				 * attached to tun/tap, e.g., via
				 * TUNSETFILTEREBPF
				 */

Dongli Zhang