Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3abfc379-d353-6caf-0cf0-83559a460be6@linaro.org>
Date:   Fri, 25 Feb 2022 18:41:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3] drivers: thermal: tsens: respect thermal_device_mode
 in threshold irq reporting
Content-Language: en-US
To:     Benjamin Li <benl@squareup.com>
Cc:     Amit Kucheria <amitk@kernel.org>,
        Thara Gopinath <thara.gopinath@linaro.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Zac Crosby <zac@squareup.com>, Andy Gross <agross@kernel.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>, linux-arm-msm@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220120200153.1214-1-benl@squareup.com>
 <422bd780-354d-d4ac-7b7a-8060325fc13e@linaro.org>
 <CACOsgWZ7KFSqC21sSq7hGYk_g2RoKTPPfoYQwcWmwCNSx5c-YQ@mail.gmail.com>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
In-Reply-To: <CACOsgWZ7KFSqC21sSq7hGYk_g2RoKTPPfoYQwcWmwCNSx5c-YQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 25/02/2022 17:46, Benjamin Li wrote:
> On Fri, Feb 25, 2022 at 6:02 AM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>> Some drivers that support thermal zone disabling implement a set_mode
>>> operation and simply disable the sensor or the relevant IRQ(s), so they
>>> actually don't log anything when zones are disabled. These drivers are
>>> imx_thermal.c, intel_quark_dts_thermal.c, and int3400_thermal.c.
>>>
>>> For tsens.c, implementing a change_mode would require migrating the driver
>>> from devm_thermal_zone_of_sensor_register to thermal_zone_device_register
>>> (or updating thermal_of.c to add a change_mode operation in thermal_zone_
>>> of_device_ops).
>>>
>>> stm_thermal.c seems to use this patch's model of not disabling IRQs when
>>> the zone is disabled (they still perform the thermal_zone_device_update
>>> upon IRQ, but return -EAGAIN from their get_temp).
>>
>> What is the concern by changing the core code to have a correct handling
>> of the disabled / enabled state in this driver ? (and by this way give
>> the opportunity to other drivers to fix their code)'
> 
> It seems fine, is that the preference? Updating thermal_of.c to add a
> change_mode
> operation in thermal_zone_of_device_ops?

I'm not a big fan of this duplicated ops structure but preferably it 
would be better to put it there (except if you see a better way to do it)


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog