Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <919a0564850fbf4768e9d98c9beba60cc736077b.camel@pengutronix.de>
Subject: Re: [PATCH] soc: imx: imx8m-blk-ctrl: Fix IMX8MN_DISPBLK_PD_ISI hang
From:   Lucas Stach <l.stach@pengutronix.de>
To:     Adam Ford <aford173@gmail.com>,
        linux-arm-kernel@lists.infradead.org
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-kernel@vger.kernel.org
Date:   Fri, 25 Feb 2022 17:58:55 +0100
In-Reply-To: <20220225161741.395505-1-aford173@gmail.com>
References: <20220225161741.395505-1-aford173@gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Am Freitag, dem 25.02.2022 um 10:17 -0600 schrieb Adam Ford:
> When attempting to communicate with the ISI, the system hangs.
> Through trial and error, it appears removing the two root clocks
> fixes the issues.  Since IMX8MN_DISPBLK_PD_ISI enables the
> pgc_dispmix, and pgc_dispmix enables those same root clocks, it should be
> safe.
> 
This doesn't look right. Why would this make a difference?

The only difference is that those clocks may be disabled at the end of
the power-up routine when they are assigned to the blk-ctrl domain. If
ISI communication hangs while those clocks are disabled, then that is
more of a hint for a missing clock enable on the ISI driver side than
an issue on the blk-ctrl side.

Regards,
Lucas

> Fixes: 7f511d514e8c ("soc: imx: imx8m-blk-ctrl: add i.MX8MN DISP blk-ctrl")
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
> index 122f9c884b38..cacf379aef80 100644
> --- a/drivers/soc/imx/imx8m-blk-ctrl.c
> +++ b/drivers/soc/imx/imx8m-blk-ctrl.c
> @@ -574,9 +574,8 @@ static const struct imx8m_blk_ctrl_domain_data imx8mn_disp_blk_ctl_domain_data[]
>  	},
>  	[IMX8MN_DISPBLK_PD_ISI] = {
>  		.name = "dispblk-isi",
> -		.clk_names = (const char *[]){ "disp_axi", "disp_apb", "disp_axi_root",
> -						"disp_apb_root"},
> -		.num_clks = 4,
> +		.clk_names = (const char *[]){ "disp_axi", "disp_apb" },
> +		.num_clks = 2,
>  		.gpc_name = "isi",
>  		.rst_mask = BIT(6) | BIT(7),
>  		.clk_mask = BIT(6) | BIT(7),