Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Wan Jiabing <wanjiabing@vivo.com>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jiabing.wan@qq.com" <jiabing.wan@qq.com>
Subject: Re: [PATCH] lib: maple_tree: fix boolreturn.cocci warning
Thread-Topic: [PATCH] lib: maple_tree: fix boolreturn.cocci warning
Thread-Index: AQHYKhFTJ75OJX6FSEy2/owFJii3WaykWd6A
Date:   Fri, 25 Feb 2022 14:50:25 +0000
Message-ID: <20220225145017.32ev2rjtf2b673rg@revolver>
References: <20220225063101.891725-1-wanjiabing@vivo.com>
In-Reply-To: <20220225063101.891725-1-wanjiabing@vivo.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CMgtcrnMz/6GlsrIXk3XpzSrmjRhKgBsXacNzWeWp8/CarRQ3Uexnc9ySci9?=
 =?us-ascii?Q?YOInda0QuTX9bbeClsycud9IoG6gRr9q1DeIWJM5zNYgbX4jA/Ws3LrrmOJ6?=
 =?us-ascii?Q?M8DuLXbwIFr2pLZriOZvG9CuDXTnyU8JuKUrEwVq0eGijdkJuydXXP3kKmRp?=
 =?us-ascii?Q?fw8PZCVAKMn1nRHmtRIZ9XWWMwGUFedmZtuHRG7oP3EdHaJpLSBQOmBKDU24?=
 =?us-ascii?Q?jPZas5AIqzWlAdFv0/AGCKviWsSrtoNxp8w9x66yOV7GBwYQg9rjC8gZsqGl?=
 =?us-ascii?Q?K1KmMbHbbLUcGqqj1nZqN7oyx1yKmuo55ZRL6e3x2WDdup08le+ZBsRyQtB8?=
 =?us-ascii?Q?RXSJaUtHFQVfeBJxlAlQQfZCBu1emqLA2DO7lt4c39vH7lzwcDxabmHWPHDy?=
 =?us-ascii?Q?RWkR2q26Z/3zDxxERR83QTu4BGdPraxw8E2K83L77XRH/hcdV+xsprIEE4uV?=
 =?us-ascii?Q?q9RON0fK/U3ygwp9fkKqGJAU5wHPQHCmCCzCmjezbdulCBsQVuoJDxoFTtaI?=
 =?us-ascii?Q?/A/U4/UJErG/Tj0GGAqwlE2ebP5Qu3CrKLPxGbDJGoZIjH63q07jA6TfjfbZ?=
 =?us-ascii?Q?CkaL0aLdxT9BNvc2cb/+tfS1gaHOQZdjAhVIvGksZYLdY8T1wJ6n17hqeH/u?=
 =?us-ascii?Q?lk19XZJEOzTxlkkqNsVXujYzQbI75KVW0vrqdvNALChfnxVQMPlNjLlWmbzM?=
 =?us-ascii?Q?EAxRw7YhybL8qaG7rUjYZfn+q3G4wPRugw0R+ctywsYHXdraW4JGbLviYUNb?=
 =?us-ascii?Q?NwWFxcS64oYokcN+hEtEO/K71jyp5VT8OaMGT5btKO5rhk5hK90b1thgjTPc?=
 =?us-ascii?Q?zqicxu2Qy3Zm4exMfBJFgBho2aNJl6PQ2q6GapCn79DLEV9ToDbDedLbivzs?=
 =?us-ascii?Q?RdtXmQW/DQ1fSdZSmAyJKwrdXcoaIhf+GakK9C1Owj6z2qeN2PjL89ck1XLs?=
 =?us-ascii?Q?zA/ylD4Y+/PV5yNbn9Wb5W4l+u0nn5OesIxDPvyaulcT4SGizufD9bG3b5Rx?=
 =?us-ascii?Q?OzWC3LJibBNfP5BlrAJ7SbwzKMEI9/zGx6fFxFuSiyODBxm0Ok+z9gcEUegR?=
 =?us-ascii?Q?O+k8n6cUzRBqRGnTctfbAR3XOlKtxFFx4/5rM1RDS+fO7Iwg7+K2YJAHnrar?=
 =?us-ascii?Q?HDkygK34P6sXGCbVMq1lZxr9qoCqIcnXPKhlsATjctuJSEoYIEZT/ZwA+gki?=
 =?us-ascii?Q?NBJw2/0Y8xgk+uMKiD6rC0po7W9LXX6h7pD6BYYeycgW/Cnt5H04PwoAHKBu?=
 =?us-ascii?Q?XZ62hD8Qm9LgxeamnLN5lbKCO/gAGXh1KogE0fCwl6y+SWbA1+rA/Omht2Bp?=
 =?us-ascii?Q?+k17Y1ckorGV8MoEjlHw/uaREMYDPdTicu6DcxiXXhfiIGM3L+OUqTUoqxpy?=
 =?us-ascii?Q?l7NddJOcWldJAhuhNpSHb2SridWJmDKS5txvYv85EYDNOdqWiaZaLqSa1fao?=
 =?us-ascii?Q?/WP9Y+sktVbTheUZFRJZtJ23Y+ma0W3AIR2Z6B9QSJ2LfUuNwfpHQhKhSkdG?=
 =?us-ascii?Q?lWP29jF1jHO0xOArmgZzaNFLUwyidx3d5VZIX39jgvRShDbeuDV2BwGLI4iQ?=
 =?us-ascii?Q?tkQ3WcgIQLJUVEPNIzsfYOTjPlnXSY4OAK9MuDNJzEY43Cu6MmTcrhBL3aFo?=
 =?us-ascii?Q?1dJfcFYVTtA2hjdA0Hud7+g=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0AC04034E4C53B4A85AAB2202B99A1E2@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b35bbfb-bbf5-40fe-d682-08d9f86e286b
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2022 14:50:25.7257
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0Kb/eINXau1NVXo6q3kunrdMmMci3T5DTH3gMb6Tc04oEOtAb/J0VvW42gMm9HRUAf23H+wF+cHRJV/9qfMCoQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5260
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10268 signatures=684655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 malwarescore=0 phishscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202250086
X-Proofpoint-ORIG-GUID: 5EsmNtSKFIhkmNNDd8l7YBoci5Y2WRrz
X-Proofpoint-GUID: 5EsmNtSKFIhkmNNDd8l7YBoci5Y2WRrz
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Thanks for the report, I will make this change in linux-next

Liam

* Wan Jiabing <wanjiabing@vivo.com> [220225 01:31]:
> Fix following coccicheck warning:
> ./lib/maple_tree.c:4177:9-10: WARNING: return of 0/1 in function
> mas_wr_append with return type bool.
>=20
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  lib/maple_tree.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 5f7295ba0309..933483726b85 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -4174,7 +4174,7 @@ static inline bool mas_wr_append(struct ma_wr_state=
 *wr_mas)
>  		mas->offset =3D new_end;
>  		wr_mas->pivots[end] =3D mas->index - 1;
> =20
> -		return 1;
> +		return true;
>  	} else if ((mas->index =3D=3D wr_mas->r_min) && (mas->last < wr_mas->r_=
max)) {
>  		if (new_end < node_pivots)
>  			wr_mas->pivots[new_end] =3D wr_mas->pivots[end];
> @@ -4185,9 +4185,9 @@ static inline bool mas_wr_append(struct ma_wr_state=
 *wr_mas)
> =20
>  		wr_mas->pivots[end] =3D mas->last;
>  		rcu_assign_pointer(wr_mas->slots[end], wr_mas->entry);
> -		return 1;
> +		return true;
>  	}
> -	return 0;
> +	return false;
>  }
> =20
>  static inline void mas_wr_modify(struct ma_wr_state *wr_mas)
> --=20
> 2.35.1
> =