Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Feb 2022 18:16:43 +0100
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
To:     Alexander Graf <graf@amazon.com>
Cc:     linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Len Brown <lenb@kernel.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Greg KH <gregkh@linuxfoundation.org>, ardb@kernel.org,
        dwmw@amazon.co.uk
Subject: Re: [PATCH] ACPI: bus: Match first 9 bytes of device IDs
Message-ID: <YhkO+wXED5IXlCMv@zx2c4.com>
References: <20220225155552.30636-1-graf@amazon.com>
 <YhkKc2fa8dSTA9pc@zx2c4.com>
 <7a98e9c5-e0e5-9bf9-71b5-f75b9ddcdc4b@amazon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <7a98e9c5-e0e5-9bf9-71b5-f75b9ddcdc4b@amazon.com>
Precedence: bulk

Hi Alex,

On Fri, Feb 25, 2022 at 06:09:59PM +0100, Alexander Graf wrote:
> You have to make this "VM_GEN_CO". I now match the full 9 bytes - unlike 
> the previous patch I sent :)

Ahh, so no NULL byte, but presumably no need because strncmp is used.
Great, seems to work.

There's the other aspect of udev matching, by the way. Have you tested
what happens in userspace? Need be, we could make the vmgenid driver a
bool instead of a tristate, but maybe there's a way to do that right?

Jason