Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <d2b87357-baf9-ef1f-6e6a-18aab8e6d2fd@nvidia.com>
Date:   Fri, 25 Feb 2022 11:36:30 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [RFC PATCH 0/7] block, fs: convert Direct IO to FOLL_PIN
Content-Language: en-US
To:     Jan Kara <jack@suse.cz>
Cc:     Jens Axboe <axboe@kernel.dk>,
        Christoph Hellwig <hch@infradead.org>,
        Dave Chinner <dchinner@redhat.com>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Theodore Ts'o <tytso@mit.edu>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Miklos Szeredi <miklos@szeredi.hu>,
        Andrew Morton <akpm@linux-foundation.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-mm@kvack.org,
        LKML <linux-kernel@vger.kernel.org>
References: <20220225085025.3052894-1-jhubbard@nvidia.com>
 <20220225120522.6qctxigvowpnehxl@quack3.lan>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20220225120522.6qctxigvowpnehxl@quack3.lan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWowak54dHZiWFU0YlgvL0xtQkdRcEdRK0pieS9pajVqc1pVbDlGeGx0ZlB1?=
 =?utf-8?B?TEdTWDkvanJYMHVQNzNJRkJKaEJ6QlRkbmlWekZVNnlDRDU2WDZid3orWkpI?=
 =?utf-8?B?Ui9TYmVpUTdzalBUak1oU0lvUnUvQjZQT3NXR296c05DdzM5S0NrZUJaaEUx?=
 =?utf-8?B?MHRLUENKSnVGbVVnOGl2VXhGMkpzVDZQQ2FsckQzZzZObHhhSDFRZDlMUll5?=
 =?utf-8?B?eFhZUUNsc3ptWGkrRWloV2Q3ZkdmYVFZSUVxWmdWV0ZjZEtrN3RFYjh1eDEr?=
 =?utf-8?B?eWlMcjZUSUhTdklwZ1c2eEc0NnZoTDFzVjlrQVpLNzBXdzNFMUwwVnNycXpv?=
 =?utf-8?B?eVZFY3hWc3p1TU9DSnI3TThtdS82dmZTb0h1Y1ZldEdnbGV0SWpLNzdINmNH?=
 =?utf-8?B?am5MbHRnSHEvKzJBSFJxdmN2WFJqZHMrVWNRUUt5QlNHdFhiNEVpU3lLWkFa?=
 =?utf-8?B?UlNhWW1KeUxnajh5c05uRURRNi9RcVZSNEMxNGRqSDB0bWgrdWpxUWRlc2pW?=
 =?utf-8?B?Tm9MZ1dUQjFMemFYdHY0czA4WUpmWUlBWnZUMVhtYWs1ZkVKUUxQN05DZ1lQ?=
 =?utf-8?B?WFlwd3dpWmg2dnd1ZWVueHlPcU1xNUpWaXRuUElaYVFIa1U5NndacGNmQXJp?=
 =?utf-8?B?QTFodXpDS2FFSS9XNEdCSHkxNFBXTWNXU3ZTVXcyT1RNZXZVeWVuK1VFaU50?=
 =?utf-8?B?U0VQcEZ4WFlqUU5JK2hxNWptVXRKWEpDQ2RGN1VESG10TDY3eXlYVnBEUkMr?=
 =?utf-8?B?b0JmNGI1UEdyK2lGZXBMVkw4aXVkU2lYdkxVeW1ReTQwcEtUNmgvcnJsVjF1?=
 =?utf-8?B?YXpMR1M0cW5rVlAvMDlJQnZkcUpKOHZrZUoxWXhtdVhRZmpPc0x3OE84SFBI?=
 =?utf-8?B?dkNPckozeVlYZHhCZkFVNCtwNmt5b0gyd2xRMk1TZGdOcWF0ZHc5b0FYMnh2?=
 =?utf-8?B?cUFGZDNIU210Y1dEdlgxcU1pRmlKaG1tY1FjTm41RlVQWW4yYlBwWHllVURP?=
 =?utf-8?B?SEhLbzN3NVl5UG0wZGlZNkJXUFhoM0pBbXpZdk8xbVlJNWpJc2VER1ZTSzhk?=
 =?utf-8?B?SHBxb3VCd0JZM1Zienl5cHloUXo3SjVGMWdUV2RDQjhuazZPTTlqZVNyRWtU?=
 =?utf-8?B?KzRsL2ZmZGgrK3pRdm9Qd2Q2UVh3NGxWaEV0S2dTRy96aUtVeUV1U1FpK0Y0?=
 =?utf-8?B?NDBOcTBYQU5NUVBYWWR2c0FEd2tCVlJIcXNDejlGUzF2dW9EZWFpQmhpZzEz?=
 =?utf-8?B?Rkh1Z1grVUFKb2RQdFkwQUlHOWxzVVJtZFhmZ3pjTERNejhNdVdlQnZDMllo?=
 =?utf-8?B?R3BXNG9NVkM2eEUxZWtnNzYyblA1b21KUnFwRFJJMlp1WDAwSmpMaEJIWnZk?=
 =?utf-8?B?YUc3SG9VYVBPSURuWWFPY1hJdlB6ZlhtRWxPUVZiQzZZR3lCWWVVRzcrN0M1?=
 =?utf-8?B?N3JJQkhPbDNNK3I5TWxIaDdCeHJWUUVicHluZHh4QlJVaStTRUlOU1ZHSHlw?=
 =?utf-8?B?Tit5QVRhY3RvSCsrWW4wMklhWUtiTmdjRURhMzBQL3VhQnF3RWRKMy9FN245?=
 =?utf-8?B?bUN5RGQ5djhPb2FEeC9lZVd6T0Q3YjNzTlNxZmZQc3VSSkV1TWVmMzBSYkNh?=
 =?utf-8?B?NkJUdk9kdkZyU1B5Vzh6UERObERyQktUNUV1cGpuVnJVVXNwMjhkTmRwTVpW?=
 =?utf-8?B?amJ4M3FVcWtaRmdiUDIxUHlheW4yNjQ0Yk1pVTlIbUVURkVqZjZZSEZrbUJy?=
 =?utf-8?B?WWlQRGVkYllMcDhUODJySTVmclErcUkxQ0d4OCtHTEZsR09HODU4WUxVU3A3?=
 =?utf-8?B?VVJXc1JsME5oQUFDRG9Qb290UHZUUVZuWTlId0RXUVB5dTV3SGpJK2xBM0t1?=
 =?utf-8?B?c09Fd0g3RGt2cUtMV045ZWljN2tiTytQSURrWW9FVk40VFQyUWVFV3JvSEpi?=
 =?utf-8?B?RytQRkJ6VXlGY0Y1TXVhcWp6T0NvcENMMlphVVVPd1ZwRjQxUDErWUxoamhu?=
 =?utf-8?B?UXZ5ZlZ3ckRBZ21PNnp1dWRCNzlWYlM5OGRxZUZaRCtSNVZ1M2ZwekNDZFdD?=
 =?utf-8?B?UjVtU3g0YlZHQ0NObmptbjhvSWVtOS9vYjVwdlNMRi9mK3d6RThWZDZXTDk4?=
 =?utf-8?B?TU4zWnJzR1pFSXJvYXEyTzNyZkxrMDVwTC9jeEZ0S296cHNzcFFGVEhBSXRt?=
 =?utf-8?Q?rBKlTbqIMFZdgvdMJqzybw0=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a7ccdf0-d6b8-447e-18cc-08d9f89621ac
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 19:36:34.6626
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oPQqNe+0pdrielX3Em4BzfxO2HioTHPFjoulEAll7Gpm95WeyxGW0YEFQoyqv82+9DK70OnWTj/EfkJz3xhF2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1723
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/25/22 04:05, Jan Kara wrote:
...
>> After quite some time exploring and consulting with people as well, it
>> is clear that this cannot be done in just one patchset. That's because,
>> not only is this large and time-consuming (for example, Chaitanya
>> Kulkarni's first reaction, after looking into the details, was, "convert
>> the remaining filesystems to use iomap, *then* convert to FOLL_PIN..."),
>> but it is also spread across many filesystems.
> 
> With having modified fs/direct-io.c and fs/iomap/direct-io.c which
> filesystems do you know are missing conversion? Or is it that you just want
> to make sure with audit everything is fine? The only fs I could find
> unconverted by your changes is ceph. Am I missing something?
> 
> 								Honza

There are a few more filesystems that call iov_iter_get_pages() or
iov_iter_get_pages_alloc(), plus networking things as well, plus some
others that are hard to categorize, such as vhost. So we have:

* ceph
* rds
* cifs
* p9
* net: __zerocopy_sg_from_iter(), tls_setup_from_iter(),
* crypto: af_alg_make_sg() (maybe N/A)
* vmsplice() (as David Hildenbrand mentioned)
* vhost: vhost_scsi_map_to_sgl()

In addition to that, I was also worried that maybe the
blockdev_direct_IO() or iomap filesystems might be breaking encapsulation
occasionally, by calling put_page() on the direct IO user page buffer.
Perhaps in error paths.

Are you pretty sure that that last concern is not valid? That would be a
welcome bit of news.


thanks,
-- 
John Hubbard
NVIDIA