Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp698989pxm; Fri, 25 Feb 2022 17:37:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7MeCgdS9skm3Xy05fYne42UPnRdfwWMp+6FAMqvJ7Thxpzcvd15Z+OZ7s7C06AF+TWAYx X-Received: by 2002:a17:902:bd88:b0:14f:8ddf:e373 with SMTP id q8-20020a170902bd8800b0014f8ddfe373mr9834650pls.89.1645839428815; Fri, 25 Feb 2022 17:37:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645839428; cv=none; d=google.com; s=arc-20160816; b=NJ/V4ncT8zw0qM04yYsklR4d6SvgYIR1EBgXh1Hm+5Cj2fjkzdKzRY1RGyudxfNvSz 7ysUZkUTQjGuJ/rdksLBgLeVeNsI2ajj7JKhRughB2CbFjbzL4ZyZvOSxqCCNrxor5Bh +xsKKD8BenmoViLvtZYFZRM04hTOZ9jVsw9DHexOIzrT3Hw0ZhFEaD34Jp7WIs0OrjoZ k+cRuarMC/0edHh3QCUpDSsgDlS5ncndGzCcnkvR+xjoQJzmmWPwQc6SbodnYnJhDw4S WT4nobVYbJzbaWcFhLKLQ1/YNjoY5TtkBkG01RaFSNiZnUGu4LGuuBxf4aZ6cWlOwn/8 W3rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=E9tlm0bYbuFCL4eTySYXlyyWt4det591cN1hShBwdzQ=; b=MWyM5oqNpp3DxMez4beeuJzbWr5bMpgBl0o+dGjyOxMzA41FcyMbotR4r96DYYNPHm rPT2OAOdpn3rweBWATbH/qvdwar34oieKzIH7EMz1STfoC3ye/a1CyiodhD3A8kpRI4B /IOiIQ1yrKaTOJiUOdZnhchNjj4WRyhyR7bzkfEHSzJdEc98do2g/h8aNCoO1tC5SNOy se+/+f405FllLJA1OOqwfSQ4FbfGHv0kRlsiY+AAMoeSvTsqjJ/o6dWg/hNdLaOJUDjR JWgfiHPp3p1t+9Oj1DRgmGvRrpdb/MaofV8cBmh8H3cko5ckZ89E1crkNvfbKdjivERk bmrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Btqx1law; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id g19-20020a63fa53000000b00364cc2c3c29si3062293pgk.264.2022.02.25.17.37.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 17:37:08 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Btqx1law; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 511792193EF; Fri, 25 Feb 2022 17:31:32 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240658AbiBYMbp (ORCPT + 99 others); Fri, 25 Feb 2022 07:31:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240654AbiBYMbo (ORCPT ); Fri, 25 Feb 2022 07:31:44 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E0482177CA for ; Fri, 25 Feb 2022 04:31:12 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id s13so4265830wrb.6 for ; Fri, 25 Feb 2022 04:31:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=E9tlm0bYbuFCL4eTySYXlyyWt4det591cN1hShBwdzQ=; b=Btqx1lawzvIvfIgGLkqYleHyukZjyOU0UBH8Cp/zSYvsvo6YJh3Of6HJfSMjTpXyQn LHtpX3ShlMTBu/Xai4U7LdaDIuauBSZuWqmEqJ42s66PpIPzcvpMULdoO1SYn/L6NzId +nXVaGDRTBLAeJpydy/KribbaO86n3IA/tBb6cJGrV8aIEs8xN6K4WBqMOTLoV2vE3VQ ebtyoUTxkNmEQPH/0jZQLsCNNaj+GnE/+3D08ll9RRWQ3Amf10MOVkVLxY/rg65l0L4h s58z88vYSQIFAM4pVxJxjRnt+cPvC8DlTFLSCK63H6PohNLqYpGyiN9PDSCow6CqnK0r VyMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=E9tlm0bYbuFCL4eTySYXlyyWt4det591cN1hShBwdzQ=; b=qeuGJFysrGiVbZNswFwosDeD8VEJEOuQF3wcuP+8hlac0ERuYET9NWO7azJmRN7vyC p+uBnd1xaob5To/avSyNqfhjR2bTQrtRGzC61QwjXFFvPvemZvz8460TCHlTsYA7PVCa IDS/gD2RqKn9uMXA2+bowcIPOdtv6LzcMkgknYWUIGMnpyQHgHgd3pGE4C3Z8Gp8/jDu +ZZH0cMWptz1TYZH6J+v9/kFj/DKuMcMaaibQ+U0mzurEZn/P2NNSDBjXQpsW1Ji2+hv trWYiqndyhzwZKHxkDvCffSF24bBlFUXuuXj7sc72p2WgdmOBt/Za7ssHxJLSrKIr7WT 4kIQ== X-Gm-Message-State: AOAM532JaqYe+fArqG1OpPfMM2gQ7jOnazzQwx8yxuEVT1wQi0b+7Aqh sw6R0+Cd0VFiUllHcrmNtaKN4sskOcrvHA== X-Received: by 2002:adf:f1c1:0:b0:1e3:1381:7bd5 with SMTP id z1-20020adff1c1000000b001e313817bd5mr6091442wro.450.1645792271218; Fri, 25 Feb 2022 04:31:11 -0800 (PST) Received: from localhost.localdomain ([64.64.123.58]) by smtp.gmail.com with ESMTPSA id r18-20020a056000015200b001edc12960fdsm2140916wrx.67.2022.02.25.04.31.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 04:31:10 -0800 (PST) From: Jia-Ju Bai To: airlied@linux.ie Cc: linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] char: agp: intel-agp: check the return value of pci_find_capability() Date: Fri, 25 Feb 2022 04:31:00 -0800 Message-Id: <20220225123100.25995-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function pci_find_capability() in agp_intel_probe() can fail, so its return value should be checked. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/char/agp/intel-agp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c index 9e4f27a6cb5a..6a7e385bde8a 100644 --- a/drivers/char/agp/intel-agp.c +++ b/drivers/char/agp/intel-agp.c @@ -730,6 +730,8 @@ static int agp_intel_probe(struct pci_dev *pdev, int i, err; cap_ptr = pci_find_capability(pdev, PCI_CAP_ID_AGP); + if (!cap_ptr) + return -ENODEV; bridge = agp_alloc_bridge(); if (!bridge) -- 2.17.1