Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <7859e03f-10fa-dbc2-ed3c-5c09e62f9016@redhat.com>
Date:   Fri, 25 Feb 2022 16:13:21 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3] KVM: VMX: Enable Notify VM exit
Content-Language: en-US
To:     Xiaoyao Li <xiaoyao.li@intel.com>,
        Jim Mattson <jmattson@google.com>,
        Chenyi Qiang <chenyi.qiang@intel.com>
Cc:     Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220223062412.22334-1-chenyi.qiang@intel.com>
 <CALMp9eT50LjXYSwfWENjmfg=XxT4Bx3RzOYubKty8kr_APXCEw@mail.gmail.com>
 <88eb9a9a-fbe3-8e2c-02bd-4bdfc855b67f@intel.com>
 <6a839b88-392d-886d-836d-ca04cf700dce@intel.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <6a839b88-392d-886d-836d-ca04cf700dce@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/25/22 16:12, Xiaoyao Li wrote:
>>>>
>>>
>>> I don't like the idea of making things up without notifying userspace
>>> that this is fictional. How is my customer running nested VMs supposed
>>> to know that L2 didn't actually shutdown, but L0 killed it because the
>>> notify window was exceeded? If this information isn't reported to
>>> userspace, I have no way of getting the information to the customer.
>>
>> Then, maybe a dedicated software define VM exit for it instead of 
>> reusing triple fault?
>>
> 
> Second thought, we can even just return Notify VM exit to L1 to tell L2 
> causes Notify VM exit, even thought Notify VM exit is not exposed to L1.

That might cause NULL pointer dereferences or other nasty occurrences.

Paolo