Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp706002pxm; Fri, 25 Feb 2022 17:50:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJzrGxZfDpDkzJmPV4ZdHO4vLcHWx1mUJrzvWHXVfi2q4aJ+4kQWQmMON1xFxq2/tSxbTsub X-Received: by 2002:a17:90a:6a8a:b0:1bc:2953:75ed with SMTP id u10-20020a17090a6a8a00b001bc295375edmr5909999pjj.130.1645840203551; Fri, 25 Feb 2022 17:50:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645840203; cv=none; d=google.com; s=arc-20160816; b=k9IU4MCY2AD1Nfqpvt3Kfdw8OvMKe63yu1Tb99XZDT1wEVSWkGyZHxlIcJnuI9o6EP MPKOkyBJK9W2HRhFUGaDITc0iTYCtjLm4G1i8yGYMSUoJ3ionkAYtPahtayzepOA5CIs j1s/ssCupyhZsf5sDQ69BxoEZtcKYvli2WXdHZSXP19wIE0f6z4m6J4fQIzKqxpQ7JQi vsnDCBVy7labjCnF7GJrGwYAzgFmUM9baGEllrASC/yvBZr8ZlvReeztVL8umTqQ5V2q FAjaws7MDTXuDPOkkdxtLbsYmgG88QCGZQ7tsEcZEyg2g+jwGyq9e+fyECBcPm6M1+Xd PV+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=oWC0YbmclU1/rupUD32FXFHq6eElAXM2xq7gQcBXak0=; b=j3n+DHQkImbYUuFW4XQzRXbYhNK283cAkFiiAzZ2gx6GEkapP4Q4T+VMyOq5MtCjHD wAg7dM9ftlrr7Tu1sCi31ztHvULAEeIPF0QjqT4jA5bWjMMiba5OJledAV+HxafIXQp8 zrcNBB0EMe8DI8hl/vgKoWLbpgHHRK2N3Br5jHh/ai3e3E2B9VFRbZNyi1ZG2+wtlfM/ T06AAWKbhSQBNNkvbmcNfqM3LXSoQ0bLpbrRwNIyIsVNJICQ/8MGiLCgMRQ2Gi+Ttqnj 4npA+H0GARhFv5Gpw52GYjMj7QSZeAW7alOEgl7DP0GK0CVHOrFuGAFN0ZaCqvP7d/wc xEkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="ZBbh+Q/x"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id fr9-20020a17090ae2c900b001bca5db28d6si3499539pjb.32.2022.02.25.17.50.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 17:50:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="ZBbh+Q/x"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7B6D5DF2A; Fri, 25 Feb 2022 17:37:33 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240756AbiBYMxQ (ORCPT + 99 others); Fri, 25 Feb 2022 07:53:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240751AbiBYMxP (ORCPT ); Fri, 25 Feb 2022 07:53:15 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D2A616AA43; Fri, 25 Feb 2022 04:52:43 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id o62-20020a1ca541000000b00380e3cc26b7so1666183wme.0; Fri, 25 Feb 2022 04:52:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=oWC0YbmclU1/rupUD32FXFHq6eElAXM2xq7gQcBXak0=; b=ZBbh+Q/xIlciESMD0GrmlN7WswAz2h4ORJHQgFeNhyFVSRDu7C0zlV+k4Ah8oeGGzZ bIdvFnHnMDAg7ujH6gc6zb+jFMGR28blPonpfYee/GJu0jQqN+dntWTobfMndQNXi7Pr b0XEc9sFSz41izSWUO7Z2NISBIB+MKBoh9BPSb/Er8iTbrVstwbnpzsRTk5ayLbM2lQP aFaEmRulRdGTynm4NEo6+bzOtx2h9zz1maMOimDON6MVzWaJPl0P0QB2S+kuCfnDnhxC XSxTTC1N+1dCgw8ZYVVNkDvF4EqoAu1v8QbZwKBq9aUtR7seHdmPFowFi6W3E0liL/jC HUEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=oWC0YbmclU1/rupUD32FXFHq6eElAXM2xq7gQcBXak0=; b=tQSaT88f74etuhwj+/qDLtnLJi8NB587S+xPDnwOXoks86mco5CYr2QYOUDJymj8ca W1r2Nd7oHvWjvowoXRgKuENw4z/ZiPuIvBWX9rMZRrUyGQzgVEwVbOSyiYPTCjFvDjBn KPwsNr7SVsE3rjrY1DJBHQSKLLDcH4K5524JuzwbGLq7T0Xl+0sjgueAmwI6/M3RftXT mPwFb5QPmUhKydJt64dN24/ZKiRe2wO0hIzWvYqTB3yAs0GdZwlBL9eG1a77V+oYCxrp gDsvqT/fgx6VjQCfGia4Scq8JuJovlfKxwEFqBKFVRILQhjk88IzbcXN+1NNWqBFf2Vn DwXw== X-Gm-Message-State: AOAM533ztiZNbGiTylk01t5bI2E6bwiONdI/fuetcE4QLiI0Hpck/3E2 tc5uLU3NxPKvuhaz4BbxsdfqqTVI9g6wuQ== X-Received: by 2002:a05:600c:1c8d:b0:37b:fb3b:adf3 with SMTP id k13-20020a05600c1c8d00b0037bfb3badf3mr2642601wms.64.1645793561858; Fri, 25 Feb 2022 04:52:41 -0800 (PST) Received: from localhost.localdomain ([64.64.123.58]) by smtp.gmail.com with ESMTPSA id x1-20020a05600c420100b003811fb95734sm3167713wmh.37.2022.02.25.04.52.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 04:52:41 -0800 (PST) From: Jia-Ju Bai To: 3chas3@gmail.com Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] atm: firestream: check the return value of ioremap() in fs_init() Date: Fri, 25 Feb 2022 04:52:30 -0800 Message-Id: <20220225125230.26707-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function ioremap() in fs_init() can fail, so its return value should be checked. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/atm/firestream.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c index 3bc3c314a467..4f67404fe64c 100644 --- a/drivers/atm/firestream.c +++ b/drivers/atm/firestream.c @@ -1676,6 +1676,8 @@ static int fs_init(struct fs_dev *dev) dev->hw_base = pci_resource_start(pci_dev, 0); dev->base = ioremap(dev->hw_base, 0x1000); + if (!dev->base) + return 1; reset_chip (dev); -- 2.17.1