Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <3f5fdfca-1bbc-d6aa-4649-c50a9cd92052@microchip.com>
Date:   Fri, 25 Feb 2022 11:26:12 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v7] ARM: dts: add DT for lan966 SoC and 2-port board
 pcb8291
Content-Language: en-US
To:     Michael Walle <michael@walle.cc>
CC:     Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>,
        <arnd@arndb.de>, <alexandre.belloni@bootlin.com>, <olof@lixom.net>,
        <soc@kernel.org>, <robh+dt@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <UNGLinuxDriver@microchip.com>, <Manohar.Puri@microchip.com>
References: <20220221080858.14233-1-kavyasree.kotagiri@microchip.com>
 <3b4c56201a478876783e69243c901cd8@walle.cc>
 <85566f97-dcfc-f477-1ebb-5cac955b791a@microchip.com>
 <413b29b8a2e7a73561f942d4b7c78b9b@walle.cc>
From:   Nicolas Ferre <nicolas.ferre@microchip.com>
Organization: microchip
In-Reply-To: <413b29b8a2e7a73561f942d4b7c78b9b@walle.cc>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 24/02/2022 at 15:55, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hi,
> 
> Am 2022-02-24 15:51, schrieb Nicolas Ferre:
>>>> +/ {
>>>> +     model = "Microchip LAN966 family SoC";
>>>> +     compatible = "microchip,lan966";
>>>
>>> As mentioned earlier, this isn't a documented compatible string. So,
>>> I guess without overwriting this in the board dts it will throw an
>>> error with the dt schema validator. OTOH, there are many dtsi files
>>> in arch/arm/boot/dts/ doing this. I don't know what is correct here.
>>
>> I see it documented here:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/atmel-at91.yaml#n165
>>
>> Isn't it what is expected?
> 
> That only documents
>     compatible = "microchip,lan9662-pcb8291", "microchip,lan9662",
> "microchip,lan966";
> 
> But not the one above.

Oh, you mean the "microchip,lan966" string alone in the compatibility 
string and not with the other ones before it...
I didn't know it could be different in yaml syntax. Thanks for 
highlighting that.

Best regards,
   Nicolas

> 
>>
>>> Everthing else looks good.
>>
>> Thanks a lot for your reviews.
>>
>>> Reviewed-by: Michael Walle <michael@walle.cc>
>>
>> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>> I'm queuing it to at91-dt branch for reaching arm-soc in 5.18 merge
>> window.
> 
> Nice, then I'm good to go for my patches on top of this :)
> 
> -michael


-- 
Nicolas Ferre